[Bug 22951] New: Markup error in OPAC holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Bug ID: 22951 Summary: Markup error in OPAC holds template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Target Milestone: --- There is a markup error somewhere in the OPAC holds template (opac-reserve.tt) which is causing a validation error: - "Stray end tag div." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91018&action=edit Bug 22951: Markup error in OPAC holds template This patch makes minor markup changes to the OPAC holds template in order to fix validation errors. To test, apply the patch and go through the process of placing a hold in the OPAC. Test various aspects of the process, including cases where the hold is blocked and an error message is displayed (for instance, when there are no items to be placed on hold). The page should work correctly and validating the source should return no relevant errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91019&action=edit Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91018|0 |1 is obsolete| | Attachment #91019|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 91295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91295&action=edit Bug 22951: Markup error in OPAC holds template This patch makes minor markup changes to the OPAC holds template in order to fix validation errors. To test, apply the patch and go through the process of placing a hold in the OPAC. Test various aspects of the process, including cases where the hold is blocked and an error message is displayed (for instance, when there are no items to be placed on hold). The page should work correctly and validating the source should return no relevant errors. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 91296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91296&action=edit Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91296|0 |1 is obsolete| | --- Comment #5 from Nadine Pierre <nadine.pierre@InLibro.com> --- Created attachment 91360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91360&action=edit Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Frédérik Chénier <frederik.chenier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91295|0 |1 is obsolete| | --- Comment #6 from Frédérik Chénier <frederik.chenier@inlibro.com> --- Created attachment 91365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91365&action=edit Bug 22951: Markup error in OPAC holds template This patch makes minor markup changes to the OPAC holds template in order to fix validation errors. To test, apply the patch and go through the process of placing a hold in the OPAC. Test various aspects of the process, including cases where the hold is blocked and an error message is displayed (for instance, when there are no items to be placed on hold). The page should work correctly and validating the source should return no relevant errors. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Frédérik Chénier <frederik.chenier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91360|0 |1 is obsolete| | --- Comment #7 from Frédérik Chénier <frederik.chenier@inlibro.com> --- Created attachment 91366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91366&action=edit Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91365|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91380&action=edit Bug 22951: Markup error in OPAC holds template This patch makes minor markup changes to the OPAC holds template in order to fix validation errors. To test, apply the patch and go through the process of placing a hold in the OPAC. Test various aspects of the process, including cases where the hold is blocked and an error message is displayed (for instance, when there are no items to be placed on hold). The page should work correctly and validating the source should return no relevant errors. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91366|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91381&action=edit Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.03 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org