[Bug 41653] New: Stores for permissions and sysprefs should be under the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Bug ID: 41653 Summary: Stores for permissions and sysprefs should be under the Koha namespace Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 41324, 41562 See bug 41562 comment 7. To avid collision with other scripts we should have the functions and variables under the Koha namespace. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 [Bug 41324] Tidy kohaTable block https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41562 [Bug 41562] Introduce the concept of "stores" for regular javascript -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191570&action=edit Bug 41653: Move addPrefs and addPermissions under the Koha namespace Patch from commit 426a2cf -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191570|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191571&action=edit Bug 41653: Move addPrefs and addPermissions under the Koha namespace Patch from commit dcee0c2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 [Bug 42094] Tidy all script tags -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191571|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196694&action=edit Bug 41653: Move addPrefs and addPermissions under the Koha namespace Patch from commit c0340a0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- A test plan could be: git grep -P 'permissions\.\w' **/*.tt **/*.inc **/*.js |grep -v Koha.permissions => No relevant occurrences git grep 'prefs\.\w' **/*.tt **/*.inc **/*.js |grep -v Koha.prefs => No relevant occurrences Note that the following one will be fixed by "Bug 41582: Fix tags - OPAC" that is not pushed yet: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt: if (prefs.TagsInputEnabled && loggedinusername) { git grep 'addPrefs' **/*.tt **/*.inc **/*.js |grep -v Koha.addPrefs git grep 'addPermissions' **/*.tt **/*.inc **/*.js |grep -v Koha.addPermissions => No occurrences outside js/stores.js -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Tried applying this to test a dependency of bug 42094 which also depends on this, but this no longer applies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196694|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197043&action=edit Bug 41653: Move addPrefs and addPermissions under the Koha namespace Patch from commit b249334 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Comment on attachment 197043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197043 Bug 41653: Move addPrefs and addPermissions under the Koha namespace
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc - if (prefs.LocalCoverImages || prefs.OPACLocalCoverImages) { + if (Koha.prefs.LocalCoverImages || prefs.OPACLocalCoverImages) {
There's two 'prefs.' there, and only one changed to 'Koha.prefs', which breaks loading the items table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197043|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197121&action=edit Bug 41653: Move addPrefs and addPermissions under the Koha namespace Patch from commit e338e36 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Phil Ringnalda from comment #7)
Comment on attachment 197043 [details] [review] Bug 41653: Move addPrefs and addPermissions under the Koha namespace
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc - if (prefs.LocalCoverImages || prefs.OPACLocalCoverImages) { + if (Koha.prefs.LocalCoverImages || prefs.OPACLocalCoverImages) {
There's two 'prefs.' there, and only one changed to 'Koha.prefs', which breaks loading the items table.
Fixed, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42295 [Bug 42295] Tidy all script tags - includes staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 [Bug 42294] Tidy all script tags - patron searches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42293 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42293 [Bug 42293] Tidy all script tags - serials -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42292 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42292 [Bug 42292] Tidy all script tags - opac -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42291 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42291 [Bug 42291] Tidy all script tags - shelves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42290 [Bug 42290] Tidy all script tags - suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42289 [Bug 42289] Tidy all script tags - tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42288 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42288 [Bug 42288] Tidy all script tags - reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42287 [Bug 42287] Tidy all script tags - members -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42286 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42286 [Bug 42286] Tidy all script tags - ill -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42284 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42284 [Bug 42284] Tidy all script tags - addbiblio/authorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42283 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42283 [Bug 42283] Tidy all script tags - cataloguing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 [Bug 42282] Tidy all script tags - catalogue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42281 [Bug 42281] Tidy all script tags - authorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 [Bug 42280] Tidy all script tags - admin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42279 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 [Bug 42279] Tidy all script tags - acqui -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42278 [Bug 42278] Tidy all script tags - circ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197121|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 197172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197172&action=edit Bug 41653: Move addPrefs and addPermissions under the Koha namespace Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197172|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 197558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197558&action=edit Bug 41653: Move addPrefs and addPermissions under the Koha namespace Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #13 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org