https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25281 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25281 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103704|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103708&action=edit Bug 25281: Use modal confirmation when deleting a list in the OPAC This patch modifies the process of deleting a list in the OPAC so that the deletion confirmation alert is replaced with a Bootstrap modal. In the process, I moved the repeated deletion form markup into a block To test, apply the patch and log in to the OPAC as a user who has multiple lists, including some which have been shared with other users. Go to the list of your lists and click the "Delete" link next to any of your lists. It should trigger a confirmation modal: - The modal should show the title of the list you're deleting. - If the list has titles on it, it show how many. - If the list has been shared with someone it should say so. Next, view a list which is not empty. - Test the "Delete list" link in the toolbar. - You should see the same information in the confirmation message as in the previous step. Do the same with a list which is empty. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25281 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103708|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 103709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103709&action=edit Bug 25281: Use modal confirmation when deleting a list in the OPAC This patch modifies the process of deleting a list in the OPAC so that the deletion confirmation alert is replaced with a Bootstrap modal. In the process, I moved the repeated deletion form markup into a block To test, apply the patch and log in to the OPAC as a user who has multiple lists, including some which have been shared with other users. Go to the list of your lists and click the "Delete" link next to any of your lists. It should trigger a confirmation modal: - The modal should show the title of the list you're deleting. - If the list has titles on it, it show how many. - If the list has been shared with someone it should say so. Next, view a list which is not empty. - Test the "Delete list" link in the toolbar. - You should see the same information in the confirmation message as in the previous step. Do the same with a list which is empty. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25281 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103709|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103715&action=edit Bug 25281: Use modal confirmation when deleting a list in the OPAC This patch modifies the process of deleting a list in the OPAC so that the deletion confirmation alert is replaced with a Bootstrap modal. In the process, I moved the repeated deletion form markup into a block To test, apply the patch and log in to the OPAC as a user who has multiple lists, including some which have been shared with other users. Go to the list of your lists and click the "Delete" link next to any of your lists. It should trigger a confirmation modal: - The modal should show the title of the list you're deleting. - If the list has titles on it, it show how many. - If the list has been shared with someone it should say so. Next, view a list which is not empty. - Test the "Delete list" link in the toolbar. - You should see the same information in the confirmation message as in the previous step. Do the same with a list which is empty. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25281 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.