[Bug 5343] New: Subscription cost
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Summary: Subscription cost Change sponsored?: Sponsored Product: Koha Version: rel_3_4 Platform: All URL: http://wiki.koha-community.org/wiki/Cost_serials_RFC OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Serials AssignedTo: henridamien@koha-fr.org ReportedBy: paul.poulain@biblibre.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 When adding a subscription, the librarian will be able to enter the price of a subscription, the budget, and the VAT (defaulted to the supplier default VAT). If the librarian enters informations, a basket, a basket group will be automatically created with the appropriate informations -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Depends on| |5335 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|henridamien@koha-fr.org |jonathan.druart@biblibre.co | |m --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch will allow to create a new order from a subscription. It is currently blocked by Bug 5335. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7288 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13010&action=edit Bug 5343: Link serial and acqui modules DB changements: - Adds 2 fields: subscription.reneweddate and aqorders.subscriptionid. - Removes 2 unused fields: aqorders.serialid and aqorders.subscription. Main test plan: 1) Create a subscription 2) Create a bookseller and a basket 3) Add a new order 'from a subscription' 4) Search your subscription and check if results are correct 5) Click on the "order" link 6) Check the biblio information are filled in the form 7) Select a budget and fill some price information. 8) retry steps 3 and 4. Verify you cannot order the same subscription. Message:Outstanding order (only one order per subscription is allowed). 9) click on your subscription (already added) and check you have a new table "Acquisition details" with your price information in the "Ordered amount" line. 10) receive this order 11) On your subscription detail page, the "Spent amount" line must be filled with your price information. 12) Re order the same subscription. Now you are allowed to. Prices information have to be filled with the previous information. 13) Retry some orders and click on a maximum of links in order to find a bug :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13010|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13011&action=edit Bug 5343: Link serial and acqui modules DB changements: - Adds 2 fields: subscription.reneweddate and aqorders.subscriptionid. - Removes 2 unused fields: aqorders.serialid and aqorders.subscription. Main test plan: 1) Create a subscription 2) Create a bookseller and a basket 3) Add a new order 'from a subscription' 4) Search your subscription and check if results are correct 5) Click on the "order" link 6) Check the biblio information are filled in the form 7) Select a budget and fill some price information. 8) retry steps 3 and 4. Verify you cannot order the same subscription. Message:Outstanding order (only one order per subscription is allowed). 9) click on your subscription (already added) and check you have a new table "Acquisition details" with your price information in the "Ordered amount" line. 10) receive this order 11) On your subscription detail page, the "Spent amount" line must be filled with your price information. 12) Re order the same subscription. Now you are allowed to. Prices information have to be filled with the previous information. 13) Retry some orders and click on a maximum of links in order to find a bug :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Jonathan, have you seen this is a duplicate to bug 8415 and related bug 8456? I tried to get the patch Amit Gupta created from Biblibres patch working and did some follow-ups - I am happy to test this as soon as there is time. But could you take a look maybe at the other bugs? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #4)
Jonathan, have you seen this is a duplicate to bug 8415 and related bug 8456? I tried to get the patch Amit Gupta created from Biblibres patch working and did some follow-ups - I am happy to test this as soon as there is time. But could you take a look maybe at the other bugs?
Hi Katrin, Yes I know... But it was easiest to me to recreate the patch from scratch rather than created somes followups for others patches. Several remarks you made for Bug 8415 and Bug 8456 are fixed in my patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Subscription cost |Subscription cost (Link | |serial and acqui modules) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@osslabs.biz --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 8456 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 8415 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8456, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8415 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, that's ok - I figured that was the reason and working on the patch it makes a lot of sense to me to redo it. I really got stuck in the end and found a lot of problems. All I was hoping for is that you take a look at the remarks to see if they still apply to your new patch and close the other bugs - which you did :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9346 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13011|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15840&action=edit Bug 5343: Link serial and acqui modules DB changements: - Adds 2 fields: subscription.reneweddate and aqorders.subscriptionid. - Removes 2 unused fields: aqorders.serialid and aqorders.subscription. Main test plan: 1) Create a subscription 2) Create a bookseller and a basket 3) Add a new order 'from a subscription' 4) Search your subscription and check if results are correct 5) Click on the "order" link 6) Check the biblio information are filled in the form 7) Select a budget and fill some price information. 8) retry steps 3 and 4. Verify you cannot order the same subscription. Message:Outstanding order (only one order per subscription is allowed). 9) click on your subscription (already added) and check you have a new table "Acquisition details" with your price information in the "Ordered amount" line. 10) receive this order 11) On your subscription detail page, the "Spent amount" line must be filled with your price information. 12) Re order the same subscription. Now you are allowed to. Prices information have to be filled with the previous information. 13) Retry some orders and click on a maximum of links in order to find a bug :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- I get this error when searching for a subscription in Step 4: Can't use string (" [my search string] ") as a HASH ref while "strict refs" in use at /home/oleonard/kohaclone/C4/Serials.pm line 669. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15840|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16321&action=edit Bug 5343: Link serial and acqui modules Oops sorry, I forgot to change a call to SearchSubscriptions. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #12 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- There's a problem at step 10 : I can't receive the order because I can't fill Quantity received in page orderreceive.pl (syspref AcqCreateItem =Create an item when placing an order) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16482&action=edit Bug 5343: Followup FIX quantity received if items are created when receiving For subscriptions, if items are created when receiving, the quantity received is always 1, not 0. + UI: Show the subscription search form (instead of hidden) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #12)
There's a problem at step 10 : I can't receive the order because I can't fill Quantity received in page orderreceive.pl (syspref AcqCreateItem =Create an item when placing an order)
It should be fixed with this last patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16482|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16492&action=edit Bug 5343: Followup FIX quantity received if items are created when receiving For subscriptions, if items are created when receiving, the quantity received is always 1, not 0. + UI: Show the subscription search form (instead of hidden) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16510&action=edit Bug 5343: Followup: invoicenumber no longer exists, use invoiceid. A previous patch replaces invoicenumber with invoiceid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #17 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- patch does not apply M. Saby -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16321|0 |1 is obsolete| | Attachment #16492|0 |1 is obsolete| | Attachment #16510|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16624&action=edit Bug 5343: Link serial and acqui modules DB changements: - Adds 2 fields: subscription.reneweddate and aqorders.subscriptionid. - Removes 2 unused fields: aqorders.serialid and aqorders.subscription. Main test plan: 1) Create a subscription 2) Create a bookseller and a basket 3) Add a new order 'from a subscription' 4) Search your subscription and check if results are correct 5) Click on the "order" link 6) Check the biblio information are filled in the form 7) Select a budget and fill some price information. 8) retry steps 3 and 4. Verify you cannot order the same subscription. Message:Outstanding order (only one order per subscription is allowed). 9) click on your subscription (already added) and check you have a new table "Acquisition details" with your price information in the "Ordered amount" line. 10) receive this order 11) On your subscription detail page, the "Spent amount" line must be filled with your price information. 12) Re order the same subscription. Now you are allowed to. Prices information have to be filled with the previous information. 13) Retry some orders and click on a maximum of links in order to find a bug :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16625&action=edit Bug 5343: Followup FIX quantity received if items are created when receiving For subscriptions, if items are created when receiving, the quantity received is always 1, not 0. + UI: Show the subscription search form (instead of hidden) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16626&action=edit Bug 5343: Followup: invoicenumber no longer exists, use invoiceid. A previous patch replaces invoicenumber with invoiceid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #21 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- just a functionnal comment : when a vendor is choosen in the subscription, it's not logical if it can be order by another vendor in acquisitions module. So after the search of subsrciption (step 4 in test plan), only the subscription with this vendor or with no vendor should be "Orderable" -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16641&action=edit Bug 5343: It is not possible to add a subscription for another supplier If a supplier is defined for a subscription, you cannot order this subscription to another supplier. If no supplier is defined, you can. FIX: If a cancelled order is linked to a subscription, you can order it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16624|0 |1 is obsolete| | Attachment #16625|0 |1 is obsolete| | Attachment #16626|0 |1 is obsolete| | Attachment #16641|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16723&action=edit Bug 5343: Link serial and acqui modules DB changements: - Adds 2 fields: subscription.reneweddate and aqorders.subscriptionid. - Removes 2 unused fields: aqorders.serialid and aqorders.subscription. Main test plan: 1) Create a subscription 2) Create a bookseller and a basket 3) Add a new order 'from a subscription' 4) Search your subscription and check if results are correct 5) Click on the "order" link 6) Check the biblio information are filled in the form 7) Select a budget and fill some price information. 8) retry steps 3 and 4. Verify you cannot order the same subscription. Message:Outstanding order (only one order per subscription is allowed). 9) click on your subscription (already added) and check you have a new table "Acquisition details" with your price information in the "Ordered amount" line. 10) receive this order 11) On your subscription detail page, the "Spent amount" line must be filled with your price information. 12) Re order the same subscription. Now you are allowed to. Prices information have to be filled with the previous information. 13) Retry some orders and click on a maximum of links in order to find a bug :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16724&action=edit Bug 5343: Followup FIX quantity received if items are created when receiving For subscriptions, if items are created when receiving, the quantity received is always 1, not 0. + UI: Show the subscription search form (instead of hidden) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16725&action=edit Bug 5343: Followup: invoicenumber no longer exists, use invoiceid. A previous patch replaces invoicenumber with invoiceid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16726&action=edit Bug 5343: It is not possible to add a subscription for another supplier If a supplier is defined for a subscription, you cannot order this subscription to another supplier. If no supplier is defined, you can. FIX: If a cancelled order is linked to a subscription, you can order it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16723|0 |1 is obsolete| | Attachment #16724|0 |1 is obsolete| | Attachment #16725|0 |1 is obsolete| | Attachment #16726|0 |1 is obsolete| | --- Comment #27 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16728&action=edit Bug 5343: Link serial and acqui modules (squached) squashed all patches and rebased -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16733&action=edit Bug 5343: Followup: remove useless string on the serials result page -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16735&action=edit Bug 5343: Link serial and acqui modules DB changements: - Adds 2 fields: subscription.reneweddate and aqorders.subscriptionid. - Removes 2 unused fields: aqorders.serialid and aqorders.subscription. Main test plan: 1) Create a subscription 2) Create a bookseller and a basket 3) Add a new order 'from a subscription' 4) Search your subscription and check if results are correct 5) Click on the "order" link 6) Check the biblio information are filled in the form 7) Select a budget and fill some price information. 8) retry steps 3 and 4. Verify you cannot order the same subscription. Message:Outstanding order (only one order per subscription is allowed). 9) click on your subscription (already added) and check you have a new table "Acquisition details" with your price information in the "Ordered amount" line. 10) receive this order 11) On your subscription detail page, the "Spent amount" line must be filled with your price information. 12) Re order the same subscription. Now you are allowed to. Prices information have to be filled with the previous information. 13) Retry some orders and click on a maximum of links in order to find a bug :) Signed-off-by: Leila Arkab <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16736&action=edit Bug 5343: Followup FIX quantity received if items are created when receiving For subscriptions, if items are created when receiving, the quantity received is always 1, not 0. + UI: Show the subscription search form (instead of hidden) Signed-off-by: Leila Arkab <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16737&action=edit Bug 5343: Followup: invoicenumber no longer exists, use invoiceid. A previous patch replaces invoicenumber with invoiceid. Signed-off-by: Leila Arkab <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #32 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16738&action=edit Bug 5343: It is not possible to add a subscription for another supplier If a supplier is defined for a subscription, you cannot order this subscription to another supplier. If no supplier is defined, you can. FIX: If a cancelled order is linked to a subscription, you can order it. Signed-off-by: Leila Arkab <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16739&action=edit Bug 5343: Followup: remove useless string on the serials result page Signed-off-by: Leila Arkab <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16728|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16733|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |koha.aixmarseille@gmail.com --- Comment #34 from Koha Team AMU <koha.aixmarseille@gmail.com> --- Test OK OK on order and on receive. We have the information on cgi-bin/koha/serials/subscription-detail.pl?subscriptionid= -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at this now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- On the subscription search screen I think it would be a little bit better to have the last column empty or saying "Cannot be ordered" (asked Kyle and Brendan :) ) Still testing - can be easily dealt with in a little follow up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16748&action=edit screenshot of subscription search when creating an order from a subscription Attaching a screenshot to illustrate - should also not be a link in this case. Maybe leaving it empty would be easiest. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9896 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #38 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16754&action=edit Bug 5343: Fix non english string Replace "Not orderable" with "Cannot be ordered" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #39 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #36)
On the subscription search screen I think it would be a little bit better to have the last column empty or saying "Cannot be ordered" (asked Kyle and Brendan :) )
"Orderable" smelt quite bad :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have some more little typos: See basket informations See invoice informations = information and fund = Fund - If you don't get to it I can make a little follow up on my own for that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16754|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16762&action=edit Bug 5343: Fix non english string Replace "Not orderable" with "Cannot be ordered" and 3 others typos -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16735|0 |1 is obsolete| | Attachment #16736|0 |1 is obsolete| | Attachment #16737|0 |1 is obsolete| | Attachment #16738|0 |1 is obsolete| | Attachment #16739|0 |1 is obsolete| | Attachment #16762|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16764&action=edit [PASSED QA] Bug 5343: Link serial and acqui modules DB changements: - Adds 2 fields: subscription.reneweddate and aqorders.subscriptionid. - Removes 2 unused fields: aqorders.serialid and aqorders.subscription. Main test plan: 1) Create a subscription 2) Create a bookseller and a basket 3) Add a new order 'from a subscription' 4) Search your subscription and check if results are correct 5) Click on the "order" link 6) Check the biblio information are filled in the form 7) Select a budget and fill some price information. 8) retry steps 3 and 4. Verify you cannot order the same subscription. Message:Outstanding order (only one order per subscription is allowed). 9) click on your subscription (already added) and check you have a new table "Acquisition details" with your price information in the "Ordered amount" line. 10) receive this order 11) On your subscription detail page, the "Spent amount" line must be filled with your price information. 12) Re order the same subscription. Now you are allowed to. Prices information have to be filled with the previous information. 13) Retry some orders and click on a maximum of links in order to find a bug :) Signed-off-by: Leila Arkab <koha.aixmarseille@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Comments on last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16765&action=edit [PASSED QA] Bug 5343: Followup FIX quantity received if items are created when receiving For subscriptions, if items are created when receiving, the quantity received is always 1, not 0. + UI: Show the subscription search form (instead of hidden) Signed-off-by: Leila Arkab <koha.aixmarseille@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16766&action=edit [PASSED QA] Bug 5343: Followup: invoicenumber no longer exists, use invoiceid. A previous patch replaces invoicenumber with invoiceid. Signed-off-by: Leila Arkab <koha.aixmarseille@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16767&action=edit [PASSED QA] Bug 5343: It is not possible to add a subscription for another supplier If a supplier is defined for a subscription, you cannot order this subscription to another supplier. If no supplier is defined, you can. FIX: If a cancelled order is linked to a subscription, you can order it. Signed-off-by: Leila Arkab <koha.aixmarseille@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16768&action=edit [PASSED QA] Bug 5343: Followup: remove useless string on the serials result page Signed-off-by: Leila Arkab <koha.aixmarseille@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16769&action=edit [PASSED QA] Bug 5343: Fix non english string Replace "Not orderable" with "Cannot be ordered" Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16769|0 |1 is obsolete| | --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16770&action=edit [PASSED QA] Bug 5343: Fix non english string Replace "Not orderable" with "Cannot be ordered" and 3 others typos Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Testing notes: - Ordered same subscription multiple times - Tried different settings of AcqCreateItem for a full workflow from order to receive - Undid a receipt and checked correct behaviour - Ordered a book in between, to see item creation and receiving still works. Note for documentation: Acquisition details on the subscription only show the last invoice and the last order. You can of course find all orders/invoices using the acquisition search. Overall very nice much needed functionality! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16769|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9898 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #49 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Because I have received many requests for this feature from both developers and librarians, these patches have been pushed to master prior to the feature freeze. However, there are no unit tests for the new routines, which is bad. Therefore, if no unit tests have been offered have by March 29, I will revert the feature and it can be reviewed for inclusion in the 3.14 release. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 --- Comment #50 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #49)
Because I have received many requests for this feature from both developers and librarians, these patches have been pushed to master prior to the feature freeze. However, there are no unit tests for the new routines, which is bad. Therefore, if no unit tests have been offered have by March 29, I will revert the feature and it can be reviewed for inclusion in the 3.14 release.
Please reports to bug 9937 for UT. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9937 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10145 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org