[Bug 18649] New: Translatability: Get rid of tt directive in translation for admin/categories.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Bug ID: 18649 Summary: Translatability: Get rid of tt directive in translation for admin/categories.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Translation tool shows [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] for en/modules/admin/categories.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: Get rid of |Translatability: Get rid of |tt directive in translation |tt directive in translation |for admin/categories.tt |for admin/categories.tt and | |onboardingstep2.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #1 from Marc Véron <veron@veron.ch> --- Translation tool shows [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] for en/modules/admin/categories.tt and koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 63626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63626&action=edit Bug 18649: Translatability: Get rid of tt directive in translation for admin/categories.tt and onboardingstep2.tt Translation tool shows [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] for en/modules/admin/categories.tt and koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt This patch fixes it. To test: - Apply patch - Verify that code changes make sense - Verify that template directive is no longer picked by translation https://bugs.koha-community.org/show_bug.cgi?id=18641 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63626|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 63724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63724&action=edit Bug 18649: Translatability: Get rid of tt directive in translation for admin/categories.tt and onboardingstep2.tt Translation tool shows [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] for en/modules/admin/categories.tt and koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt This patch fixes it. To test: - Apply patch - Verify that code changes make sense - Verify that template directive is no longer picked by translation https://bugs.koha-community.org/show_bug.cgi?id=18641 Patch works as expected for me - also this is a really great way to do this kind of fix! We should have this all over Koha. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #4 from Marc Véron <veron@veron.ch> --- (In reply to Aleisha Amohia from comment #3) (...)
Patch works as expected for me - also this is a really great way to do this kind of fix! We should have this all over Koha. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Hi Aleisha Thanks for testing and for your comment :-) Some of the translatability issues (not with this bug though) are related to html tags inside of tt directives. I filed an enhancement for that (Bug 18665 - Needs SO). Marc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hi Marc, What is the advantage of value="[%- category.enrolmentperiod IF category.enrolmentperiod -%]" above e.g. value="[% category.enrolmentperiod %]" ? I guess that if period == 0, the first one will leave the field empty? Null and empty string will probably respond the same. Note that the trailing IF does not increase readability. Before making this kind of changes everywhere, is there a consensus to do so? Also noting that you add chomps here (%-). Do we need them here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #6 from Marc Véron <veron@veron.ch> --- (In reply to Marcel de Rooy from comment #5)
Hi Marc,
What is the advantage of value="[%- category.enrolmentperiod IF category.enrolmentperiod -%]" above e.g. value="[% category.enrolmentperiod %]" ? I guess that if period == 0, the first one will leave the field empty? Null and empty string will probably respond the same.
Note that the trailing IF does not increase readability. Before making this kind of changes everywhere, is there a consensus to do so?
Also noting that you add chomps here (%-). Do we need them here?
Hi Marcel - This bug is about translatability, and does not contain a change in behavior. I might be wrong, but the functionality is precisely the same. - At the moment, the translation tool picks the following line for translation: [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] That makes no sense for translators, confuses them, and can lead to errors. Translators should not have to care about code internals. To verify, search for that string for any language on translate.koha-community.org for version 17.05 Or create a translation e.g. for a 'language' aa-AA and then search in aa-AA-staff-prog.po for #. INPUT type=text name=enrolmentperiod #: intranet-tmpl/prog/en/modules/admin/categories.tt:92 #: intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt:104 msgid "" "[% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %]" msgstr "" Then apply patch, translate aa-AA again and verify that the line [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] no longer appears. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 63757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63757&action=edit Bug 18649: [QA followup] Remove chomps in admin/categories.tt As of comment #3, the chomps are not needed because the directive has no surrounding white space that should be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Marc, I understand your explanation, but you did not respond to my question about the trailing IF. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #9 from Marc Véron <veron@veron.ch> --- (In reply to Marcel de Rooy from comment #8)
Marc, I understand your explanation, but you did not respond to my question about the trailing IF.
Ah, sorry, I must have skipped the main part... If you do a translate create for a "language" aa-AA and then examine the file, you find: #. INPUT type=text name=enrolmentperiod #: intranet-tmpl/prog/en/modules/admin/categories.tt:92 #: intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt:104 msgid "" "[% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %]" msgstr "" If you apply the patch and translate create again, these line are gone. The problem occurs because there is more than one tt statement inside a value attribute for a form field: value="[% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %]" If the attribute is changed to have one statement only, the translation tool does not pick it. That's why I changed it to have a trailing IF. And yes, we have a little bit less readability for programmers, but no more disturbing tt directives for translators. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marc Véron from comment #9)
(In reply to Marcel de Rooy from comment #8)
Marc, I understand your explanation, but you did not respond to my question about the trailing IF.
Ah, sorry, I must have skipped the main part...
If you do a translate create for a "language" aa-AA and then examine the file, you find:
#. INPUT type=text name=enrolmentperiod #: intranet-tmpl/prog/en/modules/admin/categories.tt:92 #: intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt:104 msgid "" "[% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %]" msgstr ""
If you apply the patch and translate create again, these line are gone.
The problem occurs because there is more than one tt statement inside a value attribute for a form field: value="[% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %]"
If the attribute is changed to have one statement only, the translation tool does not pick it. That's why I changed it to have a trailing IF.
And yes, we have a little bit less readability for programmers, but no more disturbing tt directives for translators.
Sure :) But why not just [% category.enrolmentperiod %] ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #11 from Marc Véron <veron@veron.ch> --- Oh... Hmm... That's true for the original line as well... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 63937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63937&action=edit Bug 18649: [QA followup] Simplify If and remove chomps in admin/categories.tt As of comment #3, the chomps are not needed because the directive has no surrounding white space that should be removed. As of comment #10, the IF statement can be implified (Amended 2017-06-02 mv) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63757|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63724|0 |1 is obsolete| | Attachment #63937|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64049&action=edit Bug 18649: Translatability: Get rid of tt directive in translation for admin/categories.tt and onboardingstep2.tt Translation tool shows [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] for en/modules/admin/categories.tt and koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt This patch fixes it. To test: - Apply patch - Verify that code changes make sense - Verify that template directive is no longer picked by translation https://bugs.koha-community.org/show_bug.cgi?id=18641 Patch works as expected for me - also this is a really great way to do this kind of fix! We should have this all over Koha. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Applied the second patch to the first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is a change in the behaviour: Before the patch, if the enrolment period == 0, the input was empty, now it shows '0'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #16 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #15)
There is a change in the behaviour: Before the patch, if the enrolment period == 0, the input was empty, now it shows '0'.
Ah, that was the reason for the IF I removed as QA follow-up as indicated in comment #10 So the good patch would be the one signed off bei Aleisha: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63724 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #15)
There is a change in the behaviour: Before the patch, if the enrolment period == 0, the input was empty, now it shows '0'.
I know. But did not find enough reason for a change. 0 == 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #18 from Marc Véron <veron@veron.ch> --- Created attachment 64079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64079&action=edit Bug 18649: (Restored earlier version) Translatability: Get rid of tt directive in translation for admin/categories.tt and onboardingstep2.tt Restored earlier version (patches #63724 + #63757) to get the old behaviour, see comment #15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64049|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from Marc Véron <veron@veron.ch> --- Resetting to NSO because restored patch lost SO line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sounds like there is something wrong with the "0", but if it's a bug we must fix it somewhere else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #21 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #20)
Sounds like there is something wrong with the "0", but if it's a bug we must fix it somewhere else.
I do not think that there is anything wrong with enrolmentperiod = 0, it is simply not displayed if it is 0. That's the original behaviour, this patch does not change it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It is wrong to store 0 and it is wrong to display an empty string when 0 is stored. I did not say your last patch modified that, just that it should not be changed here. I was more answering to Marcel than commenting your patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #23 from Marc Véron <veron@veron.ch> --- Where do we go from here? - The original aim of this bug is not to expose the tt directive to translators (without changing the original behaviour). It is kind of string patch. - Can we agree to let this patch do what it does and move the 0-discussion to a new bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I would opt for pushing the two patches as they were in PQA. Not allowing the zero should be solved on another report. Showing the zero here is fine with me. No need to put this in NSO again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #25 from Marc Véron <veron@veron.ch> --- (In reply to Marcel de Rooy from comment #24)
I would opt for pushing the two patches as they were in PQA. Not allowing the zero should be solved on another report. Showing the zero here is fine with me. No need to put this in NSO again.
What is the next step? BTW: Still applies on current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I will look at this one tomorrow during QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #26)
I will look at this one tomorrow during QA.
Sorry, it became manana (issue with issues). Still on my list now ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> ---
From an earlier comment: Note that the trailing IF does not increase readability. I am not in favor of the original patch.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #29 from Marc Véron <veron@veron.ch> --- (In reply to Marcel de Rooy from comment #28)
From an earlier comment: Note that the trailing IF does not increase readability. I am not in favor of the original patch.
OK, I will rewrite it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64079|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #30 from Marc Véron <veron@veron.ch> --- Created attachment 65494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65494&action=edit Bug 18649: (New patch) Translatability: Get rid of tt directive in translation for admin/categories.tt and onboardingstep2.tt New patch without trailing IF construction in tt directives as requested in comment #28 To test: Verify that translation tool no longer shows tt directives as described in comment #1 New patch, needs SO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65494|0 |1 is obsolete| | --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 65495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65495&action=edit [SIGNED-OFF] Bug 18649: (New patch) Translatability: Get rid of tt directive in translation for admin/categories.tt and onboardingstep2.tt New patch without trailing IF construction in tt directives as requested in comment #28 To test: Verify that translation tool no longer shows tt directives as described in comment #1 New patch, needs SO. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65495|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65501&action=edit Bug 18649: (New patch) Translatability: Get rid of tt directive in translation for admin/categories.tt and onboardingstep2.tt New patch without trailing IF construction in tt directives as requested in comment #28 To test: Verify that translation tool no longer shows tt directives as described in comment #1 New patch, needs SO. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marc Véron from comment #29)
(In reply to Marcel de Rooy from comment #28)
From an earlier comment: Note that the trailing IF does not increase readability. I am not in favor of the original patch.
OK, I will rewrite it.
Thx -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #35 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Onboarding is not in 16.11.x, so patch didn't apply cleanly. I've fixed the conflict. This patch has been pushed to 16.11.x and will be in 16.11.12. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #37 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.17 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org