[Bug 18652] New: Get rid of tt directive in translation for uncertainprice.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Bug ID: 18652 Summary: Get rid of tt directive in translation for uncertainprice.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 63639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63639&action=edit Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63639|0 |1 is obsolete| | --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 63772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63772&action=edit Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before Followed test plan and patch worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63772|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 63931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63931&action=edit Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before Followed test plan and patch worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de Status|Passed QA |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am not sure this patch is correct, and a chat with cait did not satisfy my feeling See the following for fr-FR (I searched for 'scriptname') Before bug 18652: 10158 #. META http-equiv=Refresh 10159 #: intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt:41 10160 msgid "0; url=[% scriptname %]?booksellerid=[% booksellerid %]" 10161 msgstr "0; url=[% scriptname %]?booksellerid=[% booksellerid %]" After bug 18652 and translate update: 1090 #. %1$s: INCLUDE 'acquisitions-toolbar.inc'. 1091 #. %2$s: IF ( validate ). 1092 #. %3$s: BLOCK metacontent. 1093 #. %4$s: scriptname. 1094 #. %5$s: booksellerid. 1095 #. %6$s: END. 1096 #: intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt:37 1097 #, fuzzy, c-format 1098 msgid "%s %s %s0; url=%s?booksellerid=%s%s " 1099 msgstr "%s %s %s %s (fermé) %s " That looks worst. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63931|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 64141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64141&action=edit Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before Followed test plan and patch worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended to switch from BLOCK to a template variable, see comment #5 Additional test (for a langunage 'aa-AA') perl translate create aa-AA verify that line 41 no longer appears in aa-AA-staff-prog.po -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Marc Véron <veron@veron.ch> --- Not sure where to set status now - setting it to SO Please set it to NSO if an other Sign off is needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The patch has been rewritten, Signed-off-by lines should not be kept. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64141|0 |1 is obsolete| | --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 64151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64151&action=edit Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before - Additional test (for a langunage 'aa-AA') perl translate create aa-AA verify that line 41 no longer appears in aa-AA-staff-prog.po Amended to switch from BLOCK to a template variable, see comment #5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Get rid of tt directive in |TRanslatability: Get rid of |translation for |tt directive in translation |uncertainprice.tt |for uncertainprice.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|TRanslatability: Get rid of |Translatability: Get rid of |tt directive in translation |tt directive in translation |for uncertainprice.tt |for uncertainprice.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 --- Comment #9 from Marc Véron <veron@veron.ch> --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 65399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65399&action=edit [SIGNED-OFF] Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before - Additional test (for a langunage 'aa-AA') perl translate create aa-AA verify that line 41 no longer appears in aa-AA-staff-prog.po Amended to switch from BLOCK to a template variable, see comment #5 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64151|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65399|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66641&action=edit Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before - Additional test (for a langunage 'aa-AA') perl translate create aa-AA verify that line 41 no longer appears in aa-AA-staff-prog.po Amended to switch from BLOCK to a template variable, see comment #5 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.04. Nice work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.12. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #15 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.17 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org