[Bug 8063] New: Hold print notices do not sort by branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Priority: P5 - low Change sponsored?: --- Bug ID: 8063 Assignee: gmcharlt@gmail.com Summary: Hold print notices do not sort by branch Severity: major Classification: Unclassified OS: All Reporter: joy@bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Command-line Utilities Product: Koha The gather_print_notices.pl cronjob for printing hold notices mails all notices as one file and does not separate out the notices by branch. For libraries with multiple branches this results in large files being received by individual branches that need to be read/sorted/printed or ignored. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5544 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9489&action=edit Bug 8063 - Hold print notices do not sort by branch Adds the option -s/--split to enable notices to be separated into different files by borrower home library. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9489|0 |1 is obsolete| | --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 9514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9514&action=edit [SIGNED-OFF] Bug 8063 - Hold print notices do not sort by branch Works as expected. Signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA comments: * a lot of code cleaning that make the visibility of the real changes hard to spot ! * perlcritic is failing. Before the patch there is one error, after the patch there are 2: Bareword file handle opened at line 82, column 9. See pages 202,204 of PBP. (Severity: 5) Bareword file handle opened at line 107, column 5. See pages 202,204 of PBP. (Severity: 5) * tiny SQL comment: + LEFT JOIN borrowers b on b.borrowernumber = mq.borrowernumber should be written with UC for on: + LEFT JOIN borrowers b ON b.borrowernumber = mq.borrowernumber (could also be written + LEFT JOIN borrowers b USING(borrowernumber) ) Please fix both (they are the same error) and resubmit. If you submit a follow-up, directly switch to signed-off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9514|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9696&action=edit Bug 8063 - Hold print notices do not sort by branch Adds the option -s/--split to enable notices to be separated into different files by borrower home library. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 --- Comment #5 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9697&action=edit Bug 8063 - Followup - Make C4/Letters.pm conform to PBP Perlcritic reported the following errors: Subroutine prototypes used at line 96, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 120, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 152, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 173, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 190, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 227, column 1. See page 194 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 228, column 31. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 229, column 31. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 236, column 9. See page 199 of PBP. (Severity: 5) Subroutine prototypes used at line 668, column 1. See page 194 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 669, column 27. See page 199 of PBP. (Severity: 5) Subroutine prototypes used at line 719, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 865, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 899, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 981, column 1. See page 194 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 982, column 28. See page 199 of PBP. (Severity: 5) Subroutine prototypes used at line 1000, column 1. See page 194 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 1001, column 27. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 1004, column 9. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 --- Comment #6 from Kyle M Hall <kyle.m.hall@gmail.com> --- I do apologize for the code cleanup blocking the visibility of changes. I figured this was a good file to tidy as it is rarely modified so the likelihood of the cleaning breaking another patch is extremely low. If I continue this practice, I will submit a the cleanup as a separate followup patch. I had not know that we should be updating code to conform to PBP, but it's a very good idea. In that spirit, I have submitted a followup to conform C4/Letters.pm to PBP. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9696|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 9912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9912&action=edit [SIGNED-OFF] Bug 8063 - Hold print notices do not sort by branch Still works ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9697|0 |1 is obsolete| | --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 9913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9913&action=edit [SIGNED-OFF] Bug 8063 - Followup - Make C4/Letters.pm conform to PBP I don't understand why making things explicit is a high severity violation of best practices... but the patch is ok and perlcritic doesn't complain anymore. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #9 from Ian Walls <koha.sekjal@gmail.com> --- First patch: Moves some code around, as well as adding a new loop and hash for splitting by branchcode. Marking Passed QA. Second patch: Just PBP cleanup, safe and sane, passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- mmm... Kyle/Julian, When trying to run this script I gat a nasty: 15:42 ~/koha.dev/koha-community (new/bug_8063 $%)$ ./misc/cronjobs/gather_print_notices.pl Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 81. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 95. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 102. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 106. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 120. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 127. Execution of ./misc/cronjobs/gather_print_notices.pl aborted due to compilation errors. WTF ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com Severity|major |enhancement --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- changing severity, it's an ENH, as well as assignee -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 --- Comment #12 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9953&action=edit Bug 8063 - Followup - Bug fix $OUTPUT being used but not being declared. When trying to run this script I gat a nasty: 15:42 ~/koha.dev/koha-community (new/bug_8063 $%)$ ./misc/cronjobs/gather_print_notices.pl Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 81. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 95. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 102. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 106. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 120. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 127. Execution of ./misc/cronjobs/gather_print_notices.pl aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9953|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10786&action=edit Bug 8063 - [SIGNED-OFF] Followup - Bug fix $OUTPUT being used but not being declared. When trying to run this script I gat a nasty: 15:42 ~/koha.dev/koha-community (new/bug_8063 $%)$ ./misc/cronjobs/gather_print_notices.pl Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 81. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 95. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 102. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 106. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 120. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 127. Execution of ./misc/cronjobs/gather_print_notices.pl aborted due to compilation errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Before the patch: $perl -wc ./misc/cronjobs/gather_print_notices.pl Global symbol "$OUTPUT" requires explicit package name at [...]./misc/cronjobs/gather_print_notices.pl line 81. ./misc/cronjobs/gather_print_notices.pl had compilation errors. With this patch: $perl -wc ./misc/cronjobs/gather_print_notices.pl ./misc/cronjobs/gather_print_notices.pl syntax OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Only the last patch is waiting for QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: No more comments, passed QA ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 QA Contact| |paul.poulain@biblibre.com --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> --- Tested before pushing: * UPDATE message_queue SET status='pending' WHERE status=sent AND message_transport_type='print'; to set some message to pending status * run misc/cronjobs/gather_print_notices.pl tmp => VERIFIED that the print is in tmp/holdnotices-2012-07-16.html, and contains notices * UPDATE message_queue SET status='pending' WHERE status=sent AND message_transport_type='print'; to set some message to pending status * run misc/cronjobs/gather_print_notices.pl -s tmp => VERIFIED that the print is in tmp/holdnotices-2012-07-16-MAURES.html (MAURES being my branchcode), and contains notices -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org