http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA comments: * a lot of code cleaning that make the visibility of the real changes hard to spot ! * perlcritic is failing. Before the patch there is one error, after the patch there are 2: Bareword file handle opened at line 82, column 9. See pages 202,204 of PBP. (Severity: 5) Bareword file handle opened at line 107, column 5. See pages 202,204 of PBP. (Severity: 5) * tiny SQL comment: + LEFT JOIN borrowers b on b.borrowernumber = mq.borrowernumber should be written with UC for on: + LEFT JOIN borrowers b ON b.borrowernumber = mq.borrowernumber (could also be written + LEFT JOIN borrowers b USING(borrowernumber) ) Please fix both (they are the same error) and resubmit. If you submit a follow-up, directly switch to signed-off -- You are receiving this mail because: You are watching all bug changes.