https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77547&action=edit Bug 21173 - Customize age unit and starting point for automatic item modification by age tool and cronjob. This allows librarians to define either the item creation date or items last altered timestamp as the starting point for the age of the item so the autmatic_item_modification_by_age.pl can alter item statuses for example for items which have been in the catalogue for a while. A use case for this functionality is: * When an items shelving location changes from 'In processing' to 'Shelving trolley' after 1 hour the status 'Shelving trolley' is removed for the item. The unit 'Hours' can now be set (extending the functionality of this cronjob from just calculating item age in days) and the age starting point of 'Last altered' can be defined so existing items in the catalogue like this example item will be altered by the cronjob. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I understand this is an enh to the tool, that might be generally helfpul. But was wondering because of the given use case, if misc / cronjobs / cart_to_shelf.pl would not already work here? For the cart using the existing feature seems nice, because it will allow you to use location for other things as well, switching back from cart to a permanent_location. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77548|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Katrin Your right that with the use case outlined by Toi Ohomai they could indeed simply use the misc/cronjobs/cart_to_shelf.pl however that would require them to either ask a member of IT staff or their Koha support vendor to add/modify the number of hours since item last modified. Whereas this enhancement allows librarians to have control over this and provides scope for library staff to not just change item.location based on the number of hours since the item was modified but also many other conditions and substitutions are available to them. i.e. this gives librarians more control and lets them set many values other than items.location based on the number of hours or days since the item was last altered. What are your thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Katrin Thanks for bringing the other inbuilt cart feature to my attention as I wasn't previously aware of it before writing this enhancement. I have just rebased the commits down to a single commit. I just have to obsolete the commit I just added as I noticed a template typo then it should be pretty close to being ready for being set to 'Needs signoff'. This commit and several others I have/am writing at the moment are for Toi Ohomai who you may have seen in the July community newsletter that they have recently gone live with Koha :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77605&action=edit Bug 21173 - Customize age unit and starting point for automatic item modification by age tool and cronjob. This allows librarians to define either the item creation date or items last altered timestamp as the starting point for the age of the item so the autmatic_item_modification_by_age.pl can alter item fields for example for items which have been in the catalogue for a while. A use case for this functionality is: * When an items shelving location changes from 'In processing' to 'Shelving trolley' after 1 hour the status 'Shelving trolley' is removed for the item. The unit 'Hours' can now be set (extending the functionality of this cronjob from just calculating item age in days) and the age starting point of 'Last altered' can be defined so existing items in the catalogue like this example item will be altered by the cronjob. Test plan: 1. Go to Tools->Automatic item modifications by age and create a new rule by selecting the 'Edit rules' button 2. Notice you can only set the age in the unit of days not hours. Also alsthough not visible in the interface the rule will calculate the age of the item based on when it was created (i.e. added to Koha). 3. Apply patch and run ./updatedatabase.pl in the koha-shell 4. Now revisit Tools->Automatic item modifications by age. Notice the table of existing rules now contains a new column 'Age starting point' this is the date from which the item age is calculated. This enhancement offers you two options as the age starting point: Created (displayed in this table as 'itemcreated') or Last altered (displayed in this table as 'itemaltered'). 5. Click 'Edit rules' to create a new rule. Notice in the form for creating the new rule you can set the unit to either 'Hours' or 'Days'. When you select 'Days' then the Age starting point selection will appear where you can specify if you want the rule to work on the number of days since the item was last altered or number of days since the item was created. NOTE: If you select 'Hours' as the unit type when creating a new rule then the Age starting point selection area is hidden. This is because the item creation value is saved in the database as a date not a datetime. Therefore we cannot calculate the number of hours since the item was created in the Koha catalog. Therefore if the unit is set to 'Hours' then by default the item will use the item last altered value (stored as a date time) as the age starting point. For existing rules if they have the unit set to 'Hours' then the Age starting point area is hidden by default when the page loads. 6. In the new rule set the following values: Age: 1, Unit: Hours, condition items.location = 'CART', items.location = '' 7. Now save the rule and confirm the correct values are dispayed in the rules table which is loaded 8. Click 'Edit rules' button again. 9. Modify the rule you just created changing Age to 2 and create another new rule with the following values: Age='1', Unit='Days', 'Age starting point'='Created', Condition 'items.homebranch'='<a branchcode of a branch in your Koha instance>', substituions 'items.homebranch'='<another branchcode in your Koha instance>' 10. Now click 'Save' and confirm the data displayed for both rules is correct. 11. In the database manually set the location field of two items to 'CART' and set their timestamp value to 2 hours before the current time 12. Exit out of the database terminal and manually run the automatic_item_modification_by_age.pl cronjob from the koha-shell with this command: ./automatic_item_modification_by_age.pl --confirm 13. Now return to the database and notice the two items you set have a location of 'CART' now have a blank location field because the manually run cronjob altered them as they meet the conditions of the rule. 14. Repeat step 11 and enter this text into your /etc/cron.d/koha-common file: */2 * * * * root koha-foreach --enabled /usr/share/koha/bin/cronjobs/automatic_item_modification_by_age.pl --confirm This will make the cronjob run every 2 minutes. 15. Now restart koha-common with this command: sudo /etc/init.d/koha-common restart 16. Now wait for more than 2 minutes and check the database again and notice that the two items have blank location fields as the automatically running cronjob altered the items. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21249 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20678 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Rebased against master on 16th of sept 2018. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 79914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79914&action=edit Bug 21173: Fixed rebase removal of filters and changed items.dateaccessioned to datetime datatype This means we can make the auto item modification tool work for hours since item was created Updated test plan: 1. Go to Tools->Automatic item modifications by age and create a new rule by selecting the 'Edit rules' button 2. Notice you can only set the age in the unit of days not hours. Also although not visible in the interface the rule will calculate the age of the item based on when it was created (i.e. added to Koha). 3. Apply patch and run ./updatedatabase.pl in the koha-shell 4. Now revisit Tools->Automatic item modifications by age. Notice the table of existing rules now contains a new column 'Age starting point' this is the date from which the item age is calculated. This enhancement offers you two options as the age starting point: Created (displayed in this table as 'itemcreated') or Last altered (displayed in this table as 'itemaltered'). 5. Click 'Edit rules' to create a new rule. Notice in the form for creating the new rule you can set the unit to either 'Hours' or 'Days'. 6. In the new rule set the following values: Age: 1, Unit: Hours, condition items.location = 'CART', items.location = '' 7. Now save the rule and confirm the correct values are dispayed in the rules table which is loaded 8. Click 'Edit rules' button again. 9. Modify the rule you just created changing Age to 2 and create another new rule with the following values: Age='1', Unit='Hour', 'Age starting point'='Created', Condition 'items.homebranch'='<a branchcode of a branch in your Koha instance>', substituions 'items.homebranch'='<another branchcode in your Koha instance>' 10. Now click 'Save' and confirm the data displayed for both rules is correct. 11. Create two new items and set their location field to 'CART'. Then in the database set their dateaccessioned value to 2 hours before the current time 12. Exit out of the database terminal and manually run the automatic_item_modification_by_age.pl cronjob from the koha-shell with this command: ./automatic_item_modification_by_age.pl --confirm 13. Now return to the database and notice the two items you set have a location of 'CART' now have a blank location field because the manually run cronjob altered them as they meet the conditions of the rule. 14. Repeat step 11 but this time change the rule in the Auto item modification tool interface to 'Age starting point='Altered'' so we can test the auto item mod tool on items that have been last altered more than 2 hours ago. 15. Enter this text into your /etc/cron.d/koha-common file: */2 * * * * root koha-foreach --enabled /usr/share/koha/bin/cronjobs/automatic_item_modification_by_age.pl --confirm This will make the cronjob run every 2 minutes. 16. Now restart koha-common with this command: sudo /etc/init.d/koha-common restart 17. Now wait for more than 2 minutes and check the database again and notice that the two items have blank location fields as the automatically running cronjob altered the items. 18. Repeat steps 9-17 with the new rules in the auto item modification tool for the following rule conditions: New rule: Age: 2 Age starting point: Created Units: Days Condition 'items.homebranch'='<a branchcode of a branch in your Koha instance>', Substitutions 'items.homebranch'='<another branchcode in your Koha instance>' New rule: Age: 2 Age starting point: Altered Units: Days Condition 'items.homebranch'='<a branchcode of a branch in your Koha instance>', Substitutions 'items.homebranch'='<another branchcode in your Koha instance>' Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

Bug 21173: Fixed rebase removal of filters and changed items.dateaccessioned to >datetime datatype

I am worried by this change. We have a lot of libraries who set the date manually in items, typing it in like: 2010-01-01. It will auto-fill, but for retro-cataloguing they want it to reflect the real date. Maybe it would be better to introduce a completely new column created_on with an automatic timestamp? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The more I think about it, the more I think this change would likely have many unwanted side effects: - dateaccesioned is indexed in Zebra and used in several spots like in the labels module for finding new items - Acq also sets it at some point as a date. - The value builder/catalouging plugin linked to the field uses a date - Used in hardcoded reports - ... (git grep dateaccessioned :) ) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78917|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #19 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 138870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138870&action=edit Bug 21173: Template and JavaScript changes Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #21 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 138872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138872&action=edit Bug 21173: Unit tests Test plan: 1. sudo koha-shell kohadev 2. prove t/db_dependent/Items/AutomaticItemModificationByAge.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138872|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138870|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #24 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 138895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138895&action=edit Bug 21173: Add Hours as an age unit to auto item modifications by age items.damaged_on, items.itemlost_on, and items.withdrawn_on are datetime fields, so it could be useful to configure rules based on the number of hours since these values. All other fields in the automatic item modifications by age tool will use the days unit. Test plan: 1. Go to Tools->Automatic item modifications by age 2. Create a new rule 3. Apply patches and restart services 4. Confirm the rule you created has an 'Age unit' displayed of 'Days' 5. Edit the existing rule. Notice if your 'Age field' is not set to items.damaged_on, items.itemlost_on or items.withdrawn_on then the 'Age unit' dropdown is disabled 6. Confirm if you try to save a rule with age unit = 'Hours' and a field other than items.damaged_on, items.itemlost_on, or items.withdrawn_on then the 'List of rules' table shows that rule with the unit of 'Days' 7. Click 'Add rule'. Observe the 'Age unit' dropdown is initially disabled and set to 'Days' until you change the 'Age field' dropdown to items.damaged_on, items.itemlost_on, or items.withdrawn_on 8. Save the rule: Age: 1 Age unit: Hours Age field: items.itemlost_on Conditions: items.barcode = TEST Substitutions: items.barcode = TEST1 9. Find an item. Set it's barcode to TEST. In the database change it's items.itemlost_on to more than 1 hour ago 10. Restart services 11. Run the automatic_item_modification_by_age.pl script: sudo koha-shell kohadev ./misc/cronjobs/automatic_item_modification_by_age.pl -c 12. Confirm the item's barcode has changed to TEST1 Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|If you create rules in the |You can now define rules released in|'Automatic item |with the age unit of |modification by age' tool |'Hours' or 'Days' for the |on the age field(s) |fields items.damaged_on, |'items.damaged_on, |items.itemlost_on, or |items.itemlost_on, or |items.withdrawn_on in the |items.withdrawn_on' you can |'Automatic item |now define an age unit of |modification by age' tool. |'Hours', not just 'Days'. | | |This means you can now |This means you can now |automatically modify items |automatically modify items |based on the number of |based on the number of |hours since they were |hours since they were |marked damaged, lost, or |marked damaged, lost, or |withdrawn. |withdrawn. | | |You may need to |You will need |ask your system |to ask your system |administrator to configure |administrator to configure |the |the |automatic_item_modification |automatic_item_modification |_by_age.pl cronjob to run |_by_age.pl cronjob to run |more than once a day if you |more than once a day if you |create rules with the age |create rules with the age |unit of 'Hours'. |unit of 'Hours'. | --- Comment #26 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Removed unused JS variable and warn and re-attached patchset. Ready for testing again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138895|0 |1 is obsolete| | --- Comment #29 from David Nind <david@davidnind.com> --- Created attachment 156138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156138&action=edit Bug 21173: Add Hours as an age unit to auto item modifications by age items.damaged_on, items.itemlost_on, and items.withdrawn_on are datetime fields, so it could be useful to configure rules based on the number of hours since these values. All other fields in the automatic item modifications by age tool will use the days unit. Test plan: 1. Go to Tools->Automatic item modifications by age 2. Create a new rule 3. Apply patches and restart services 4. Confirm the rule you created has an 'Age unit' displayed of 'Days' 5. Edit the existing rule. Notice if your 'Age field' is not set to items.damaged_on, items.itemlost_on or items.withdrawn_on then the 'Age unit' dropdown is disabled 6. Confirm if you try to save a rule with age unit = 'Hours' and a field other than items.damaged_on, items.itemlost_on, or items.withdrawn_on then the 'List of rules' table shows that rule with the unit of 'Days' 7. Click 'Add rule'. Observe the 'Age unit' dropdown is initially disabled and set to 'Days' until you change the 'Age field' dropdown to items.damaged_on, items.itemlost_on, or items.withdrawn_on 8. Save the rule: Age: 1 Age unit: Hours Age field: items.itemlost_on Conditions: items.barcode = TEST Substitutions: items.barcode = TEST1 9. Find an item. Set it's barcode to TEST. In the database change it's items.itemlost_on to more than 1 hour ago 10. Restart services 11. Run the automatic_item_modification_by_age.pl script: sudo koha-shell kohadev ./misc/cronjobs/automatic_item_modification_by_age.pl -c 12. Confirm the item's barcode has changed to TEST1 Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Summary|Add Hours as an age unit to |Add hours as age unit to |auto item modifications by |auto item modifications by |age for the |age for damaged_on, |items.damaged_on, |itemlost_on and |items.itemlost_on and |withdrawn_on fields |items.withdrawn_on age | |fields | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #32 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi (In reply to Katrin Fischer from comment #31)

1) Needs a bit of perltidy. 2) The GUI is a little confusing. What happens:

* When the form is shown the first time, the 'Hours' value is selected * Switch the field to items.withdrawn_on and it changes to "Choose an age unit" * Switch the field back to "items.dateaccessioned" * The drop down still shows "Choose an age unit", but can no longer be changed.

Suggested behavior:

* When the form is shown the first time, the 'Hours' value is selected * Switch the field to items.withdrawn_on the field unlocks and is now editable * Switch to "Hours" * Switch the field back to "items.dateaccessioned", the field locks with "Hours" set

Alternatively we could also only show the units pull down if one of the 3 fields where it applies is picked?

Hi Katrin, Thank you for doing QA. I will work through each of your points and fix up this enhancement :) Alex -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #34 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 158574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158574&action=edit Bug 21173: (follow-up) Perltidy Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #36 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Thanks Katrin and Owen! Great suggestions, I am just trying them out in those follow-ups. This isn't ready to testing yet, I'll change the status when it is :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Phan Tung Bui <phan-tung.bui@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phan-tung.bui@inlibro.com --- Comment #38 from Phan Tung Bui <phan-tung.bui@inlibro.com> --- Please update the test plan to reflect the current location of the 'Automatic Item Modifications by Age' feature. It is no longer found under 'Tools' but has been moved to 'Cataloging'. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158575|0 |1 is obsolete| | --- Comment #39 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 160715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160715&action=edit Bug 21173: (follow-up) Re-ordering input fields in item modification by age form Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: matthias le gac <matthias@babel.inlibro.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #41 from Phan Tung Bui <phan-tung.bui@inlibro.com> --- Note: To avoid confusion, when selecting a rule other than 'items.damaged_on', 'items.itemlost_on', or 'items.withdrawn_on', the option 'Hours' should be disabled since these specific fields are associated with the 'Days' unit. Enabling 'Hours' for other fields may lead to misinterpretation of the rule's intended behavior. Disabling 'Hours' ensures consistency in the presentation of rules and helps users make accurate selections. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156137|0 |1 is obsolete| | Attachment #156138|0 |1 is obsolete| | Attachment #156139|0 |1 is obsolete| | Attachment #158574|0 |1 is obsolete| | Attachment #160716|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #44 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Created attachment 203681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203681&action=edit Bug 21173: Add Hours as an age unit to auto item modifications by age items.damaged_on, items.itemlost_on, and items.withdrawn_on are datetime fields, so it could be useful to configure rules based on the number of hours since these values. All other fields in the automatic item modifications by age tool will use the days unit. Test plan: 1. Go to Tools->Automatic item modifications by age 2. Create a new rule 3. Apply patches and restart services 4. Confirm the rule you created has an 'Age unit' displayed of 'Days' 5. Edit the existing rule. Notice if your 'Age field' is not set to items.damaged_on, items.itemlost_on or items.withdrawn_on then the 'Age unit' dropdown is disabled 6. Confirm if you try to save a rule with age unit = 'Hours' and a field other than items.damaged_on, items.itemlost_on, or items.withdrawn_on then the 'List of rules' table shows that rule with the unit of 'Days' 7. Click 'Add rule'. Observe the 'Age unit' dropdown is initially disabled and set to 'Days' until you change the 'Age field' dropdown to items.damaged_on, items.itemlost_on, or items.withdrawn_on 8. Save the rule: Age: 1 Age unit: Hours Age field: items.itemlost_on Conditions: items.barcode = TEST Substitutions: items.barcode = TEST1 9. Find an item. Set it's barcode to TEST. In the database change it's items.itemlost_on to more than 1 hour ago 10. Restart services 11. Run the automatic_item_modification_by_age.pl script: sudo koha-shell kohadev ./misc/cronjobs/automatic_item_modification_by_age.pl -c 12. Confirm the item's barcode has changed to TEST1 Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #46 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Created attachment 203683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203683&action=edit Bug 21173: (follow-up) Perltidy Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203680|0 |1 is obsolete| | Attachment #203681|0 |1 is obsolete| | Attachment #203682|0 |1 is obsolete| | Attachment #203683|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #49 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Created attachment 203695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203695&action=edit Bug 21173: Add Hours as an age unit to auto item modifications by age items.damaged_on, items.itemlost_on, and items.withdrawn_on are datetime fields, so it could be useful to configure rules based on the number of hours since these values. All other fields in the automatic item modifications by age tool will use the days unit. Test plan: 1. Go to Cataloging->Automation->Item modifications by age 2. Create a new rule 3. Apply patches and restart services 4. Confirm the rule you created has an 'Age unit' displayed of 'Days' 5. Edit the existing rule. Notice if your 'Age field' is not set to items.damaged_on, items.itemlost_on or items.withdrawn_on then the 'Age unit' dropdown is disabled 6. Confirm if you try to save a rule with age unit = 'Hours' and a field other than items.damaged_on, items.itemlost_on, or items.withdrawn_on then the 'List of rules' table shows that rule with the unit of 'Days' 7. Click 'Add rule'. Observe the 'Age unit' dropdown is initially disabled and set to 'Days' until you change the 'Age field' dropdown to items.damaged_on, items.itemlost_on, or items.withdrawn_on 8. Save the rule: Age: 1 Age unit: Hours Age field: items.itemlost_on Conditions: items.barcode = TEST Substitutions: items.barcode = TEST1 9. Find an item. Set it's barcode to TEST. In the database change it's items.itemlost_on to more than 1 hour ago 10. Restart services 11. Run the automatic_item_modification_by_age.pl script: sudo koha-shell kohadev ./misc/cronjobs/automatic_item_modification_by_age.pl -c 12. Confirm the item's barcode has changed to TEST1 Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #51 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Created attachment 203697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203697&action=edit Bug 21173: (follow-up) Perltidy Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203697|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #53 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 203829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203829&action=edit Bug 21173: (follow-up) Fix tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203694|0 |1 is obsolete| | Attachment #203695|0 |1 is obsolete| | Attachment #203696|0 |1 is obsolete| | Attachment #203828|0 |1 is obsolete| | Attachment #203829|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #55 from David Nind <david@davidnind.com> --- Created attachment 204527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204527&action=edit Bug 21173: Add Hours as an age unit to auto item modifications by age items.damaged_on, items.itemlost_on, and items.withdrawn_on are datetime fields, so it could be useful to configure rules based on the number of hours since these values. All other fields in the automatic item modifications by age tool will use the days unit. Test plan: 1. Go to Cataloging->Automation->Item modifications by age 2. Create a new rule 3. Apply patches and restart services 4. Confirm the rule you created has an 'Age unit' displayed of 'Days' 5. Edit the existing rule. Notice if your 'Age field' is not set to items.damaged_on, items.itemlost_on or items.withdrawn_on then the 'Age unit' dropdown is disabled 6. Confirm if you try to save a rule with age unit = 'Hours' and a field other than items.damaged_on, items.itemlost_on, or items.withdrawn_on then the 'List of rules' table shows that rule with the unit of 'Days' 7. Click 'Add rule'. Observe the 'Age unit' dropdown is initially disabled and set to 'Days' until you change the 'Age field' dropdown to items.damaged_on, items.itemlost_on, or items.withdrawn_on 8. Save the rule: Age: 1 Age unit: Hours Age field: items.itemlost_on Conditions: items.barcode = TEST Substitutions: items.barcode = TEST1 9. Find an item. Set it's barcode to TEST. In the database change it's items.itemlost_on to more than 1 hour ago 10. Restart services 11. Run the automatic_item_modification_by_age.pl script: sudo koha-shell kohadev ./misc/cronjobs/automatic_item_modification_by_age.pl -c 12. Confirm the item's barcode has changed to TEST1 Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #57 from David Nind <david@davidnind.com> --- Created attachment 204529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204529&action=edit Bug 21173: (follow-up) Perltidy Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #59 from David Nind <david@davidnind.com> --- Created attachment 204531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204531&action=edit Bug 21173: (follow-up) Update age unit field hint text Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.