https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23612 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92818&action=edit Bug 23612: If no columns in a table can be toggled, don't show columns button This patch makes a change to the JavaScript setup for DataTables button controls so that if there are no toggle-able buttons (or there is no columns configuration at all) the column selection menu button will not appear. To test, apply the patch and go to Administration -> Columns settings. - In the Administration section, find the section for the "libraries" table. - In the "Cannot be toggled" column, check all the checkboxes. - Save. - Go to Administration -> Libraries. - At the top of the table there should be no "Columns" button, only "Clear filter" and "Export" buttons. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23612 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92818|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 92865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92865&action=edit Works well with all DataTables I tested. Bug 23612: If no columns in a table can be toggled, don't show columns button This patch makes a change to the JavaScript setup for DataTables button controls so that if there are no toggle-able buttons (or there is no columns configuration at all) the column selection menu button will not appear. To test, apply the patch and go to Administration -> Columns settings. - In the Administration section, find the section for the "libraries" table. - In the "Cannot be toggled" column, check all the checkboxes. - Save. - Go to Administration -> Libraries. - At the top of the table there should be no "Columns" button, only "Clear filter" and "Export" buttons. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23612 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23612 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23612 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23612 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93787&action=edit Bug 23612: (RM follow-up) Fix failing tests Trailing comma's were causing hidden javascript errors during selenium tests. Error was identified by adding a $s->capture($driver) line to the relevant selenium test and using the following JS snippet to dump errors to the screen. (function () { var ul = null; function createErrorList() { ul = document.createElement('ul'); ul.setAttribute('id', 'js_error_list'); //ul.style.display = 'none'; document.body.appendChild(ul); } window.onerror = function(msg){ if (ul === null) createErrorList(); var li = document.createElement("li"); li.appendChild(document.createTextNode(msg)); ul.appendChild(li); }; })(); Which clearly showed the following error. ReferenceError: KohaTable is not defined Removing the trailing comma's introduced in this bug resolved the issue. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.