[Bug 21343] New: Automatic renewal cronjob doesn't send notices according to patron language preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Bug ID: 21343 Summary: Automatic renewal cronjob doesn't send notices according to patron language preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: bjorn.nylen@ub.lu.se QA Contact: testopia@bugs.koha-community.org The automatic_renewals.pl cronjob doesn't pass the patron language preference when generating notices. Hence all notices will be sent according to the default format. It's a trivial fix. I intend to upload a patch soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 --- Comment #1 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 78630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78630&action=edit Bug 21343: Add language preference to automatic renewal notice Bug 21343: Automatic renewal notice will now respect patron language preference. To test: 1) Set up different automatic renewal notices for Default and one other language 2) Make sure you have checkouts due for auto-renewal to patrons with non-Default language pref 3) Run automatic_renewals.pl . All patrons will get the default-language notice 4) Apply patch. 5) Repeat 2) 6) Run automatic_renewals.pl . Patrons will receive notices according to their language preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |bjorn.nylen@ub.lu.se |ity.org | CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Björn, please don't forget to assign the bug to yourself when providing a patch! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93504&action=edit Bug 21343: Automatic renewal notice will now respect patron language preference. To test: 1) Set up different automatic renewal notices for Default and one other language 2) Make sure you have checkouts due for auto-renewal to patrons with non-Default language pref 3) Run automatic_renewals.pl . All patrons will get the default-language notice 4) Apply patch. 5) Repeat 2) 6) Run automatic_renewals.pl . Patrons will receive notices according to their language preference. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93505&action=edit Bug 21343: Respect patron language preference in automtic renewals To test: 1) Set up different automatic renewal notices for Default and one other language 2) Make sure you have checkouts due for auto-renewal to patrons with non-Default language pref 3) Run automatic_renewals.pl . All patrons will get the default-language notice 4) Apply patch. 5) Repeat 2) 6) Run automatic_renewals.pl . Patrons will receive notices according to their language preference. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #78630|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93504|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as expected, a great first patch Björn, Signing off. The bug states it's sponsored, could we get the sponsor name so we can add it to the patch for proper attribution? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93505|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93566&action=edit Bug 21343: Respect patron language preference in automtic renewals To test: 1) Set up different automatic renewal notices for Default and one other language 2) Make sure you have checkouts due for auto-renewal to patrons with non-Default language pref 3) Run automatic_renewals.pl . All patrons will get the default-language notice 4) Apply patch. 5) Repeat 2) 6) Run automatic_renewals.pl . Patrons will receive notices according to their language preference. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thankyou for your first submission Björn, welcome to Koha's development team :). I've added full attribution to your employer for the sponsorship notes whilst pushing the patch too: Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org