[Bug 24518] New: Partner filtering does not work in IE11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 Bug ID: 24518 Summary: Partner filtering does not work in IE11 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com We're doing something like this to hide options that are not applicable to the current filtering string: $('#my_select_option').hide(); This applies the following CSS rule to the <option> element: display: none It turns out that IE won't hide option elements. So, that's annoying. We have a couple of choices here. We could either clone the entire list of partners, filter out the ones that don't match the search string and then use the remainder to repopulate the <option> elements. Or we could wrap the <options> in something that IE11 will apply display:none to, such as a <span> or something. However, this will lead to something that is semantically incorrect for HTML5, since a <select> can only have <option> or <optgroup> as it's children. Despite the first option feeling a bit gnarly, I'm going to go for that as it will fix the problem and not lead to broken markup. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 97974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97974&action=edit Bug 24518: Fix IE11 partner filtering This patch adopts the approach detailed in comment #1. It also fixes a couple of additional minor bugs relating to the ILL partner list: - Exclude partners with no email address, we cannot use them - Quote the "value" attribute to avoid warnings displayed by IE, they should be quoted anyway! Test plan: USE IE11 - Apply the patch - Define 3 ILL partner patrons (patrons in the category that has a code that matches the <partner_code> value in the ILL config). One patron should have no email address, the other two should have an email address - Navigate to "Place request with partners" for an ILL request - TEST: Observe that the patron with no email address is not displayed - Try filtering the list - TEST: Observe that the list filters correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io, | |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97974|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 100395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100395&action=edit Bug 24518: Fix IE11 partner filtering This patch adopts the approach detailed in comment #1. It also fixes a couple of additional minor bugs relating to the ILL partner list: - Exclude partners with no email address, we cannot use them - Quote the "value" attribute to avoid warnings displayed by IE, they should be quoted anyway! Test plan: USE IE11 - Apply the patch - Define 3 ILL partner patrons (patrons in the category that has a code that matches the <partner_code> value in the ILL config). One patron should have no email address, the other two should have an email address - Navigate to "Place request with partners" for an ILL request - TEST: Observe that the patron with no email address is not displayed - Try filtering the list - TEST: Observe that the list filters correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100395|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100953&action=edit Bug 24518: Fix IE11 partner filtering This patch adopts the approach detailed in comment #1. It also fixes a couple of additional minor bugs relating to the ILL partner list: - Exclude partners with no email address, we cannot use them - Quote the "value" attribute to avoid warnings displayed by IE, they should be quoted anyway! Test plan: USE IE11 - Apply the patch - Define 3 ILL partner patrons (patrons in the category that has a code that matches the <partner_code> value in the ILL config). One patron should have no email address, the other two should have an email address - Navigate to "Place request with partners" for an ILL request - TEST: Observe that the patron with no email address is not displayed - Try filtering the list - TEST: Observe that the list filters correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Did not test on I11, but regression tested ok -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in| |19.05.10 Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.0.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #7 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Minor/normal patch will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org