[Bug 31974] New: Regression: Bug 31813 incorrectly affected labels in the header search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Bug ID: 31974 Summary: Regression: Bug 31813 incorrectly affected labels in the header search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Staff Client Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 30952, 31813 The CSS change Bug 31813 resulted in the white-space property of header search labels being overridden. We need to make sure the header search labels do not wrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 [Bug 31813] Specify white-space: normal for spans styled as labels -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142629&action=edit Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search This patch adds a specific white-space property to header search labels so that they do not wrap. The change made by Bug 31813 overrode the white-space property incorrectly. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration. - The header search label "Search system preferences" should appear on one line. - Check that labels still wrap correctly on pages like the patron edit screen and the staged MARC record detail view. https://bugs.koha-community.org/show_bug.cgi?id=31794 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142629|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 142654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142654&action=edit Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search This patch adds a specific white-space property to header search labels so that they do not wrap. The change made by Bug 31813 overrode the white-space property incorrectly. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration. - The header search label "Search system preferences" should appear on one line. - Check that labels still wrap correctly on pages like the patron edit screen and the staged MARC record detail view. https://bugs.koha-community.org/show_bug.cgi?id=31794 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Returning to ASSIGNED while I look at some other issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142654|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142717&action=edit Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search This patch adds a specific white-space property to header search labels so that they do not wrap. The change made by Bug 31813 overrode the white-space property incorrectly. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration. - The header search label "Search system preferences" should appear on one line. - Check that labels still wrap correctly on pages like the patron edit screen and the staged MARC record detail view. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142718&action=edit Bug 31974: (follow-up) Correct some other specificity issues This follow-up makes a couple other minor corrections to label alignment. This allows for correct top-alignment of labels in forms but lets labels in other contexts, especially checkbox or radio button labels, to be aligned "middle." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142718|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 142787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142787&action=edit Bug 31974: (follow-up) Correct some other specificity issues This follow-up makes a couple other minor corrections to label alignment. This allows for correct top-alignment of labels in forms but lets labels in other contexts, especially checkbox or radio button labels, to be aligned "middle." Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): - For the second patch, look at the alignment of the label/checkboxes when checking out for: . Remember for session . Automatic renewal . Forgive fines on return (in the checkouts table) - Also can see on the check in form when the options are expanded: . Remember return date for next check in . Book drop mode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Very happy to see this fixed, I found it kinda upsetting :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142717|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142812&action=edit Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search This patch adds a specific white-space property to header search labels so that they do not wrap. The change made by Bug 31813 overrode the white-space property incorrectly. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration. - The header search label "Search system preferences" should appear on one line. - Check that labels still wrap correctly on pages like the patron edit screen and the staged MARC record detail view. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142787|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142813&action=edit Bug 31974: (follow-up) Correct some other specificity issues This follow-up makes a couple other minor corrections to label alignment. This allows for correct top-alignment of labels in forms but lets labels in other contexts, especially checkbox or radio button labels, to be aligned "middle." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 32047 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Bug 31974 depends on bug 31813, which changed state. Bug 31813 Summary: Specify white-space: normal for spans styled as labels https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Bug 31974 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org