[Bug 35107] New: ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Bug ID: 35107 Summary: ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com CC: pedro.amorim@ptfs-europe.com Depends on: 33716 Bug 33716 introduced this new feature. At the time, testing was done with the FreeForm backend. FreeForm's metadata method returns all available entries from illrequestattributes for a given request. Some backends may only provide a pre determined list of metadata keys, thus possibly leaving out type_disclaimer_value and type_disclaimer_date. To reproduce: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-p...) 2) Set ILLModuleDisclaimerByType system preference , visit: /cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans#interlibrary_loans_Workflow 3) Copy the example code, click the "Click to edit" link to open the text area, and paste the example yaml: all: text: | <h2>HTML title</h2> <p>This is an HTML paragraph</p> <p>This is another HTML paragraph</p> av_category_code: YES_NO article: text: copyright text for all article type requests av_category_code: YES_NO bypass: 1 4) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type "Book", put'9780822370451' in ISBN, put '42' in the cardnumber, and pick a library 6) You should now be in the type disclaimer stage, click "Submit" 7) Notice the disclaimer value and date are displayed under "Details from supplier" 8) Click the top "Switch provider" button and pick BLDSS 9) You should get one result, click the "Request BLL01018665793" link to finish the migration 10) You should now be in the ILL table, click the request that was just migrated to BLDSS 11) Notice the type disclaimer information is no longer visible Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 [Bug 33716] ILL - Allow for a disclaimer stage per request type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157438&action=edit Bug 35107: Show type disclaimer value and date in request details Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-p...) 2) Set ILLModuleDisclaimerByType system preference , visit: /cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans#interlibrary_loans_Workflow 3) Copy the example code, click the 'Click to edit' link to open the text area, and paste the example yaml: all: text: | <h2>HTML title</h2> <p>This is an HTML paragraph</p> <p>This is another HTML paragraph</p> av_category_code: YES_NO article: text: copyright text for all article type requests av_category_code: YES_NO bypass: 1 4) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put'9780822370451' in ISBN, put '42' in the cardnumber, and pick a library 6) You should now be in the type disclaimer stage, click 'Submit' 7) Notice the disclaimer value and date are displayed under 'Details from supplier' 8) Click the top 'Switch provider' button and pick BLDSS 9) You should get one result, click the 'Request BLL01018665793' link to finish the migration 10) You should now be in the ILL table, click the request that was just migrated to BLDSS 11) Notice the type disclaimer information is no longer visible 12) Apply patch, restart plack: koha-plack --restart kohadev 13) Refresh the BLDSS request, the information should now be visible in the 'Request details' section -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35094 [Bug 35094] ILL new request is broken -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35108 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 [Bug 35108] ILL - "Manage request" page is too loaded -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Bug 35107 depends on bug 35094, which changed state. Bug 35094 Summary: ILL new request is broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35094 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |magnus@libriotech.no, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157438|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158072&action=edit Bug 35107: Show type disclaimer value and date in request details Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-p...) 2) Set ILLModuleDisclaimerByType system preference , visit: /cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans#interlibrary_loans_Workflow 3) Copy the example code, click the 'Click to edit' link to open the text area, and paste the example yaml: all: text: | <h2>HTML title</h2> <p>This is an HTML paragraph</p> <p>This is another HTML paragraph</p> av_category_code: YES_NO article: text: copyright text for all article type requests av_category_code: YES_NO bypass: 1 4) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put'9780822370451' in ISBN, put '42' in the cardnumber, and pick a library 6) You should now be in the type disclaimer stage, click 'Submit' 7) Notice the disclaimer value and date are displayed under 'Details from supplier' 8) Click the top 'Switch provider' button and pick BLDSS 9) You should get one result, click the 'Request BLL01018665793' link to finish the migration 10) You should now be in the ILL table, click the request that was just migrated to BLDSS 11) Notice the type disclaimer information is no longer visible 12) Apply patch, restart plack: koha-plack --restart kohadev 13) Refresh the BLDSS request, the information should now be visible in the 'Request details' section Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |kyle@bywatersolutions.com CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Can we get unit tests for the new methods? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159271&action=edit Bug 35107: (QA follow-up) Use extended_attributes Addressing the warning: illrequestattributes is DEPRECATED in favor of extended_attributes No functional behaviour change here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159272&action=edit Bug 35107: Add tests prove t/db_dependent/Koha/Illrequest.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158072|0 |1 is obsolete| | Attachment #159271|0 |1 is obsolete| | Attachment #159272|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 161073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161073&action=edit Bug 35107: Show type disclaimer value and date in request details Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-p...) 2) Set ILLModuleDisclaimerByType system preference , visit: /cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans#interlibrary_loans_Workflow 3) Copy the example code, click the 'Click to edit' link to open the text area, and paste the example yaml: all: text: | <h2>HTML title</h2> <p>This is an HTML paragraph</p> <p>This is another HTML paragraph</p> av_category_code: YES_NO article: text: copyright text for all article type requests av_category_code: YES_NO bypass: 1 4) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put'9780822370451' in ISBN, put '42' in the cardnumber, and pick a library 6) You should now be in the type disclaimer stage, click 'Submit' 7) Notice the disclaimer value and date are displayed under 'Details from supplier' 8) Click the top 'Switch provider' button and pick BLDSS 9) You should get one result, click the 'Request BLL01018665793' link to finish the migration 10) You should now be in the ILL table, click the request that was just migrated to BLDSS 11) Notice the type disclaimer information is no longer visible 12) Apply patch, restart plack: koha-plack --restart kohadev 13) Refresh the BLDSS request, the information should now be visible in the 'Request details' section Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 161074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161074&action=edit Bug 35107: (QA follow-up) Use extended_attributes Addressing the warning: illrequestattributes is DEPRECATED in favor of extended_attributes No functional behaviour change here Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 161075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161075&action=edit Bug 35107: Add tests prove t/db_dependent/Koha/Illrequest.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should we not have date formatting (TT filter) on this one? [% type_disclaimer_date | html %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 163795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163795&action=edit Bug 35107: (QA follow-up) Use TT filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Bug 35107 depends on bug 33716, which changed state. Bug 33716 Summary: ILL - Allow for a disclaimer stage per request type https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org