[Bug 32233] New: Cannot add a guarantor when patron attributes have certain characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32233 Bug ID: 32233 Summary: Cannot add a guarantor when patron attributes have certain characters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Setup a patron attribute 2. Setup an authorized value category and link it to the new patron attribute 3. Make sure the new authorized value category has a code like 'Driver's License'. 4. Make sure that patron has been give that value in the patron attribute. 5. Now try to link a child account to that borrower. Nothing happens but you will see a console error like: JSON.parse: unterminated string at line 1 column 892 of the JSON data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32233 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, do you really mean code or one of the descriptions? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32233 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #1)
Hi Lucas, do you really mean code or one of the descriptions?
Katrin, sorry. I mean code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32233 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, then I am not opposed to fixing issues, but I'd also strongly encourage people not to do that. "Driver's license" is not a code, it's a description. We train libraries to stick to alphanumeric, no spaces, no underscores, no special characters etc. because it also tends to create problems with search (locations, collections, etc.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32233 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme@inlibro | |.com --- Comment #4 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- I've noticed the same issue when the selected guarantor account includes a special character. For example, a simple apostrophe in the guarantor account can block the selection. Test plan 1. Find two patrons: -patron 1 = guarantee -patron 2 = guarantor 2. In the patron 2 account, add a special character in the address field (e.g. L'Aqueduc) and save 3. Return to the patron 1 and add a guarantor 4. Search for the patron 2 5. Click on "Select" --> Nothing happens 6. Edit the patron 2 7. Remove the special character and save 8. Try to add the guarantor again --> This time, Koha will link these accounts as it should do normally. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32233 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Marie-Luce Laflamme from comment #4)
I've noticed the same issue when the selected guarantor account includes a special character. For example, a simple apostrophe in the guarantor account can block the selection.
Test plan 1. Find two patrons: -patron 1 = guarantee -patron 2 = guarantor 2. In the patron 2 account, add a special character in the address field (e.g. L'Aqueduc) and save 3. Return to the patron 1 and add a guarantor 4. Search for the patron 2 5. Click on "Select" --> Nothing happens 6. Edit the patron 2 7. Remove the special character and save 8. Try to add the guarantor again --> This time, Koha will link these accounts as it should do normally.
Marie-Luce, that sounds like it is being handled in Bug 32675. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32233 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** This bug has been marked as a duplicate of bug 32675 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org