[Bug 8058] New: Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Priority: P5 - low Change sponsored?: --- Bug ID: 8058 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines Severity: enhancement Classification: Unclassified OS: All Reporter: chrish@catalyst.net.nz Hardware: All Status: NEW Version: unspecified Component: Circulation Product: Koha Added syspref CircPayFinesRedirect that allows the pay fines page to appear if the borrower has outstanding fines when an empty barcode is entered from within circulations. If CircAutoPrintQuickSlip (added in bug 7077) is enabled then CircPayFinesRedirect will redirect after the quick slip window has opened (so it does not interfere with existing behavior). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|kyle.m.hall@gmail.com |chrish@catalyst.net.nz --- Comment #1 from Chris Hall <chrish@catalyst.net.nz> --- Created attachment 9445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9445&action=edit Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fine Added attachment (had to submit bug first to get bug number for comment) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #2 from Chris Hall <chrish@catalyst.net.nz> --- There is currently an error where if you set CircPayFinesRedirect to 'do nothing' and have CircAutoPrintQuickSlip set to 'clear screen' then koha will throw an error about an undefined PrintIssueSlip function in circ/circulation.pl, this has been reported in bug 7001 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9445|0 |1 is obsolete| | --- Comment #3 from Chris Hall <chrish@catalyst.net.nz> --- Created attachment 9446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9446&action=edit Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fine Forgot to recreate patch after adding in 'return false' to jquery bind. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Chris, Make sure you proof your patches for spelling, particularly of syspref names. Is the syspref supposed to be CircPayFinesRedirect or CircPayFindsRedirect? I think the first, but before I changed all instances of the second to the first I wanted to check that I understood correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9446|0 |1 is obsolete| | --- Comment #5 from Chris Hall <chrish@catalyst.net.nz> --- Created attachment 9574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9574&action=edit Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fine Strange as I was able to test it fine and looking at my database I see "circpayfinesredirect" in the systempreference table and not "circpayfindsredirect". Sorry this happened and thanks for pointing it out, corrected patch attached. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #6 from Marc Véron <veron@veron.ch> --- Chris and Jared, I was asked to add an additional functionality after printing: Automaticalle clear the screen. This would be in conflict with Chris' solution. So I think we could implement both using a more flexible approach. I propose to drop the preference 'circpayfinesredirect' Instead, expand the choices of 'CircAutoPrintQuickSlip' with two more options: "open a print quick slip window and clear the screen" (that's what I need to have) "open a print quick slip window and redirect to outstanding fines (if any)" (that's what Chris needs to have) The values then can be evaluated in circulation.tt (near the comment '// listen submit to trigger qslip on empty checkout'). This can be expanded for any needs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8320 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #7 from Marc Véron <veron@veron.ch> --- Opened Bug 8320 as replacement -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #8 from Chris Hall <chrish@catalyst.net.nz> --- I quite like your suggestion Marc Veron, I think having all the related options immediately visible in the same syspref is an improvement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Just need to make sure the pref works with printing without the windows too. IE printing direct to a printqueue. And then that would be fine -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #10 from Chris Hall <chrish@catalyst.net.nz> --- I have done some more work since my last patch, I will upload it shortly. In order to get this to work with print spooling I have moved the CircPayFinesRedirect code from the javascript and in to perl. In order to make this work with correctly CircAutoPrintQuickSlip I may also have move the relevant code in to perl (so any redirects happen after the code dealing with print spooling). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9574|0 |1 is obsolete| | --- Comment #11 from Chris Hall <chrish@catalyst.net.nz> --- Created attachment 10528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10528&action=edit Allows pay fines redirect to work with print spooling. Scratch that last comment, by removing the return statement from the javascript for quickslip and moving the code for CircPayFinesRedirect in to the perl code I am able to get the functionality you desired Marc Veron :) Attached is my work so far, there are 4 combinations. CircPayFinesRedirect: do nothing, CircAutoPrintQuickSlip: clear the screen -> clears the screen CircPayFinesRedirect: redirect and CircAutoPrintQuickSlip: clear the screen -> redirects if borrower has fines, otherwise clears the screen CircPayFinesRedirect: do nothing and CircAutoPrintQuickSlip: open quickslip window -> opens quick print slip and then clears the screen CircPayFinesRedirect: redirect and CircAutoPrintQuickSlip: open quickslip window -> opens quick print slip and then redirects if the borrower has fines, otherwise clears the screen (after opening print slip window). It may be wise to combine these in to a single syspref or change the wording to explain the options better. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10528|0 |1 is obsolete| | --- Comment #12 from Chris Hall <chrish@catalyst.net.nz> --- Created attachment 10531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10531&action=edit Allows pay fines redirect to work with print spooling. Attached proper patch, somehow the old patch got attached rather than the new one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #13 from Marc Véron <veron@veron.ch> --- Chris, Thanks for taking care of the additional functionality I need, see 3) below. I tried out the patch and found the following: -------------- - If a patron has a credit (instead of fines), the redirect is done as well. This should not be. -------------- - CircAutoPrintQuickSlip should have 3 possibilities: 1) Clear the screen (EXISTS) 2) Open a print quick slip window [...and do not change the screen] (EXISTS, behaviour until now, we should not change it) 3) Open a print quick slip window and clear the screen (NEW and needs to be an explicit choice) - CircPayFinesRedirect (if set and if there are fines) should override the options above and redirect to pay fines screen. If patron has no fines or if patron has a credit, it should leave the options above as set. Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Sounds like this requires a follow-up? Please change the status if I'm incorrect. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10531|0 |1 is obsolete| | --- Comment #15 from Chris Hall <chrish@catalyst.net.nz> --- Created attachment 12567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12567&action=edit Fixed error in redirecting when user had positive balance Sorry for the delay in getting this up here. I have fixed the issue Marc pointed out regarding, redirecting if the user had a positive balance. I will look in to your comments about QuickAutoPrintQuickSlip as I agree that behaviour shouldn't change. Which of these is preferable for QuickAutoPrintQuickSlip: - add in 2), so have 3 options - remove option 3 and add option 2 back in, so only have options 1) and 2) ~ Chris Hall -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #16 from Marc Véron <veron@veron.ch> --- Chris, I think we should have an additional option for CircAutoPrintQuickSlip: - Open a print quick slip window and clear the screen ---- The overall behaviour triggered by hitting an empty barcode field would be: Use case 1): Patron has no outstanding fines - Independent of Case CircPayFinesRedirect: - Case CircAutoPrintQuickSlip = Clear the screen => Clear the screen - Case CircAutoPrintQuickSlip = Open a print quick slip window => Print, when print is done go back to the borrowers screen (as is) - Case Open a print quick slip window and clear the screen => Print, when print is done go back to the borrowers screen and clear it Use case 2): Patron has outstanding fines - Case CircPayFinesRedirect is off - do the same as above - Case CircPayFinesRedirect is on - Case CircAutoPrintQuickSlip = Clear the screen => Open the pay fines screen. (When done go back to the borrowers screen.) - Case CircAutoPrintQuickSlip = Open a print quick slip window => Print. Open the pay fines screen. (When done go back to the borrowers screen.) - Case Open a print quick slip window and clear the screen => Print. Open the pay fines screen. (When done go back to the borrowers screen.) What do you think about? Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12567|0 |1 is obsolete| | --- Comment #17 from Chris Hall <chrish@catalyst.net.nz> --- Created attachment 12670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12670&action=edit Correctly implements PrintAndClear as an explicit option. Hey Marc, Thank you for catching and for your very clear instructions. Attached is a patch that implements the combinations you requested :) Thanks again, ~Chris Hall -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #18 from Chris Hall <chrish@catalyst.net.nz> --- ... by saying 'thank you for catching' I meant 'thank you for catching that change of CircAutoPrintQuickSlip behavior' ~Chris -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12670|0 |1 is obsolete| | --- Comment #19 from Chris Hall <chrish@catalyst.net.nz> --- Created attachment 12692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12692&action=edit Correctly implements PrintAndClear as an explicit option. Fixed some conflicts against master in updatedatabase and sysprefs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12692|0 |1 is obsolete| | --- Comment #20 from Marc Véron <veron@veron.ch> --- Created attachment 12693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12693&action=edit [SIGNED-OFF] Bug 8058 allow empty barcode in circulation to redirect to pay fines screen Also adds the option for printing the quickslip and then clearing the screen. Signed-off-by: Marc Veron <veron@veron.ch> Works as expected (see use cases in comment #16) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #21 from Marc Véron <veron@veron.ch> --- *** Bug 8320 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com Patch complexity|--- |Medium patch QA Contact| |paul.poulain@biblibre.com --- Comment #22 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: trying to QA the patch, when I updatedatabase.pl, I get a strange REST IS (0) that comes from + print "REST IS (@result)\n"; which should probably not be here. Otherwise, the patch passes koha-qa.pl, and there are some conflicts that I think are easy to solve, but please, do them (in case I made something wrong) (not tested by me yet) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12693|0 |1 is obsolete| | --- Comment #23 from Chris Hall <chrish@catalyst.net.nz> --- Created attachment 15649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15649&action=edit Bug 8058 allow empty barcode in circulation to redirect to pay fines screen Also adds the option for printing the quickslip and then clearing the screen. Rebased against current master, Removed accidentaly debugging statement. I also found an error in sysprefs.sql where instead of "PrintAndClear" (which is used everywhere else) I had "ClearAndPrint", this has been corrected. I removed the sign off as I have modified the patch since it was applied, I hope this is correct. For testing (after applying the patch): We need 3 patrons: one with no fines, one with outstanding fines, and one with negative fines (positive balance) Go through each of the 6 combinations of CircAutoPrintQuickSlip (Clear, Print, PrintAndClear) and CircPayFinesRedirect (No Action, Redirect) Visit each of the testing patron's check out pages and enter an empty barcode Expected behavior can be seen in comment #16 and is also summed up below. CircPayFinesRedirect should have no affects for patrons that do not have outstanding fines, in this case behavior is determined by CircAutoPrintQuickSlip. The 'interesting' cases are when a patron has outstanding fines and CircPayFinesRedirect is set to redirect: CircAutoPrintQuickSlip set to Clear : redirects (no clearing) CircAutoPrintQuickSlip set to Print : printing window opens, other window redirects CircAutoPrintQuickSlip set to PrintAndClear : printing window opens, other window redirects -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion CC| |mtompset@hotmail.com --- Comment #24 from M. Tompsett <mtompset@hotmail.com> --- How does this patch relate functionality wise to bug 11040? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org