[Bug 9264] New: Make getitems default sort to set by a preference instead of hard coded to homebranch.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264 Bug ID: 9264 Summary: Make getitems default sort to set by a preference instead of hard coded to homebranch. Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com CC: gmcharlt@gmail.com This sort order had been switched from home branch to holding branch and then back again at different points in time. Some libraries liked it when it was by holding branch, rather than home branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14006&action=edit Bug 9264 - Make getitems default sort to set by a preference instead of hard coded to homebranch. The sort order in GetItemsInfo has been switched from home branch to holding branch and then back again at different points in time. Some libraries liked it when it was by holding branch, rather than home branch. This patch makes the choice of sorting by home or holding branch a system preference. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Test the sorting order for items with the preference set each way. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7271 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Hi Kyle, just an easy fix, print "Upgrade to $DBversion done (Bug 9167: Update the virtualshelves.sortfield column with 'copyrightdate' if needed)\n"; You have the wrong message for the updatedatabase (it will need a rebase to apply also) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14006|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14887&action=edit Bug 9264 - Make getitems default sort to set by a preference instead of hard coded to homebranch. The sort order in GetItemsInfo has been switched from home branch to holding branch and then back again at different points in time. Some libraries liked it when it was by holding branch, rather than home branch. This patch makes the choice of sorting by home or holding branch a system preference. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Test the sorting order for items with the preference set each way. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #3)
3) Test the sorting order for items with the preference set each way.
This step is a little vague. In order to be thorough what places in Koha should we test? The most obvious choice, detail.pl, can't be properly tested because it has a JS-based tablesorter which overrides default sorting (something which should at the very least be addressed in a follow-up). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #5 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 9264 - Make getitems default sort to set by a preference instead of hard coded to homebranch. Using index info to reconstruct a base tree... M C4/Items.pm M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging C4/Items.pm Patch failed at 0001 Bug 9264 - Make getitems default sort to set by a preference instead of hard coded to homebranch. The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14887|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 27295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27295&action=edit Bug 9264 - Make getitems default sort to set by a preference instead of hard coded to homebranch. The sort order in GetItemsInfo has been switched from home branch to holding branch and then back again at different points in time. Some libraries liked it when it was by holding branch, rather than home branch. This patch makes the choice of sorting by home or holding branch a system preference. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Test the sorting order for items with the preference set each way. NOTE: I only rebased to make it apply. I still think Owen's feedback in comment #4 still applys. Hence the move from 'Patch does not apply' to 'In Discussion'. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org