[Bug 35761] New: Add an administration editor for FTP and SFTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Bug ID: 35761 Summary: Add an administration editor for FTP and SFTP servers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org For EDI, our partners will often create a vendor and EDI vendor record for each account they have with a vendor. This ends with a ton of duplicate FTP data. It would be great if we defined FTP/SFTP servers in their own section of the admin area and could then select a single defined FTP/SFTP for multiple EDI vendor records. That way if the password needs changed, or a vendor upgrades from FTP to SFTP, only a single record needs to be edited. In the future, this could be use to allow tools such as runreport.pl, export_records.pl, export_borrowers.pl and others to directly upload their file outputs to a remote server rather than require a second step afterward. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- We can accept the host keys when we add a new SFTP server via ssh-keyscan -h <ip or name of host> >> known_hosts when a new SFTP server is added Then, if the key changes we can detect the error ( via Net::SFTP::Foreign ) to flag e given SFTP server has no longer having a matching key. We could then add the option to "reset" the public key via "ssh-keygen -R <ip or name of host>" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37248 [Bug 37248] [Omnibus] Power to the user -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33308 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33308 [Bug 33308] Add ability to to use SFTP with runreport.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Assignee|kyle@bywatersolutions.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36766 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35622 [Bug 35622] Add "Test connection" function to EDI accounts configuration page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |jake.deery@ptfs-europe.com |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36766 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36766 [Bug 36766] Add command-line utility to SFTP a file to a remote server -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25246 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25246 [Bug 25246] Add script to export bib data to EBSCO EDS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25246 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25246 [Bug 25246] Add script to export bib data to EBSCO EDS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25246 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25246 [Bug 25246] Add script to export bib data to EBSCO EDS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38038 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38038 [Bug 38038] Add ability for new SFTP tool to support SSH keys for accessing SFTP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38115 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38115 [Bug 38115] Add FTP support to export_records.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Jake Deery <jake.deery@ptfs-europe.com> --- Really nice suggestion, I'm going to look at progressing this. Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 [Bug 38489] EDI should be linked to the new FTP/SFTP Servers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #3 from Jake Deery <jake.deery@ptfs-europe.com> --- I should be in a position to push an attachment this week :-) Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #4 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 174933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174933&action=edit Bug 35761: Introduce central FTP/SFTP management This patch adds a central FTP/SFTP management UI, with an associated database object and class, plus the beginnings of an API. We can use this code as a building block for adding FTP/SFTP connections to other parts of the system, as well as to improve the usability of the EDI transports. It is also now possible to test these connections from within the Koha UI. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #5 from Jake Deery <jake.deery@ptfs-europe.com> --- Whoops, will add a test plan!! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174933|0 |1 is obsolete| | --- Comment #6 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 174937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174937&action=edit Bug 35761: Introduce central FTP/SFTP management This patch adds a central FTP/SFTP management UI, with an associated database object and class, plus the beginnings of an API. We can use this code as a building block for adding FTP/SFTP connections to other parts of the system, as well as to improve the usability of the EDI transports. It is also now possible to test these connections from within the Koha UI. To test:- You will need access to an FTP or SFTP server Contact me if you need a disposable FTP/SFTP server a) Go to Koha Administration b) Notice no FTP/SFTP referenced on this page c) APPLY PATCH d) Create new user, let's say sftpuser e) Set permissions for new user to include: 1) catalogue 2) parameters -> manage_sftp_servers f) Log in with this new user, go back to Koha Administration 1) Notice the FTP/SFTP servers option g) Undo step e2) for the sftpuser via the koha admin user 1) Refresh the Koha Administration page as the sftpuser 2) Notice how FTP/SFTP servers has disappeared h) Back to koha admin, go to Koha Administration -> FTP/SFTP Servers -> New i) Complete form depending on the FTP or SFTP server you have access to, Submit 1) Notice you are prompted to confirm before saving j) Select Edit, observe your details are the same, and Submit again k) Repeat step J one additional time l) Select Test, observe all tests passing m) Select Delete, confirm deletion, and observe server disappear n) Optionally, run prove on new tests 1) t/Koha/Auth/Permissions.t 2) t/db_dependent/Koha/SFTP/Server.t 3) t/db_dependent/api/v1/sftp_servers.t o) SIGN-OFF -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174937|0 |1 is obsolete| | --- Comment #7 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 175030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175030&action=edit Bug 35761: Introduce central FTP/SFTP management This patch adds a central FTP/SFTP management UI, with an associated database object and class, plus the beginnings of an API. We can use this code as a building block for adding FTP/SFTP connections to other parts of the system, as well as to improve the usability of the EDI transports. It is also now possible to test these connections from within the Koha UI. To test:- You will need access to an FTP or SFTP server Contact me if you need a disposable FTP/SFTP server a) Go to Koha Administration b) Notice no FTP/SFTP referenced on this page c) APPLY PATCH d) Create new user, let's say sftpuser e) Set permissions for new user to include: 1) catalogue 2) parameters -> manage_sftp_servers f) Log in with this new user, go back to Koha Administration 1) Notice the FTP/SFTP servers option g) Undo step e2) for the sftpuser via the koha admin user 1) Refresh the Koha Administration page as the sftpuser 2) Notice how FTP/SFTP servers has disappeared h) Back to koha admin, go to Koha Administration -> FTP/SFTP Servers -> New i) Complete form depending on the FTP or SFTP server you have access to, Submit 1) Notice you are prompted to confirm before saving j) Select Edit, observe your details are the same, and Submit again k) Repeat step J one additional time l) Select Test, observe all tests passing m) Select Delete, confirm deletion, and observe server disappear n) Optionally, run prove on new tests 1) t/Koha/Auth/Permissions.t 2) t/db_dependent/Koha/SFTP/Server.t 3) t/db_dependent/api/v1/sftp_servers.t o) SIGN-OFF -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175030|0 |1 is obsolete| | --- Comment #8 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 175052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175052&action=edit Bug 35761: Introduce central FTP/SFTP management This patch adds a central FTP/SFTP management UI, with an associated database object and class, plus the beginnings of an API. We can use this code as a building block for adding FTP/SFTP connections to other parts of the system, as well as to improve the usability of the EDI transports. It is also now possible to test these connections from within the Koha UI. To test:- You will need access to an FTP or SFTP server Contact me if you need a disposable FTP/SFTP server a) Go to Koha Administration b) Notice no FTP/SFTP referenced on this page c) APPLY PATCH d) Create new user, let's say sftpuser e) Set permissions for new user to include: 1) catalogue 2) parameters -> manage_sftp_servers f) Log in with this new user, go back to Koha Administration 1) Notice the FTP/SFTP servers option g) Undo step e2) for the sftpuser via the koha admin user 1) Refresh the Koha Administration page as the sftpuser 2) Notice how FTP/SFTP servers has disappeared h) Back to koha admin, go to Koha Administration -> FTP/SFTP Servers -> New i) Complete form depending on the FTP or SFTP server you have access to, Submit 1) Notice you are prompted to confirm before saving j) Select Edit, observe your details are the same, and Submit again k) Repeat step J one additional time l) Select Test, observe all tests passing m) Select Delete, confirm deletion, and observe server disappear n) Optionally, run prove on new tests 1) t/Koha/Auth/Permissions.t 2) t/db_dependent/Koha/SFTP/Server.t 3) t/db_dependent/api/v1/sftp_servers.t o) SIGN-OFF -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Jake Deery <jake.deery@ptfs-europe.com> --- Ready for SO :-) Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #10 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 175067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175067&action=edit Bug 35761: (follow-up) Increase length of password I was finding that the password was getting truncated way too soon. I've lengthened this field to accomodate longer (encrypted) passwords. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #11 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 175166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175166&action=edit Bug 35761: Integrate EDI into new FTP/SFTP management UI This patch integrates the EDI Transport.pm module into the new FTP/SFTP management UI by tweaking the existing methods to look at the new SftpServer object, instead of its own. Included also is a change to the database structure to make use of the new sftp_servers table, as well as an atomic update to copy the schema changes, and existing config to the new sftp_servers table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- *** Bug 35622 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175166|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #13 from Jake Deery <jake.deery@ptfs-europe.com> --- *** Bug 38038 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38629 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38629 [Bug 38629] Update sftp_file.pl to support the new SFTP configurations page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36766 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36766 [Bug 36766] Add command-line utility to SFTP a file to a remote server -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- When I've entered invalid SFTP credentials and save, I'm no longer able to load the table of SFTP servers. I just get a 404 error and ended up deleting that server via SQL. Users need to be able to delete broken entries themselves from the UI. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #15 from David Nind <david@davidnind.com> --- I had a go at testing, and have a couple of questions - these are probably more related to the SFTP server I tested with, and how it is configured: 1. I can connect to the SFTP server (see testing notes), but I can't write to or delete a file in the root directory: Testing we can write a test file... Failed Error message: Couldn't open remote file '.koha_test_file': Permission denied Testing we can delete test file... Failed Error message: Couldn't delete remote file: No such file 2. In this case, the root folder for the SFTP user is not writeable. However, the upload directory is (/upload). I think this is by design in this case with the atmoz/sftp Docker image. 3. However, if a SFTP server only allows uploads to a specific directory (such as uploads), should this be configurable? 4. When I refresh the FTP/SFTP servers listing page, there is a browser console error - this is probably related to 1 and 2 above: GET http://127.0.0.1:8081/api/v1/sftp_server//test_connection 404 (Not Found) 5. Should reloading or accessing the page actually try to connect, or should this be user initiated with the test action? Testing notes (using KTD): 1. Add these commands to docker-compose-light.yml (before the networks section): sftp: image: atmoz/sftp command: koha:koha:::upload networks: - kohanet 2. Do a ktd pull and ktd up. 3. Identify the IP address of the SFTP server (kohadev-sftp-1): docker inspect -f '{{printf "====================\n"}}{{.Name}} {{range $net,$v := .NetworkSettings.Networks}}{{printf "\n"}}{{printf "\n"}}{{printf "%s\n" $net}}{{.IPAddress}}{{printf "\n"}}{{end}}' $(docker ps -q) 4. Check that you can connect to the server locally (not from the ktd shell, use koha as the password and the IP address for kohadev-sftp-1), for example: sftp koha@172.18.0.2 5. Check that you can connect to the server from within your ktd shell: sftp koha@sftp -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #16 from Jake Deery <jake.deery@ptfs-europe.com> --- Thanks for the testing, both. Digesting and will reply with some notes shortly! Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #17 from Jake Deery <jake.deery@ptfs-europe.com> --- Thanks for waiting folks, I've addressed most of the points here. Moving the directories used to the SFTP server config seems sensible, so I've done that and added a few more tests. Just on the mentioned:
5. Should reloading or accessing the page actually try to connect, or should this be user initiated with the test action?
How do we envisage this working? A big red “push me” button on that page? A modal when clicking “test” on the main config table? Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #18 from David Nind <david@davidnind.com> --- (In reply to Jake Deery from comment #17)
Thanks for waiting folks, I've addressed most of the points here. Moving the directories used to the SFTP server config seems sensible, so I've done that and added a few more tests.
Just on the mentioned:
5. Should reloading or accessing the page actually try to connect, or should this be user initiated with the test action?
How do we envisage this working? A big red “push me” button on that page? A modal when clicking “test” on the main config table?
Jake.
From memory, there was a 'Test' button in the table's action column.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175067|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175052|0 |1 is obsolete| | --- Comment #19 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 175608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175608&action=edit Bug 35761: Introduce central FTP/SFTP management This patch adds a central FTP/SFTP management UI, with an associated database object and class, plus the beginnings of an API. We can use this code as a building block for adding FTP/SFTP connections to other parts of the system, as well as to improve the usability of the EDI transports. It is also now possible to test these connections from within the Koha UI. To test:- You will need access to an FTP or SFTP server Contact me if you need a disposable FTP/SFTP server a) Go to Koha Administration b) Notice no FTP/SFTP referenced on this page c) APPLY PATCH, reset_all d) Create new user, let's say sftpuser e) Set permissions for new user to include: 1) catalogue 2) parameters -> manage_sftp_servers f) Log in with this new user, go back to Koha Administration 1) Notice the FTP/SFTP servers option g) Undo step e2) for the sftpuser via the koha admin user 1) Refresh the Koha Administration page as the sftpuser 2) Notice how FTP/SFTP servers has disappeared h) Back to koha admin, go to Koha Administration -> FTP/SFTP Servers -> New i) Complete form depending on the FTP or SFTP server you have access to, Submit 1) Notice you are prompted to confirm before saving j) Select Edit, observe your details are the same, and Submit again k) Repeat step J one additional time l) Select Test, observe all tests passing m) Select Delete, confirm deletion, and observe server disappear n) Optionally, run prove on new tests 1) t/Koha/Auth/Permissions.t 2) t/db_dependent/Koha/SFTP/Server.t 3) t/db_dependent/api/v1/sftp_servers.t o) SIGN-OFF -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #20 from Jake Deery <jake.deery@ptfs-europe.com> --- I've reworked a few aspects of this work to now: 1) Include an upload & download directory in the FTP/SFTP Server config page 2) Include a status which gives an at-a-glance of whether the server is working or not, based on the results of the latest test 3) Include a prescriptive run tests button which prevents the tests from running without prior user confirmatory action 4) Added a warning on the test page for SFTP users, informing them of the risks of using unknown SFTP servers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Comment on attachment 175608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175608 Bug 35761: Introduce central FTP/SFTP management Review of attachment 175608: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=35761&attachment=175608) ----------------------------------------------------------------- ::: Koha/SFTP/Server.pm @@ +182,5 @@
+ + return $self->set( + { + status => $value, + password => $self->plain_text_password,
What's the purpose of updating the password and key here? It looks to me like your setting status and also decrypting the password and key file at the same time? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- When one updates the configuration details we should reset the status as without running a test we don't know whether the updated details are correct so the 'Passed' or 'Failed' states in the table are misleading ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- I also prefer the behaviour where clicking 'Test' from the table took you to the new page AND ran the tests.. I find it a bit disjointed that I need to click 'Run tests' as a second step. I also find you get 'stuck' on that test page now without a clear way back to the display page.. yes you can click the breadcrumb but I think as it would make sense to have one of the buttons beneath the "form" take you back too for user flow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- For testing, this is a pretty cool service btw: https://sftpcloud.io/tools/free-sftp-server -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175608|0 |1 is obsolete| | --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175916&action=edit Bug 35761: Introduce central FTP/SFTP management This patch adds a central FTP/SFTP management UI, with an associated database object and class, plus the beginnings of an API. We can use this code as a building block for adding FTP/SFTP connections to other parts of the system, as well as to improve the usability of the EDI transports. It is also now possible to test these connections from within the Koha UI. To test:- You will need access to an FTP or SFTP server Contact me if you need a disposable FTP/SFTP server a) Go to Koha Administration b) Notice no FTP/SFTP referenced on this page c) APPLY PATCH, reset_all d) Create new user, let's say sftpuser e) Set permissions for new user to include: 1) catalogue 2) parameters -> manage_sftp_servers f) Log in with this new user, go back to Koha Administration 1) Notice the FTP/SFTP servers option g) Undo step e2) for the sftpuser via the koha admin user 1) Refresh the Koha Administration page as the sftpuser 2) Notice how FTP/SFTP servers has disappeared h) Back to koha admin, go to Koha Administration -> FTP/SFTP Servers -> New i) Complete form depending on the FTP or SFTP server you have access to, Submit 1) Notice you are prompted to confirm before saving j) Select Edit, observe your details are the same, and Submit again k) Repeat step J one additional time l) Select Test, observe all tests passing m) Select Delete, confirm deletion, and observe server disappear n) Optionally, run prove on new tests 1) t/Koha/Auth/Permissions.t 2) t/db_dependent/Koha/SFTP/Server.t 3) t/db_dependent/api/v1/sftp_servers.t o) SIGN-OFF Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #26 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Martin Renvoize (ashimema) from comment #23)
I also prefer the behaviour where clicking 'Test' from the table took you to the new page AND ran the tests.. I find it a bit disjointed that I need to click 'Run tests' as a second step. I also find you get 'stuck' on that test page now without a clear way back to the display page.. yes you can click the breadcrumb but I think as it would make sense to have one of the buttons beneath the "form" take you back too for user flow
I wouldn't mind if it automatically testing upon saving so long as a failed test doesn't prevent the save. Agreed that there could be a clearer post-test button to get back to the server list. But I signed off anyway; those could both be followup issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175916|0 |1 is obsolete| | --- Comment #27 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 176429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176429&action=edit Bug 35761: Introduce central FTP/SFTP management This patch adds a central FTP/SFTP management UI, with an associated database object and class, plus the beginnings of an API. We can use this code as a building block for adding FTP/SFTP connections to other parts of the system, as well as to improve the usability of the EDI transports. It is also now possible to test these connections from within the Koha UI. To test:- You will need access to an FTP or SFTP server Contact me if you need a disposable FTP/SFTP server a) Go to Koha Administration b) Notice no FTP/SFTP referenced on this page c) APPLY PATCH, reset_all d) Create new user, let's say sftpuser e) Set permissions for new user to include: 1) catalogue 2) parameters -> manage_sftp_servers f) Log in with this new user, go back to Koha Administration 1) Notice the FTP/SFTP servers option g) Undo step e2) for the sftpuser via the koha admin user 1) Refresh the Koha Administration page as the sftpuser 2) Notice how FTP/SFTP servers has disappeared h) Back to koha admin, go to Koha Administration -> FTP/SFTP Servers -> New i) Complete form depending on the FTP or SFTP server you have access to, Submit 1) Notice you are prompted to confirm before saving j) Select Edit, observe your details are the same, and Submit again k) Repeat step J one additional time l) Select Test, observe all tests passing m) Select Delete, confirm deletion, and observe server disappear n) Optionally, run prove on new tests 1) t/Koha/Auth/Permissions.t 2) t/db_dependent/Koha/SFTP/Server.t 3) t/db_dependent/api/v1/sftp_servers.t o) SIGN-OFF Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176429|0 |1 is obsolete| | --- Comment #28 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 176430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176430&action=edit Bug 35761: Introduce central FTP/SFTP management This patch adds a central FTP/SFTP management UI, with an associated database object and class, plus the beginnings of an API. We can use this code as a building block for adding FTP/SFTP connections to other parts of the system, as well as to improve the usability of the EDI transports. It is also now possible to test these connections from within the Koha UI. To test:- You will need access to an FTP or SFTP server Contact me if you need a disposable FTP/SFTP server a) Go to Koha Administration b) Notice no FTP/SFTP referenced on this page c) APPLY PATCH, reset_all d) Create new user, let's say sftpuser e) Set permissions for new user to include: 1) catalogue 2) parameters -> manage_sftp_servers f) Log in with this new user, go back to Koha Administration 1) Notice the FTP/SFTP servers option g) Undo step e2) for the sftpuser via the koha admin user 1) Refresh the Koha Administration page as the sftpuser 2) Notice how FTP/SFTP servers has disappeared h) Back to koha admin, go to Koha Administration -> FTP/SFTP Servers -> New i) Complete form depending on the FTP or SFTP server you have access to, Submit 1) Notice you are prompted to confirm before saving j) Select Edit, observe your details are the same, and Submit again k) Repeat step J one additional time l) Select Test, observe all tests passing m) Select Delete, confirm deletion, and observe server disappear n) Optionally, run prove on new tests 1) t/Koha/Auth/Permissions.t 2) t/db_dependent/Koha/SFTP/Server.t 3) t/db_dependent/api/v1/sftp_servers.t o) SIGN-OFF Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #29 from Jake Deery <jake.deery@ptfs-europe.com> --- Made further improvements to this work: * Reverted behaviour, so tests now run when tests button clicked (shortening path to user goal) * Test status now resets when an edit is made * Separated out password and key_file storage functionality, to avoid a bloated store subroutine, and to negate the need to 'work around' password and key_file storing when it is not necessary * Removed key_file from API response -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Missing some POD: FAIL Koha/Schema/Result/SftpServer.pm FAIL pod coverage POD is missing for koha_object_class POD is missing for koha_objects_class A test is failing, but I think this could just be due to my setup: # Failed test 'SWAGGER3.3.4' # at /kohadevbox/koha/t/db_dependent/api/v1/sftp_servers.t line 436. # got: '{"1_ftp_conn":{"err":"cannot connect to ZuxQPXx5x71QvmLk9O9rtmTOKJGgtbPZn3CJD8g66: Temporary failure in name resolution","msg":null,"passed":false}}' # expected: '{"1_ftp_conn":{"err":"cannot connect to ZuxQPXx5x71QvmLk9O9rtmTOKJGgtbPZn3CJD8g66: Name or service not known","msg":null,"passed":false}}' # Looks like you failed 1 test of 5. Failing for POD. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #31 from Jake Deery <jake.deery@ptfs-europe.com> --- Do we often write POD documents for dbix class files, because I can't see examples of this anywhere else? This was automatically generated by `./misc/devel/update_dbix_class_files.pl`. Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #32 from Jake Deery <jake.deery@ptfs-europe.com> --- Hi, Any chance at another look on this one, please? I can't see anything wrong per se when I'm running QA tools, and I don't believe those missing POD documents are essential. Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #33 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jake Deery from comment #32)
Hi,
Any chance at another look on this one, please? I can't see anything wrong per se when I'm running QA tools, and I don't believe those missing POD documents are essential.
Jake.
Jake, my fault. I can take a go at QA'ing this again. Can we have the database update/schema put into a separate commit? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176430|0 |1 is obsolete| | --- Comment #34 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 177577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177577&action=edit Bug 35761: Introduce central FTP/SFTP management This patch adds a central FTP/SFTP management UI, with an associated database object and class, plus the beginnings of an API. We can use this code as a building block for adding FTP/SFTP connections to other parts of the system, as well as to improve the usability of the EDI transports. It is also now possible to test these connections from within the Koha UI. To test:- You will need access to an FTP or SFTP server Contact me if you need a disposable FTP/SFTP server a) Go to Koha Administration b) Notice no FTP/SFTP referenced on this page c) APPLY PATCH, reset_all d) Create new user, let's say sftpuser e) Set permissions for new user to include: 1) catalogue 2) parameters -> manage_sftp_servers f) Log in with this new user, go back to Koha Administration 1) Notice the FTP/SFTP servers option g) Undo step e2) for the sftpuser via the koha admin user 1) Refresh the Koha Administration page as the sftpuser 2) Notice how FTP/SFTP servers has disappeared h) Back to koha admin, go to Koha Administration -> FTP/SFTP Servers -> New i) Complete form depending on the FTP or SFTP server you have access to, Submit 1) Notice you are prompted to confirm before saving j) Select Edit, observe your details are the same, and Submit again k) Repeat step J one additional time l) Select Test, observe all tests passing m) Select Delete, confirm deletion, and observe server disappear n) Optionally, run prove on new tests 1) t/Koha/Auth/Permissions.t 2) t/db_dependent/Koha/SFTP/Server.t 3) t/db_dependent/api/v1/sftp_servers.t o) SIGN-OFF Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #35 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 177578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177578&action=edit Bug 35761: DB schemas and atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #36 from Jake Deery <jake.deery@ptfs-europe.com> --- No prob, easy to miss, I know! I've divided that commits up into two patches. Hopefully this helps. :-) Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177577|0 |1 is obsolete| | --- Comment #37 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 177741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177741&action=edit Bug 35761: Introduce central FTP/SFTP management This patch adds a central FTP/SFTP management UI, with an associated database object and class, plus the beginnings of an API. We can use this code as a building block for adding FTP/SFTP connections to other parts of the system, as well as to improve the usability of the EDI transports. It is also now possible to test these connections from within the Koha UI. To test:- You will need access to an FTP or SFTP server Contact me if you need a disposable FTP/SFTP server a) Go to Koha Administration b) Notice no FTP/SFTP referenced on this page c) APPLY PATCH, reset_all d) Create new user, let's say sftpuser e) Set permissions for new user to include: 1) catalogue 2) parameters -> manage_sftp_servers f) Log in with this new user, go back to Koha Administration 1) Notice the FTP/SFTP servers option g) Undo step e2) for the sftpuser via the koha admin user 1) Refresh the Koha Administration page as the sftpuser 2) Notice how FTP/SFTP servers has disappeared h) Back to koha admin, go to Koha Administration -> FTP/SFTP Servers -> New i) Complete form depending on the FTP or SFTP server you have access to, Submit 1) Notice you are prompted to confirm before saving j) Select Edit, observe your details are the same, and Submit again k) Repeat step J one additional time l) Select Test, observe all tests passing m) Select Delete, confirm deletion, and observe server disappear n) Optionally, run prove on new tests 1) t/Koha/Auth/Permissions.t 2) t/db_dependent/Koha/SFTP/Server.t 3) t/db_dependent/api/v1/sftp_servers.t o) SIGN-OFF Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177578|0 |1 is obsolete| | --- Comment #38 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 177742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177742&action=edit Bug 35761: DB schemas and atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #39 from Jake Deery <jake.deery@ptfs-europe.com> --- Rebased atop main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #40 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- All works as expected from test plan QA failures: FAIL spelling passiv ==> passive Why did you name the field 'passiv' instead of 'passive'? FAIL installer/data/mysql/atomicupdate/bug_35761-add_SFTP_tables_and_perm.pl FAIL file permissions File must have the exec flag Koha/Schema/Result/SftpServer.pm - this should be in its own patch Bug 35761: DO NOT PUSH - Schema changes so that RM can generate the file on their own when they push -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- (In reply to Nick Clemens (kidclamp) from comment #40)
All works as expected from test plan
QA failures: FAIL spelling passiv ==> passive Why did you name the field 'passiv' instead of 'passive'?
FAIL installer/data/mysql/atomicupdate/bug_35761-add_SFTP_tables_and_perm.pl FAIL file permissions File must have the exec flag
Koha/Schema/Result/SftpServer.pm - this should be in its own patch Bug 35761: DO NOT PUSH - Schema changes so that RM can generate the file on their own when they push
I have a whole patchset above this now.. just considering whether it should go here or on it's own bug. I do fix the passiv -> passive spelling in that set though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 [Bug 39190] Rework new (S)FTP classes to be polymorphic classes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178552&action=edit Bug 35761: Database updates Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178553&action=edit Bug 35761: DBIC Schema Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177741|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178554&action=edit Bug 35761: Introduce central FTP/SFTP management This patch adds a central FTP/SFTP management UI, with an associated database object and class, plus the beginnings of an API. We can use this code as a building block for adding FTP/SFTP connections to other parts of the system, as well as to improve the usability of the EDI transports. It is also now possible to test these connections from within the Koha UI. To test:- You will need access to an FTP or SFTP server Contact me if you need a disposable FTP/SFTP server a) Go to Koha Administration b) Notice no FTP/SFTP referenced on this page c) APPLY PATCH, reset_all d) Create new user, let's say sftpuser e) Set permissions for new user to include: 1) catalogue 2) parameters -> manage_sftp_servers f) Log in with this new user, go back to Koha Administration 1) Notice the FTP/SFTP servers option g) Undo step e2) for the sftpuser via the koha admin user 1) Refresh the Koha Administration page as the sftpuser 2) Notice how FTP/SFTP servers has disappeared h) Back to koha admin, go to Koha Administration -> FTP/SFTP Servers -> New i) Complete form depending on the FTP or SFTP server you have access to, Submit 1) Notice you are prompted to confirm before saving j) Select Edit, observe your details are the same, and Submit again k) Repeat step J one additional time l) Select Test, observe all tests passing m) Select Delete, confirm deletion, and observe server disappear n) Optionally, run prove on new tests 1) t/Koha/Auth/Permissions.t 2) t/db_dependent/Koha/SFTP/Server.t 3) t/db_dependent/api/v1/sftp_servers.t o) SIGN-OFF Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #45 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- I added the re-work on top as it's own bug.. it warranted a proper review as it does a few things not seen in Koha before. I've asked Tomas to review it :). Setting this one back to Signed Off so it can be reviewed, but take into consideration I believe this and the follow-up bug should be pushed together as the follow-up changes a fair bit of what's implemented here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178552|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179249&action=edit Bug 35761: Database updates Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178553|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179250&action=edit Bug 35761: DBIC Schema Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178554|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179251&action=edit Bug 35761: Introduce central FTP/SFTP management This patch adds a central FTP/SFTP management UI, with an associated database object and class, plus the beginnings of an API. We can use this code as a building block for adding FTP/SFTP connections to other parts of the system, as well as to improve the usability of the EDI transports. It is also now possible to test these connections from within the Koha UI. To test:- You will need access to an FTP or SFTP server Contact me if you need a disposable FTP/SFTP server a) Go to Koha Administration b) Notice no FTP/SFTP referenced on this page c) APPLY PATCH, reset_all d) Create new user, let's say sftpuser e) Set permissions for new user to include: 1) catalogue 2) parameters -> manage_sftp_servers f) Log in with this new user, go back to Koha Administration 1) Notice the FTP/SFTP servers option g) Undo step e2) for the sftpuser via the koha admin user 1) Refresh the Koha Administration page as the sftpuser 2) Notice how FTP/SFTP servers has disappeared h) Back to koha admin, go to Koha Administration -> FTP/SFTP Servers -> New i) Complete form depending on the FTP or SFTP server you have access to, Submit 1) Notice you are prompted to confirm before saving j) Select Edit, observe your details are the same, and Submit again k) Repeat step J one additional time l) Select Test, observe all tests passing m) Select Delete, confirm deletion, and observe server disappear n) Optionally, run prove on new tests 1) t/Koha/Auth/Permissions.t 2) t/db_dependent/Koha/SFTP/Server.t 3) t/db_dependent/api/v1/sftp_servers.t o) SIGN-OFF Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |dcook@prosentient.com.au --- Comment #49 from David Cook <dcook@prosentient.com.au> --- Getting a "Does not apply" error. Think you've got a bit of an issue here with your patches. I think "Bug 35761: DB schemas and atomicupdate" needs to be obsoleted. But I'll let you double-check things. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177742|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #50 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Yup, somehow a patch got unobsoleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #51 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182918&action=edit Bug 35761: (follow-up) Add missing import There is a missing import for the encode_json method, as well as an unnecessary call to the Koha::Logger class which throws an error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179249|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185011&action=edit Bug 35761: Database updates Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179250|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185012&action=edit Bug 35761: DBIC Schema Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179251|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185013&action=edit Bug 35761: Introduce central FTP/SFTP management This patch adds a central FTP/SFTP management UI, with an associated database object and class, plus the beginnings of an API. We can use this code as a building block for adding FTP/SFTP connections to other parts of the system, as well as to improve the usability of the EDI transports. It is also now possible to test these connections from within the Koha UI. To test:- You will need access to an FTP or SFTP server Contact me if you need a disposable FTP/SFTP server a) Go to Koha Administration b) Notice no FTP/SFTP referenced on this page c) APPLY PATCH, reset_all d) Create new user, let's say sftpuser e) Set permissions for new user to include: 1) catalogue 2) parameters -> manage_sftp_servers f) Log in with this new user, go back to Koha Administration 1) Notice the FTP/SFTP servers option g) Undo step e2) for the sftpuser via the koha admin user 1) Refresh the Koha Administration page as the sftpuser 2) Notice how FTP/SFTP servers has disappeared h) Back to koha admin, go to Koha Administration -> FTP/SFTP Servers -> New i) Complete form depending on the FTP or SFTP server you have access to, Submit 1) Notice you are prompted to confirm before saving j) Select Edit, observe your details are the same, and Submit again k) Repeat step J one additional time l) Select Test, observe all tests passing m) Select Delete, confirm deletion, and observe server disappear n) Optionally, run prove on new tests 1) t/Koha/Auth/Permissions.t 2) t/db_dependent/Koha/SFTP/Server.t 3) t/db_dependent/api/v1/sftp_servers.t o) SIGN-OFF Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182918|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #55 from Jake Deery <jake.deery@openfifth.co.uk> --- Hi all, Marked attachment #182918 as obsolete. I think it was intended for Bug 39190. Ta, Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |tomascohen@gmail.com CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #56 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Hi, the DBIC schema seems to be manually tweaked (passiv vs. passive), probably an unintended deletion. It prevents `updatedatabase` to run, but that's not a problem because `dbic --force` fixes it and is not required to provide this RM-generated files. That said, I got a failure: ``` prove xt/api.t ``` which points to a problem with the response definition. It actually looks weird: ```yaml "200": description: Results of FTP/SFTP server test schema: type: object items: $ref: "../swagger.yaml#/definitions/sftp_server" ``` which should probably be: ```yaml "200": description: Results of FTP/SFTP server test schema: $ref: "../swagger.yaml#/definitions/sftp_server" ``` but reading at the controller, it seems that the endpoint is not returning an `sftp_server` object at all, but some connection test results in a JSON. I suggest you add a spec for the response structure (stfp_sever_test_results.yaml?) and follow the second example structure. This is hiding something else I bet, as that response format would not validate as an `sftp_server` object anyway and should be rejected by the OpenAPI plugin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #57 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Confirmed: ```shell kohadev-koha@kohadevbox:koha(qa_39190)$ git diff diff --git a/api/v1/swagger/paths/test_sftp_servers.yaml b/api/v1/swagger/paths/test_sftp_servers.yaml index 3fab229fc28..77c0ae46eb6 100644 --- a/api/v1/swagger/paths/test_sftp_servers.yaml +++ b/api/v1/swagger/paths/test_sftp_servers.yaml @@ -14,9 +14,7 @@ "200": description: Results of FTP/SFTP server test schema: - type: object - items: - $ref: "../swagger.yaml#/definitions/sftp_server" + $ref: "../swagger.yaml#/definitions/sftp_server" "400": description: | Bad request. Possible `error_code` attribute values: @@ -45,4 +43,4 @@ $ref: "../swagger.yaml#/definitions/error" x-koha-authorization: permissions: - parameters: manage_sftp_servers \ No newline at end of file + parameters: manage_sftp_servers kohadev-koha@kohadevbox:koha(qa_39190)$ prove t/db_dependent/api/v1/sftp_servers.t t/db_dependent/api/v1/sftp_servers.t .. 4/6 # Failed test 'SWAGGER3.2.4' # at t/db_dependent/api/v1/sftp_servers.t line 436. # got: '500' # expected: '200' # Failed test 'SWAGGER3.3.4' # at t/db_dependent/api/v1/sftp_servers.t line 436. # got: '{"errors":[{"message":"Properties not allowed: 1_ftp_conn.","path":"\/body"}],"status":500}' # expected: '{"1_ftp_conn":{"err":"cannot connect to V7OE4H7DT3dp0w0VmBxVIPF3sOf2dLpT6Js0yHDydBmb4: Name or service not known","msg":null,"passed":false}}' # Looks like you failed 2 tests of 5. # Failed test 'test() tests' # at t/db_dependent/api/v1/sftp_servers.t line 443. # Looks like you failed 1 test of 6. t/db_dependent/api/v1/sftp_servers.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/6 subtests Test Summary Report ------------------- t/db_dependent/api/v1/sftp_servers.t (Wstat: 256 (exited 1) Tests: 6 Failed: 1) Failed test: 6 Non-zero exit status: 1 Files=1, Tests=6, 4 wallclock secs ( 0.02 usr 0.01 sys + 3.50 cusr 0.75 csys = 4.28 CPU) Result: FAIL ``` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185011|0 |1 is obsolete| | Attachment #185012|0 |1 is obsolete| | Attachment #185013|0 |1 is obsolete| | --- Comment #58 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185960&action=edit Bug 35761: Database updates Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #59 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185961&action=edit Bug 35761: DBIC Schema Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Edit: Added POD to the defined methods to make tests pass: ``` prove xt/author/pod_coverage.t ``` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #60 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185962&action=edit Bug 35761: Introduce central FTP/SFTP management This patch adds a central FTP/SFTP management UI, with an associated database object and class, plus the beginnings of an API. We can use this code as a building block for adding FTP/SFTP connections to other parts of the system, as well as to improve the usability of the EDI transports. It is also now possible to test these connections from within the Koha UI. To test:- You will need access to an FTP or SFTP server Contact me if you need a disposable FTP/SFTP server a) Go to Koha Administration b) Notice no FTP/SFTP referenced on this page c) APPLY PATCH, reset_all d) Create new user, let's say sftpuser e) Set permissions for new user to include: 1) catalogue 2) parameters -> manage_sftp_servers f) Log in with this new user, go back to Koha Administration 1) Notice the FTP/SFTP servers option g) Undo step e2) for the sftpuser via the koha admin user 1) Refresh the Koha Administration page as the sftpuser 2) Notice how FTP/SFTP servers has disappeared h) Back to koha admin, go to Koha Administration -> FTP/SFTP Servers -> New i) Complete form depending on the FTP or SFTP server you have access to, Submit 1) Notice you are prompted to confirm before saving j) Select Edit, observe your details are the same, and Submit again k) Repeat step J one additional time l) Select Test, observe all tests passing m) Select Delete, confirm deletion, and observe server disappear n) Optionally, run prove on new tests 1) t/Koha/Auth/Permissions.t 2) t/db_dependent/Koha/SFTP/Server.t 3) t/db_dependent/api/v1/sftp_servers.t o) SIGN-OFF Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #61 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185963&action=edit Bug 35761: Fix API spec for sftp_servers test endpoint response The /sftp_server/{id}/test_connection endpoint was incorrectly documented as returning an sftp_server object with items array structure. Fixed by: - Creating proper sftp_test_result.yaml definition - Documenting the actual response structure with test step objects - Each test step contains: passed (boolean), err (string), msg (string) - Updated test_sftp_servers.yaml to reference correct schema - Added sftp_test_result definition to main swagger.yaml The response structure matches what the controller actually returns and what the existing tests expect. I also corrected a missing newline error highlighted by: ``` prove xt/find-missing-new-lines-at-the-end-of-file.t ``` Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #62 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185964&action=edit Bug 35761: (follow-up) Add NoWarnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #63 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185965&action=edit Bug 35761: Fix stray </form> entries Highlighted by the QA script, this patch addresses the wrong HTML structure in the template that was alerted by the tidy script. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #64 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #56)
This is hiding something else I bet, as that response format would not validate as an `sftp_server` object anyway and should be rejected by the OpenAPI plugin...
This has been hanging for too long and I realized you're already gone for the weekend... so I went ahead and provided the needed fixes :-D Happy to see this moving forward -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185963|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185964|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185965|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #65 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Once I applied bug 39190 I understood my follow-ups weren't needed. I agree with keeping Jake's work history, and then Martin's rewrite as it is part of the process and is interesting for the project. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #66 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- There is a stray </form> tag in your modal. I also see this failure: [FAIL] installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column sftp_servers.passive is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/SftpServer.pm), see the SQL12 coding guideline The new column sftp_servers.debug is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/SftpServer.pm), see the SQL12 coding guideline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #67 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #66)
There is a stray </form> tag in your modal. I also see this failure:
[FAIL] installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column sftp_servers.passive is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/SftpServer.pm), see the SQL12 coding guideline The new column sftp_servers.debug is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/SftpServer.pm), see the SQL12 coding guideline
My previous follow-ups addressed those issues amongst others. I marked them as obsolete once I understood that Martin's follow-up bug basically rewrites it all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #68 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Sorry all, but I still see the same stray <form> tag with everything applied. (In reply to Tomás Cohen Arazi (tcohen) from comment #67)
(In reply to Lucas Gass (lukeg) from comment #66)
There is a stray </form> tag in your modal. I also see this failure:
[FAIL] installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column sftp_servers.passive is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/SftpServer.pm), see the SQL12 coding guideline The new column sftp_servers.debug is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/SftpServer.pm), see the SQL12 coding guideline
My previous follow-ups addressed those issues amongst others. I marked them as obsolete once I understood that Martin's follow-up bug basically rewrites it all.
Sorry all, I don't believe this is fixed. I certainly still see the stray form tag and the QA tool tells me prog/en/modules/admin/sftp_servers.tt is not tidy. I cannot tidy it with the tool because of the stray tag. Please fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #69 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #67)
(In reply to Lucas Gass (lukeg) from comment #66)
There is a stray </form> tag in your modal. I also see this failure:
[FAIL] installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column sftp_servers.passive is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/SftpServer.pm), see the SQL12 coding guideline The new column sftp_servers.debug is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/SftpServer.pm), see the SQL12 coding guideline
My previous follow-ups addressed those issues amongst others. I marked them as obsolete once I understood that Martin's follow-up bug basically rewrites it all.
^^^ Lucas Don't look at this bug alone. Apply the them together with 39190. Because of what I said. I already posted fixes to all the issues, but it turns out it all gets rewritten there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #70 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #69)
(In reply to Tomás Cohen Arazi (tcohen) from comment #67)
(In reply to Lucas Gass (lukeg) from comment #66)
There is a stray </form> tag in your modal. I also see this failure:
[FAIL] installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column sftp_servers.passive is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/SftpServer.pm), see the SQL12 coding guideline The new column sftp_servers.debug is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/SftpServer.pm), see the SQL12 coding guideline
My previous follow-ups addressed those issues amongst others. I marked them as obsolete once I understood that Martin's follow-up bug basically rewrites it all.
^^^ Lucas
Don't look at this bug alone. Apply the them together with 39190. Because of what I said. I already posted fixes to all the issues, but it turns out it all gets rewritten there.
Ah, my misunderstanding. Sorry! I was reviewing this bug without the others applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38115 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38115 [Bug 38115] Add FTP support to export_records.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #71 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 --- Comment #72 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- We need release notes, please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38629 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38629 [Bug 38629] Update sftp_file.pl to support the new SFTP configurations page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38489 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 [Bug 38489] EDI should be updated to use the new FTP/SFTP Servers management page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|37248 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37248 [Bug 37248] [Omnibus] Power to the user -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33308 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33308 [Bug 33308] Add ability to to use SFTP with runreport.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Koha now includes a unified release notes| |administration interface | |for managing FTP and SFTP | |server connections, | |eliminating the need to | |duplicate connection | |details across different | |parts of the system. | | | |This new centralised | |configuration system allows | |you to define FTP and SFTP | |server credentials once and | |then reference them from | |multiple features (such as | |EDI). If a password changes | |or a vendor upgrades from | |FTP to SFTP, only a single | |configuration record needs | |updating. | | | |**Key features:** | | | |- **Unified server | |management**: Configure FTP | |and SFTP servers under | |Administration → File | |transports | |- **Secure credential | |storage**: Passwords and | |SSH keys are encrypted in | |the database | |- **Connection testing**: | |Test connections directly | |from the Koha interface to | |verify credentials and | |connectivity | |- **Granular permissions**: | |New | |`manage_file_transports` | |permission controls access | |to the configuration | |interface | |- **Reusable | |configurations**: Server | |configurations can be | |referenced by multiple | |features, reducing | |duplication | | | |**Configuration options:** | | | |- Transport type (FTP or | |SFTP) | |- Server hostname and port | |- Username and password | |- Upload and download | |directories | |- Connection settings | |(passive mode, debug mode) | |- SSH private key (for | |SFTP) | | | |**For administrators:** | | | |Access the new file | |transport management under | |Administration → File | |transports. The interface | |includes a connection | |testing feature that | |validates your credentials | |and checks read/write | |permissions on the | |configured directories. | | | |**Future extensibility:** | | | |This architecture provides | |a foundation for adding | |file transport capabilities | |to other Koha features such | |as `runreport.pl`, | |`export_records.pl`, and | |`export_borrowers.pl`, | |allowing them to upload | |outputs directly to remote | |servers. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #73 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk --- Comment #74 from Aude Charillon <aude.charillon@openfifth.co.uk> --- For documentation: see also bug 42816. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org