https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #68 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Sorry all, but I still see the same stray <form> tag with everything applied. (In reply to Tomás Cohen Arazi (tcohen) from comment #67)
(In reply to Lucas Gass (lukeg) from comment #66)
There is a stray </form> tag in your modal. I also see this failure:
[FAIL] installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column sftp_servers.passive is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/SftpServer.pm), see the SQL12 coding guideline The new column sftp_servers.debug is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/SftpServer.pm), see the SQL12 coding guideline
My previous follow-ups addressed those issues amongst others. I marked them as obsolete once I understood that Martin's follow-up bug basically rewrites it all.
Sorry all, I don't believe this is fixed. I certainly still see the stray form tag and the QA tool tells me prog/en/modules/admin/sftp_servers.tt is not tidy. I cannot tidy it with the tool because of the stray tag. Please fix. -- You are receiving this mail because: You are watching all bug changes.