[Bug 38100] New: Items with damaged status are shown in OPAC results as "Not available" even with AllowHoldsOnDamagedItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 Bug ID: 38100 Summary: Items with damaged status are shown in OPAC results as "Not available" even with AllowHoldsOnDamagedItems Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: januszop@gmail.com Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org CC: pmis@mnw.art.pl Items with damaged status are shown on the OPAC results page as "Not available" even with AllowHoldsOnDamagedItems set to 'Allow', which is misleading for the users. 'other/Damaged' status should be assigned only if AllowHoldsOnDamagedItems is set to 'Don't allow'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 172426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172426&action=edit Bug 38100: Items with damaged status are shown in OPAC results as "Not available" even with AllowHoldsOnDamagedItems Items with damaged status are shown on the OPAC results page as "Not available" even with AllowHoldsOnDamagedItems set to 'Allow', which is misleading for the users. 'other/Damaged' status should be assigned only if AllowHoldsOnDamagedItems is set to 'Don't allow'. Test plan: ========== 1. Check that AllowHoldsOnDamagedItems system preference is set to 'Allow'. 2. In librarian interface, change the damaged status of an item by setting it to 'Damaged'. 3. In OPAC, make a search for the record with this item attached. Use common words from title to get a list and not a single record. 4. Note that the item in question is labelled as 'Not available' (Damaged). 5. Apply the patch; restart_all. 6. Repeat p. 3. Note that the item is now labelled as 'available for loan'. 7. Set AllowHoldsOnDamagedItems system preference is set to 'Don't allow'. 8. Repeat p. 3. Note that the item is now labelled as 'Not available'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 172427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172427&action=edit Bug 38100: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172426|0 |1 is obsolete| | Attachment #172427|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 172429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172429&action=edit Bug 38100: Items with damaged status are shown in OPAC results as "Not available" even with AllowHoldsOnDamagedItems Items with damaged status are shown on the OPAC results page as "Not available" even with AllowHoldsOnDamagedItems set to 'Allow', which is misleading for the users. 'other/Damaged' status should be assigned only if AllowHoldsOnDamagedItems is set to 'Don't allow'. Test plan: ========== 1. Check that AllowHoldsOnDamagedItems system preference is set to 'Allow'. 2. In librarian interface, change the damaged status of an item by setting it to 'Damaged'. 3. In OPAC, make a search for the record with this item attached. Use common words from title to get a list and not a single record. 4. Note that the item in question is labelled as 'Not available' (Damaged). 5. Apply the patch; restart_all. 6. Repeat p. 3. Note that the item is now labelled as 'available for loan'. 7. Set AllowHoldsOnDamagedItems system preference is set to 'Don't allow'. 8. Repeat p. 3. Note that the item is now labelled as 'Not available'. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 172430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172430&action=edit Bug 38100: Unit tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172429|0 |1 is obsolete| | --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174112&action=edit Bug 38100: Items with damaged status are shown in OPAC results as "Not available" even with AllowHoldsOnDamagedItems Items with damaged status are shown on the OPAC results page as "Not available" even with AllowHoldsOnDamagedItems set to 'Allow', which is misleading for the users. 'other/Damaged' status should be assigned only if AllowHoldsOnDamagedItems is set to 'Don't allow'. Test plan: ========== 1. Check that AllowHoldsOnDamagedItems system preference is set to 'Allow'. 2. In librarian interface, change the damaged status of an item by setting it to 'Damaged'. 3. In OPAC, make a search for the record with this item attached. Use common words from title to get a list and not a single record. 4. Note that the item in question is labelled as 'Not available' (Damaged). 5. Apply the patch; restart_all. 6. Repeat p. 3. Note that the item is now labelled as 'available for loan'. 7. Set AllowHoldsOnDamagedItems system preference is set to 'Don't allow'. 8. Repeat p. 3. Note that the item is now labelled as 'Not available'. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172430|0 |1 is obsolete| | --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174113&action=edit Bug 38100: Unit tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174114&action=edit Bug 38100: (QA follow-up) Tidy changes in C4/XSLT.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | Status|Signed Off |Passed QA CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think if "Damaged" means available or not available is highly depending on the workflows of the library and how the status is used internally. But this makes it a bit more flexible, which is good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED --- Comment #12 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org