[Bug 38329] New: Remove orphan confirm_deletion() in supplier.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Bug ID: 38329 Summary: Remove orphan confirm_deletion() in supplier.tt Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: phil@chetcolibrary.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org Depends on: 28082 A dozen years ago, we used YUI rather than Bootstrap, and https://git.koha-community.org/Koha-community/Koha/src/commit/f05a8c839f7bd2... was actually used. The switch to Bootstrap duplicated the function in koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc, so we had two of them with slightly different strings (and I'm not going down the rabbit-hole of which one was actually used), until bug 28082 switched it from a link with href="javascript:confirm_deletion()" to a form a couple of years ago. Luckily, that was on 22.05, before every currently supported version, so it doesn't matter which one was used, because there's only one and it is unused on every current version. Now, it's just a complete orphan which gives a false-positive for anyone looking for the ?op="delete" which will fail due to CSRF protection. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082 [Bug 28082] Add acquisitions toolbar to vendors on vendor search page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 173890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173890&action=edit Bug 38329: Remove orphan confirm_deletion() in supplier.tt The JavaScript function confirm_deletion() in supplier.tt has either been an unused orphan since bug 28082 two years ago, or since the switch from YUI to Bootstrap 12 years ago. Doesn't matter which, nothing calls it, and if it was called, it would fail by trying to GET with op="delete" rather than POST with op="cud-delete". Test plan: 1. Acquisitions - New vendor, enter a name and Save 2. Click the name of your new vendor, so your URL is at supplier.pl 3. Click Delete vendor to verify that deleting still works without this unused code which would fail Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173890|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173948&action=edit Bug 38329: Remove orphan confirm_deletion() in supplier.tt The JavaScript function confirm_deletion() in supplier.tt has either been an unused orphan since bug 28082 two years ago, or since the switch from YUI to Bootstrap 12 years ago. Doesn't matter which, nothing calls it, and if it was called, it would fail by trying to GET with op="delete" rather than POST with op="cud-delete". Test plan: 1. Acquisitions - New vendor, enter a name and Save 2. Click the name of your new vendor, so your URL is at supplier.pl 3. Click Delete vendor to verify that deleting still works without this unused code which would fail Sponsored-by: Chetco Community Public Library Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173948|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174044&action=edit Bug 38329: Remove orphan confirm_deletion() in supplier.tt The JavaScript function confirm_deletion() in supplier.tt has either been an unused orphan since bug 28082 two years ago, or since the switch from YUI to Bootstrap 12 years ago. Doesn't matter which, nothing calls it, and if it was called, it would fail by trying to GET with op="delete" rather than POST with op="cud-delete". Test plan: 1. Acquisitions - New vendor, enter a name and Save 2. Click the name of your new vendor, so your URL is at supplier.pl 3. Click Delete vendor to verify that deleting still works without this unused code which would fail Sponsored-by: Chetco Community Public Library Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- BAckported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED CC| |jesse@bywatersolutions.com --- Comment #7 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org