[Bug 23445] New: Loan period unit in circulation rules is untranslatable causing problems one editing rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 Bug ID: 23445 Summary: Loan period unit in circulation rules is untranslatable causing problems one editing rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92137&action=edit Bug 23445: Make loan period unit translatable fixing editing issue In the circulation rules, the loan period displayed in the table of circulation rules is not translatable, always displaying in English. This causes an issue when editing a circ rule with unit hours in any other language than English. When editing these rules, instead of hours, days will be preselected. To test: - Before applying the patch: - Install a translation - Activate and switch to the tranlation - Create a circulation rule using 'hours' as the unit - Edit the circulation rule - Verify that instead of 'hours' 'days' will be selected in the pull-down - Apply patch - Update po files (kshell, cd misc/translator, perl translate update <langcode>) - Edit po file <langcode-staff..., search for Hours and translate line, make sure to also remove fuzzy, and that your translation matches the pull down values for your language - Reinstall translation - Repeat circ rule edit test - Verify the unit now shows up with your translation and editing works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92137|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92240&action=edit Bug 23445: Make loan period unit translatable fixing editing issue In the circulation rules, the loan period displayed in the table of circulation rules is not translatable, always displaying in English. This causes an issue when editing a circ rule with unit hours in any other language than English. When editing these rules, instead of hours, days will be preselected. To test: - Before applying the patch: - Install a translation - Activate and switch to the tranlation - Create a circulation rule using 'hours' as the unit - Edit the circulation rule - Verify that instead of 'hours' 'days' will be selected in the pull-down - Apply patch - Update po files (kshell, cd misc/translator, perl translate update <langcode>) - Edit po file <langcode-staff..., search for Hours and translate line, make sure to also remove fuzzy, and that your translation matches the pull down values for your language - Reinstall translation - Repeat circ rule edit test - Verify the unit now shows up with your translation and editing works Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks a lot! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This might be just a theoretical thing: But I would rather not introduce Undefined here. Just as in the code of Circulation, I would go for if ==days then days else hours or even better if ==hours then hours else days (since days is the default). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #4)
This might be just a theoretical thing: But I would rather not introduce Undefined here. Just as in the code of Circulation, I would go for if ==days then days else hours or even better if ==hours then hours else days (since days is the default).
I think that would be hiding possible problems in the database from the GUI. I and probably other tend to edit the issuingrules in SQL, especially for loading them the first time. If you have a typo or other issue there, you'd hide it. It's only in the GUI. We can also imagine that at some point minutes will be introduced (there is already a bug report) and that makes the logic there obsolete. Note: Undefined doesn't appear in the pull down! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Oh, and undefined or similar is used for the hard due dates - looked there for inspiration in the template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, not sure I phrased that well... I meant better check explicitly and at some point we will have more than 2 values. This just makes a 'nonexpected' value show as Undefined in the GUI which is think is a good clue for debugging. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92240|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 92261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92261&action=edit Bug 23445: Make loan period unit translatable fixing editing issue In the circulation rules, the loan period displayed in the table of circulation rules is not translatable, always displaying in English. This causes an issue when editing a circ rule with unit hours in any other language than English. When editing these rules, instead of hours, days will be preselected. To test: - Before applying the patch: - Install a translation - Activate and switch to the tranlation - Create a circulation rule using 'hours' as the unit - Edit the circulation rule - Verify that instead of 'hours' 'days' will be selected in the pull-down - Apply patch - Update po files (kshell, cd misc/translator, perl translate update <langcode>) - Edit po file <langcode-staff..., search for Hours and translate line, make sure to also remove fuzzy, and that your translation matches the pull down values for your language - Reinstall translation - Repeat circ rule edit test - Verify the unit now shows up with your translation and editing works Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Loan period unit in |Loan period unit in |circulation rules is |circulation rules is |untranslatable causing |untranslatable causing |problems one editing rules |problems when editing rules CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92270&action=edit Bug 23445: (RM follow-up) Add warning for unexpected lengthunit Discussions on this bug highlighted worries about behind the scenes fallbacks to 'days' as a lengthunit should the lengthunit be set to an unrecognised value. This patch adds a warning to the about page for any such occurrences so librarians may be made aware of and resolve the issue. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.04 released in| | --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org