[Bug 15783] New: C4::Koha::AddAuthorisedValue can be replaced with Koha::AuthorisedValue->new->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Bug ID: 15783 Summary: C4::Koha::AddAuthorisedValue can be replaced with Koha::AuthorisedValue->new->store Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Blocks: 15779 The C4::Koha::AddAuthorisedValue is only called twice from reports/guided_reports.pl and insert an authorised value. This job can be achieve easily using the Koha::AuthorisedValue module. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47840&action=edit Bug 15783: AddAuthorisedValue - Replace existing calls The C4::Koha::AddAuthorisedValue is only called twice from reports/guided_reports.pl and insert an authorised value. This job can be achieve easily using the Koha::AuthorisedValue module. Test plan: 1/ Create a new guided report 2/ Use an existing group and/or subgroup of reports 3/ Save 4/ Update an existing report 5/ Use an existing group and/or subgroup of reports 6/ Save 7/ Create or update an existing report 8/ Remove its assigned group and subgroup 9/ Save -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47841&action=edit Bug 15783: AddAuthorisedValue - Remove the subroutine Test plan: prove t/db_dependent/Koha.t should return green git grep AddAuthorisedValue should not return any results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47840|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 47889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47889&action=edit Bug 15783: AddAuthorisedValue - Replace existing calls The C4::Koha::AddAuthorisedValue is only called twice from reports/guided_reports.pl and insert an authorised value. This job can be achieve easily using the Koha::AuthorisedValue module. Test plan: 1/ Create a new guided report 2/ Use an existing group and/or subgroup of reports 3/ Save 4/ Update an existing report 5/ Use an existing group and/or subgroup of reports 6/ Save 7/ Create or update an existing report 8/ Remove its assigned group and subgroup 9/ Save Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47841|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 47890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47890&action=edit Bug 15783: AddAuthorisedValue - Remove the subroutine Test plan: prove t/db_dependent/Koha.t should return green git grep AddAuthorisedValue should not return any results Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15800 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 [Bug 15800] Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47889|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48021&action=edit Bug 15783: AddAuthorisedValue - Replace existing calls The C4::Koha::AddAuthorisedValue is only called twice from reports/guided_reports.pl and insert an authorised value. This job can be achieve easily using the Koha::AuthorisedValue module. Test plan: 1/ Create a new guided report 2/ Use an existing group and/or subgroup of reports 3/ Save 4/ Update an existing report 5/ Use an existing group and/or subgroup of reports 6/ Save 7/ Create or update an existing report 8/ Remove its assigned group and subgroup 9/ Save Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47890|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48022&action=edit Bug 15783: AddAuthorisedValue - Remove the subroutine Test plan: prove t/db_dependent/Koha.t should return green git grep AddAuthorisedValue should not return any results Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org