[Bug 15940] New: Remove unused JavaScript from authorities MARC subfield structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Bug ID: 15940 Summary: Remove unused JavaScript from authorities MARC subfield structure Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/auth_subfields_structure.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There is a "displayMoreConstraint" JavaScript function in the auth_subfields_structure template which is not now and has never been in use. It should be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48477&action=edit Bug 15940 - Remove unused JavaScript from authorities MARC subfield structure The authorities MARC subfield structure template contains some unused JavaScript, "function displayMoreConstraint()" This patch removes it. To test, apply the patch and go to Administration -> Authority types -> MARC structure -> Subfields -> Edit subfields and confirm that there are no JavaScript errors and tab switching works correctly. A search of the source code should show no instances of "displayMoreConstraint." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48477|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 48606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48606&action=edit Bug 15940 - Remove unused JavaScript from authorities MARC subfield structure The authorities MARC subfield structure template contains some unused JavaScript, "function displayMoreConstraint()" This patch removes it. To test, apply the patch and go to Administration -> Authority types -> MARC structure -> Subfields -> Edit subfields and confirm that there are no JavaScript errors and tab switching works correctly. A search of the source code should show no instances of "displayMoreConstraint." Signed-off-by: Frédéric Demians <f.demians@tamil.fr> No regression, no JS warning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48606|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48608&action=edit Bug 15940 - Remove unused JavaScript from authorities MARC subfield structure The authorities MARC subfield structure template contains some unused JavaScript, "function displayMoreConstraint()" This patch removes it. To test, apply the patch and go to Administration -> Authority types -> MARC structure -> Subfields -> Edit subfields and confirm that there are no JavaScript errors and tab switching works correctly. A search of the source code should show no instances of "displayMoreConstraint." Signed-off-by: Frédéric Demians <f.demians@tamil.fr> No regression, no JS warning. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.10. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org