[Bug 26112] New: Errors in marc21_authorities files for uk-UA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Bug ID: 26112 Summary: Errors in marc21_authorities files for uk-UA Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: b.pastern4k@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 107630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107630&action=edit uk-UA fixed queries for default authority Upon fresh install when I choose to add authorities, the following error shows near every authorities file install.pl: DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_sql`.`auth_tag_structure`.`repeatable` at row 1 After completing install, I tried executing those SQL commands in phpmyadmin and it seems that in mandatory and repeatable columns have values '' or 1. I tried replacing those empty strings with zero and it worked. Seems like each SQL query in those files should be checked and columns mandatory, repeatable should only have values 0 or 1 as it is type tinyint(4). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Bohdan <b.pastern4k@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |b.pastern4k@gmail.com |ity.org | Status|NEW |ASSIGNED --- Comment #1 from Bohdan <b.pastern4k@gmail.com> --- Created attachment 107637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107637&action=edit Patch for uk-UA fix of authority SQL queries Could not upload unzipped, got 413 nginx error for some reason -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Bohdan <b.pastern4k@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107637|0 |1 is obsolete| | --- Comment #2 from Bohdan <b.pastern4k@gmail.com> --- Created attachment 107638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107638&action=edit Patch for uk-UA fix of authority SQL queries Could not upload as patch, got 413 error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Bohdan <b.pastern4k@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Bohdan <b.pastern4k@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off URL| |https://github.com/mrenvoiz | |e/Koha/tree/bug_26112 CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I have uploaded a signed off patch to a branch here: https://github.com/mrenvoize/Koha/tree/bug_26112 I'm afraid I don't speak the language, but the files apply and run so I'm happy to signoff. Thankyou for the contribution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107638|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107630|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA URL|https://github.com/mrenvoiz |https://gitlab.com/kfischer |e/Koha/tree/bug_26112 |1/Koha/-/tree/bug_26112 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Replacing Martin's with my local branch - includes a tiny follow-up :) https://gitlab.com/kfischer1/Koha/-/tree/bug_26112 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have tried a new install using uk-UA but I am getting tons of errors, attaching the output logs. Can you have a look Bohdan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111377&action=edit installer_uk-UA_output.txt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 --- Comment #7 from Bohdan <b.pastern4k@gmail.com> --- Created attachment 112637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112637&action=edit Fix frameworks inserts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 --- Comment #8 from Bohdan <b.pastern4k@gmail.com> --- Created attachment 112638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112638&action=edit Remove duplicate values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Bohdan <b.pastern4k@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Bohdan, I don't manage to apply your patch. In the first zip file, there are some files that don't exist in our code base, like installer/data/mysql/uk-UA/marcflavour/marc21/optional/marc21_bibliographic_BKS_local.sql Can you please provide a remote branch that I could check out locally? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #9)
Bohdan, I don't manage to apply your patch. In the first zip file, there are some files that don't exist in our code base, like installer/data/mysql/uk-UA/marcflavour/marc21/optional/ marc21_bibliographic_BKS_local.sql
Can you please provide a remote branch that I could check out locally?
Wait, that's not true. This file exists. I am retrying. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The second patch does not apply, maybe because of the [] in the patch? I have no idea why but I've started to apply the changes manually and found: 149 ('LANG', 'ang', 'давньоанглійська (староанглійська) (450-1100)'), 150 - ('LANG', 'ang', 'англо-саксонська'), 151 - ('LANG', 'ang', 'західносаксонсь'), I am not sure we want to keep the first one. I haven't check the others, but I don't think it makes sense to keep only the first one. Can you please provide some changes to make things consistent in the second patch and attach them on this bug report on a git format-patch format, or all the patches on a remote branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Bohdan <b.pastern4k@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion --- Comment #12 from Bohdan <b.pastern4k@gmail.com> --- (In reply to Jonathan Druart from comment #11)
The second patch does not apply, maybe because of the [] in the patch? I have no idea why but I've started to apply the changes manually and found:
149 ('LANG', 'ang', 'давньоанглійська (староанглійська) (450-1100)'), 150 - ('LANG', 'ang', 'англо-саксонська'), 151 - ('LANG', 'ang', 'західносаксонсь'),
I am not sure we want to keep the first one. I haven't check the others, but I don't think it makes sense to keep only the first one.
Can you please provide some changes to make things consistent in the second patch and attach them on this bug report on a git format-patch format, or all the patches on a remote branch.
From what I understand, only first value in authorised_values is shown in dropdown when cataloguing. Therefore I removed all duplicates and left those values that suit better for those codes.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Using google translate: давньоанглійська (староанглійська) (450-1100) => Old English (Old English) (450-1100) англо-саксонська => Anglo-Saxon західносаксонсь => West Saxons Why did you keep the first one? I was trying to understand if you kept the most relevant one or just the first one without judgement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 --- Comment #14 from Bohdan <b.pastern4k@gmail.com> --- (In reply to Jonathan Druart from comment #13)
Using google translate: давньоанглійська (староанглійська) (450-1100) => Old English (Old English) (450-1100) англо-саксонська => Anglo-Saxon західносаксонсь => West Saxons
Why did you keep the first one? I was trying to understand if you kept the most relevant one or just the first one without judgement.
In this case it was just the first one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Could you rework the last patch (to keep the most relevant entries) and make the different patches available on a remote branch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is invalid now that we have removed the language specific installer files for yaml/po files. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org