[Bug 24413] New: MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Bug ID: 24413 Summary: MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jrobb@sekls.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If an account has been restricted by the long overdue process, and the item causing the restriction is returned by marking it lost (via MarkLostItemsAsReturned), the restriction is not lifted despite 'AutoRemoveOverduesRestriction' being marked to 'Do'. To replicate: 1. Set MarkLostItemsAsReturned to 'from items tab of the catalog module' 2. Set AutoRemoveOverduesRestrictions to 'Do' 3. Set up an overdues restriction in the notice triggers 4. Check out an item and let the overdues process restrict the account 5. Navigate to the moredetail.pl page (items tab) for the overdue item 6. Mark the item lost 7. Return to the account in question - notice the item has been returned, but the restriction remains -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Depends on| |2720 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|19.05 |master --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Confirmed on master. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 [Bug 2720] Overdues which debar automatically should undebar automatically when returned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99111&action=edit Bug 24413: Apply AutoRemoveOverduesRestrictions for lost items It's quite hard to know where this need to be fixed. it can be either MarkIssueReturned or LostItem, depending on the different cases we want to handle. This patch picked MarkIssueReturned, but maybe the similar code in AddReturn needs to be removed then. This patch fixes the original issue report by bug 24413, but is submitted for discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|NEW |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #2)
Created attachment 99111 [details] [review] Bug 24413: Apply AutoRemoveOverduesRestrictions for lost items
It's quite hard to know where this need to be fixed. it can be either MarkIssueReturned or LostItem, depending on the different cases we want to handle.
This patch picked MarkIssueReturned, but maybe the similar code in AddReturn needs to be removed then.
This patch fixes the original issue report by bug 24413, but is submitted for discussion
Considering MarkIssueReturned and LostItem are not always called, should it not be in _FixAccountForLostAndFound? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It seems that _FixAccountForLostAndFound is called from AddIssue and AddReturn. In our case none of them is called so I am pretty sure it will not fix the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
It seems that _FixAccountForLostAndFound is called from AddIssue and AddReturn. In our case none of them is called so I am pretty sure it will not fix the issue.
I see now, this code looks good from that perspective, though it would definitely be preferable to add a new subroutine now, otherwise we have duplicated code. It seems like a fairly trivial adjustment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #5)
(In reply to Jonathan Druart from comment #4)
It seems that _FixAccountForLostAndFound is called from AddIssue and AddReturn. In our case none of them is called so I am pretty sure it will not fix the issue.
I see now, this code looks good from that perspective, though it would definitely be preferable to add a new subroutine now, otherwise we have duplicated code. It seems like a fairly trivial adjustment.
Do not you think we should remove the code from AddReturn (as it calls MarkIssueReturned)? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6)
(In reply to Kyle M Hall from comment #5)
(In reply to Jonathan Druart from comment #4)
It seems that _FixAccountForLostAndFound is called from AddIssue and AddReturn. In our case none of them is called so I am pretty sure it will not fix the issue.
I see now, this code looks good from that perspective, though it would definitely be preferable to add a new subroutine now, otherwise we have duplicated code. It seems like a fairly trivial adjustment.
Do not you think we should remove the code from AddReturn (as it calls MarkIssueReturned)?
Yes, that makes sense. It's also worth noting that the code block is idempotent so it's not going to hurt to run it multiple times. It should just be kept in one place for code. maintenance purposes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Status|In Discussion |Needs Signoff --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This change makes sense to me, but I am not able to provide a test plan, as it is hard to predict the side-effects. I would like Jason to test this patch, and QA to make a full review and try to anticipate potential regressions. 2 pairs of QA eyes would be great here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99369&action=edit Bug 24413: Do not remove the restrictions from AddReturn As we are now removing them from MarkIssueReturned they should not be removed from AddReturn as well. Also I think this will fix a regression, if $doreturn is not set (in case the item is withdrawn and BlockReturnOfWithdrawnItems or the item is lost and BlockReturnOfLostItems, and other specific cases). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hi Jason, Are you able to test this using a sandbox perhaps? Many thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- The second patch (Do not remove the restrictions from AddReturn) does not apply for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99111|0 |1 is obsolete| | Attachment #99369|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102606&action=edit Bug 24413: Apply AutoRemoveOverduesRestrictions for lost items It's quite hard to know where this need to be fixed. it can be either MarkIssueReturned or LostItem, depending on the different cases we want to handle. This patch picked MarkIssueReturned, but maybe the similar code in AddReturn needs to be removed then. This patch fixes the original issue report by bug 24413, but is submitted for discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102607&action=edit Bug 24413: Do not remove the restrictions from AddReturn As we are now removing them from MarkIssueReturned they should not be removed from AddReturn as well. Also I think this will fix a regression, if $doreturn is not set (in case the item is withdrawn and BlockReturnOfWithdrawnItems or the item is lost and BlockReturnOfLostItems, and other specific cases). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |victor@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I was able to reproduce the issue. But it still happened after applying the patch. Double checked the syspref. Item is lost, the checkout isn't here anymore. The restriction remains. (it was tested in a koha-testing-docker env and restart_all was done) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102606|0 |1 is obsolete| | Attachment #102607|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104843&action=edit Bug 24413: Apply AutoRemoveOverduesRestrictions for lost items It's quite hard to know where this need to be fixed. it can be either MarkIssueReturned or LostItem, depending on the different cases we want to handle. This patch picked MarkIssueReturned, but maybe the similar code in AddReturn needs to be removed then. This patch fixes the original issue report by bug 24413, but is submitted for discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104844&action=edit Bug 24413: Do not remove the restrictions from AddReturn As we are now removing them from MarkIssueReturned they should not be removed from AddReturn as well. Also I think this will fix a regression, if $doreturn is not set (in case the item is withdrawn and BlockReturnOfWithdrawnItems or the item is lost and BlockReturnOfLostItems, and other specific cases). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104845&action=edit Bug 24413: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #14)
I was able to reproduce the issue. But it still happened after applying the patch. Double checked the syspref. Item is lost, the checkout isn't here anymore. The restriction remains.
(it was tested in a koha-testing-docker env and restart_all was done)
Indeed, should be fixed now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104843|0 |1 is obsolete| | --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104859&action=edit Bug 24413: Apply AutoRemoveOverduesRestrictions for lost items It's quite hard to know where this need to be fixed. it can be either MarkIssueReturned or LostItem, depending on the different cases we want to handle. This patch picked MarkIssueReturned, but maybe the similar code in AddReturn needs to be removed then. == Test plan == 1. Set MarkLostItemsAsReturned to 'from items tab of the catalog module' 2. Set AutoRemoveOverduesRestrictions to 'Do' 3. Set up an overdues restriction in the notice triggers 4. Check out an item and let the overdues process restrict the account 5. Navigate to the moredetail.pl page (items tab) for the overdue item 6. Mark the item lost 7. Return to the account in question - notice the item has been returned, but the restriction remains 8. Clean state: remove restriction + remove item lost status 9. Apply patch 10. Redo the test but this time in addition to the item being returned, the restriction will be lifted. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104844|0 |1 is obsolete| | --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104860&action=edit Bug 24413: Do not remove the restrictions from AddReturn As we are now removing them from MarkIssueReturned they should not be removed from AddReturn as well. Also I think this will fix a regression, if $doreturn is not set (in case the item is withdrawn and BlockReturnOfWithdrawnItems or the item is lost and BlockReturnOfLostItems, and other specific cases). Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104845|0 |1 is obsolete| | --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104861&action=edit Bug 24413: Add tests Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! Test plan from here has been copied in the patch and completed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104859|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105205&action=edit Bug 24413: Apply AutoRemoveOverduesRestrictions for lost items It's quite hard to know where this need to be fixed. it can be either MarkIssueReturned or LostItem, depending on the different cases we want to handle. This patch picked MarkIssueReturned, but maybe the similar code in AddReturn needs to be removed then. == Test plan == 1. Set MarkLostItemsAsReturned to 'from items tab of the catalog module' 2. Set AutoRemoveOverduesRestrictions to 'Do' 3. Set up an overdues restriction in the notice triggers 4. Check out an item and let the overdues process restrict the account 5. Navigate to the moredetail.pl page (items tab) for the overdue item 6. Mark the item lost 7. Return to the account in question - notice the item has been returned, but the restriction remains 8. Clean state: remove restriction + remove item lost status 9. Apply patch 10. Redo the test but this time in addition to the item being returned, the restriction will be lifted. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104860|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105206&action=edit Bug 24413: Do not remove the restrictions from AddReturn As we are now removing them from MarkIssueReturned they should not be removed from AddReturn as well. Also I think this will fix a regression, if $doreturn is not set (in case the item is withdrawn and BlockReturnOfWithdrawnItems or the item is lost and BlockReturnOfLostItems, and other specific cases). Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104861|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105207&action=edit Bug 24413: Add tests Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron@biblibre.c | |om --- Comment #27 from didier <didier.gautheron@biblibre.com> --- Hi subtest 'AutoRemoveOverduesRestrictions' doesn't properly cleanup issues and borrowers tables, issues table is an issue:) it breaks Koha/Biblios.t On today master prove t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/MarkIssueReturned.t .. ok All tests successful. Files=1, Tests=4, 4 wallclock secs ( 0.02 usr 0.01 sys + 3.44 cusr 0.59 csys = 4.06 CPU) Result: PASS select * from issues; +----------+----------------+------------+---------------------+------------+------------+-----------------+----------+------------+------------------+---------------------+---------------------+-----------------+------+----------+----------+ | issue_id | borrowernumber | itemnumber | date_due | branchcode | returndate | lastreneweddate | renewals | auto_renew | auto_renew_error | timestamp | issuedate | onsite_checkout | note | notedate | noteseen | +----------+----------------+------------+---------------------+------------+------------+-----------------+----------+------------+------------------+---------------------+---------------------+-----------------+------+----------+----------+ | 653 | 2000000449 | 2402 | 2020-05-29 23:59:00 | mF9sTiXrX | NULL | NULL | 0 | 0 | NULL | 2020-05-24 06:45:13 | 2020-05-24 06:45:13 | 0 | NULL | NULL | NULL | +----------+----------------+------------+---------------------+------------+------------+-----------------+----------+------------+------------------+---------------------+---------------------+-----------------+------+----------+----------+ 1 row in set (0.00 sec) prove t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Biblio.t .. 4/12 # No tests run! # Failed test 'No tests run for subtest "pickup_locations"' # at t/db_dependent/Koha/Biblio.t line 415. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_kohadev`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) [for Statement "DELETE FROM `borrowers` WHERE ( `borrowernumber` = ? )" with ParamValues: 0=2000000449] at /kohadevbox/koha/Koha/Object.pm line 229 # Looks like your test exited with 255 just after 8. t/db_dependent/Koha/Biblio.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 5/12 subtests Test Summary Report ------------------- t/db_dependent/Koha/Biblio.t (Wstat: 65280 Tests: 8 Failed: 1) Failed test: 8 Non-zero exit status: 255 Parse errors: Bad plan. You planned 12 tests but ran 8. Files=1, Tests=8, 2 wallclock secs ( 0.02 usr 0.01 sys + 1.97 cusr 0.20 csys = 2.20 CPU) Result: FAIL mysql> delete from issues; prove t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Biblio.t .. ok All tests successful. Files=1, Tests=12, 12 wallclock secs ( 0.03 usr 0.00 sys + 8.40 cusr 1.55 csys = 9.98 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105323&action=edit Bug 24413: (follow-up) Add tests Add missing transaction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed, | |rel_20_05_candidate --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Good catch, thanks Didier! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch pushed to master for 20.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | --- Comment #31 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.07 |20.05.00, 19.11.07, released in| |19.05.12 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #32 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org