[Bug 15888] New: Syndetics Reviews preference should not enable LibraryThing reviews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Bug ID: 15888 Summary: Syndetics Reviews preference should not enable LibraryThing reviews Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org On opac-detail.pl the code below attempts to retrieve LibraryThing content when SyndeticsReviews are enabled even if the librarything prefs are not turned on 564 [% IF ( SyndeticsReviews && SYNDETICS_REVIEWS ) %] 565 <li id="tab_reviews"> <a href="#reviews">Reviews</a></li> 566 <li id="tab_LTFLreviews"> 567 [% IF ( using_https ) %] 568 <script src="https://www.librarything.com/forlibraries/widget.js?id=[% LibraryThingForLibrariesID %]" type="text/javascript"></script> 569 <noscript>This page contains enriched content visible when JavaScript is enabled or by clicking <a href="https://www.librarything.com/forlibraries/noscript.php?id=[% LibraryThingForLibrariesID %]&accessibility=1">here</a>.</noscript> 570 [% ELSE %] 571 <script src="http://www.librarything.com/forlibraries/widget.js?id=[% LibraryThingForLibrariesID %]" type="text/javascript"></script> 572 <noscript>This page contains enriched content visible when JavaScript is enabled or by clicking <a href="http://www.librarything.com/forlibraries/noscript.php?id=[% LibraryThingForLibrariesID %]&accessibility=1">here</a>.</noscript> 573 [% END %] 57 </li> 575 [% END %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |nick@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 48320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48320&action=edit Bug 15888 - Syndetics Reviews preference should not enable LibraryThing reviews To test: 1 - Enable Syndetics Reviews without a LibraryThing ID 2 - Check page source and note you have a stanza for LTFL tabbed reveiws 3 - Apply patch 4 - Reload page and note LTFL tabbed reviews are not present 5 - Enter a LibraryThing ID and not the tab is restored. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48320|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 48540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48540&action=edit Bug 15888 - Syndetics Reviews preference should not enable LibraryThing reviews To test: 1 - Enable Syndetics Reviews without a LibraryThing ID 2 - Check page source and note you have a stanza for LTFL tabbed reveiws 3 - Apply patch 4 - Reload page and note LTFL tabbed reviews are not present 5 - Enter a LibraryThing ID and not the tab is restored. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48540|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49519&action=edit [PASSED QA] Bug 15888 - Syndetics Reviews preference should not enable LibraryThing reviews To test: 1 - Enable Syndetics Reviews without a LibraryThing ID 2 - Check page source and note you have a stanza for LTFL tabbed reveiws 3 - Apply patch 4 - Reload page and note LTFL tabbed reviews are not present 5 - Enter a LibraryThing ID and not the tab is restored. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed to 3.20.x, will be in 3.20.11. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org