https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40984 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187653&action=edit Bug 40984: Synchronize before_ and after_authority_action hooks with biblio action hooks This patch updates the authority action plugin hooks to match the signature and behavior of the biblio action hooks: 1. Created before_authority_action hook that is called before authority records are saved, allowing plugins to modify records before they are stored in the database 2. Updated after_authority_action hook to use a payload parameter containing authority, authority_id, and record, matching the pattern used by after_biblio_action hook 3. Maintained backward compatibility by passing both old parameters (authority, authority_id) and new payload parameter, with deprecation warnings logged when plugins implement the hook 4. Updated test plugin to use new payload-based signatures for both hooks 5. Added test coverage for before_authority_action hook Test plan: 1. Run: prove t/db_dependent/Koha/Plugins/authority_hooks.t 2. Run: prove t/db_dependent/Koha/Plugins/ 3. All tests should pass -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40984 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40984 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|IMPORTANT: The authority |IMPORTANT: The authority release notes|and authority_id parameters |and authority_id parameters |of |of |after_authority_action_hook |after_authority_action_hook |s plugins have been |s plugins have been |deprecated! Please switch |deprecated! Please switch |to using the payload hash. |to using the payload hash. |The old parameters will be |The old parameters will be |removed in a future version |removed in a future version |of Koha. |of Koha. | | | |Note that this report also | |adds | |before_authority_action_hoo | |ks allowing you modify | |authority records before | |saving. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40984 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I am not so sure about this: + # Log deprecation warning if any plugin is still using the old signature + my @plugins = Koha::Plugins->get_enabled_plugins( { verbose => 0 } ); + @plugins = grep { $_->can('after_authority_action') } @plugins; + if (@plugins) { + Koha::Logger->get->warn( + "after_authority_action hook: The old signature (with authority and authority_id as direct parameters) " + . "is deprecated and will be removed in a future release. " + . "Please update your plugin to use the 'payload' parameter instead." ); + } -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40984 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- # Call before hook _before_authority_action_hooks( { action => 'save', authority_id => $authid, record => $record } ); Not sure about the exact place we should add this call. It is a bit in the middle of various changes in AddAuthority now. For MARC21 we did already update fields like leader, 003, 005, 008. But did not yet update 001 and heading. Comparing with the biblio action, we do the before call after record changes in ModBiblioMarc and just before saving to biblio_metadata. Could you explain why we do it here? Shouldnt we better move it after the heading change just before the $authority->update? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40984 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I just stumbled over the need of this patch in 24.11 again. But I need the authtypecode in the delete message. And I am seeing this: + my $authority = $action ne 'delete' ? Koha::Authorities->find($authority_id) : undef; So we still pass only the authid to the plugin. And I need at least the type. But even better would be passing the auth object (that we already have in DelAuthority btw) to _after_authority_action_hooks. We could do similar in AddAuthority which removes the need of looking it up again in _after_authority_action_hooks itself. -- You are receiving this mail because: You are watching all bug changes.