[Bug 43438] New: All Vue datatables export the actions column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43438 Bug ID: 43438 Summary: All Vue datatables export the actions column Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Target Milestone: --- All tables in Vue applications export the actions column as they are missing the no-export class -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43438 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43438 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 204615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204615&action=edit Bug 43438: Prevent export of the actions column in Vue modules When exporting the tables in a Vue app, the action column will no longer be included Test plan: 1) Navigate through the ERM module and select a table. Click export and note that the actions column is included 2) Apply patches and yarn js:build 3) Hard refresh the browser and export - it shouldn't export the actions columns 4) Repeat for tables in the preservation, record sources and vendors modules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43438 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43438 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |pedro.amorim@openfifth.co.u | |k, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43438 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43438 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204615|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43438 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 204631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204631&action=edit Bug 43438: Prevent export of the actions column in Vue modules When exporting the tables in a Vue app, the action column will no longer be included Test plan: 1) Navigate through the ERM module and select a table. Click export and note that the actions column is included 2) Apply patches and yarn js:build 3) Hard refresh the browser and export - it shouldn't export the actions columns 4) Repeat for tables in the preservation, record sources and vendors modules Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43438 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the data that is release notes| |exported from Vue-based | |modules (such as ERM, | |Preservation, Acquisitions | |- Vendors, and record | |sources) so that the action | |column options are not | |exported (such as Edit and | |Delete). CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1, Since KTD has no ERM or record sources sample data, you need to create some. I added an agreement, license, and package for ERM so that the DataTable Export option is available. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43438 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- There are other occurrences of noExport that needs to be adjusted. They have been introduced after bug 38984 was pushed. eg. admin/categories.tt commit 84a923db1881791ab211e9376e3dd19e49cff644 Bug 38472: Remove kohaTable's exportColumns option - <th scope="col" data-colname="actions">Actions</th> + <th scope="col" class="noExport" data-colname="actions">Actions</th> commit 0f2b79c44457bfbe8faebe0ce3b9ba0a3b531292 Bug 30301: (QA follow-up) Restore correct terminology and add to columns settings - <th scope="col" class="no-export" data-colname="actions">Actions</th> + <th scope="col" class="noExport" data-colname="actions">Actions</th> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43438 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org