[Bug 41362] New: Allow Cypress tests to use KOHA_USER and KOHA_PASS as override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 Bug ID: 41362 Summary: Allow Cypress tests to use KOHA_USER and KOHA_PASS as override Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Right now they have `koha:koha` hardcoded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com Status|NEW |ASSIGNED CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190116&action=edit Bug 41362: Allow Cypress tests to use KOHA_USER and KOHA_PASS as override The cypress.config.ts file had hardcoded API credentials (koha:koha) which don't work in KTD environments that use different credentials. This patch makes the config use KOHA_USER and KOHA_PASS environment variables if set, falling back to koha:koha if not. Test plan: 1. On a running KTD, run the cypress tests: $ ktd --shell k$ run_cypress => SUCCESS: Tests are run, no errors about credentials 2. Edit your KTD .env file, so KOHA_USER=tcohen, KOHA_PASS=tomasito 3. Shut your kTD down, and start a fresh one 4. Repeat 1 => SUCCESS: The command shows `cypress run --env KOHA_USER=tcohen,KOHA_PASS=tomasito` is run. => FAIL: Some tests fail right away with invalid credentials error 5. Apply this patch 6. Repeat 1 => SUCCESS: Same command as 4 => SUCCESS: Tests don't fail for credentials 7. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190116|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 190144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190144&action=edit Bug 41362: Allow Cypress tests to use KOHA_USER and KOHA_PASS as override The cypress.config.ts file had hardcoded API credentials (koha:koha) which don't work in KTD environments that use different credentials. This patch makes the config use KOHA_USER and KOHA_PASS environment variables if set, falling back to koha:koha if not. Test plan: 1. On a running KTD, run the cypress tests: $ ktd --shell k$ run_cypress => SUCCESS: Tests are run, no errors about credentials 2. Edit your KTD .env file, so KOHA_USER=tcohen, KOHA_PASS=tomasito 3. Shut your kTD down, and start a fresh one 4. Repeat 1 => SUCCESS: The command shows `cypress run --env KOHA_USER=tcohen,KOHA_PASS=tomasito` is run. => FAIL: Some tests fail right away with invalid credentials error 5. Apply this patch 6. Repeat 1 => SUCCESS: Same command as 4 => SUCCESS: Tests don't fail for credentials 7. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Just noting that these Cypress tests were failing for me, with everything up-to-date (before the patches were applied): - t/cypress/integration/Preservation/Settings.ts: fixed by Bug 41364 - Error in preservation module breadcrumb - t/cypress/integration/SIP2/Accounts.ts (couldn't find a bug) - t/cypress/integration/Tools/ManageMarcImport_spec.ts: fixed by Bug 41368 - Tools/ManageMarcImport_spec.ts is failing - t/cypress/integrations/t/api-client.ts (couldn't find a bug) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40446 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- You are fixing only half of the problem, you also need bug 40446. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Just noting that these Cypress tests were failing for me, with everything up-to-date (before the patches were applied): - t/cypress/integration/Preservation/Settings.ts: fixed by Bug 41364 - Error in preservation module breadcrumb - t/cypress/integration/SIP2/Accounts.ts (originally failed, but now passing) - t/cypress/integration/Tools/ManageMarcImport_spec.ts: fixed by Bug 41368 - Tools/ManageMarcImport_spec.ts is failing - t/cypress/integration/t/api-client.ts (couldn't find a bug) (Updated with correct path, and that Accounts.ts is now passing.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 [Bug 40446] DB config used by Cypress (mysql2) is not configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190144|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190920&action=edit Bug 41362: Allow Cypress tests to use KOHA_USER and KOHA_PASS as override The cypress.config.ts file had hardcoded API credentials (koha:koha) which don't work in KTD environments that use different credentials. This patch makes the config use KOHA_USER and KOHA_PASS environment variables if set, falling back to koha:koha if not. Test plan: 1. On a running KTD, run the cypress tests: $ ktd --shell k$ run_cypress => SUCCESS: Tests are run, no errors about credentials 2. Edit your KTD .env file, so KOHA_USER=tcohen, KOHA_PASS=tomasito 3. Shut your kTD down, and start a fresh one 4. Repeat 1 => SUCCESS: The command shows `cypress run --env KOHA_USER=tcohen,KOHA_PASS=tomasito` is run. => FAIL: Some tests fail right away with invalid credentials error 5. Apply this patch 6. Repeat 1 => SUCCESS: Same command as 4 => SUCCESS: Tests don't fail for credentials 7. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 --- Comment #8 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backporting to 25.05 as this is an enhancement. Happy to revisit if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org