https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190920&action=edit Bug 41362: Allow Cypress tests to use KOHA_USER and KOHA_PASS as override The cypress.config.ts file had hardcoded API credentials (koha:koha) which don't work in KTD environments that use different credentials. This patch makes the config use KOHA_USER and KOHA_PASS environment variables if set, falling back to koha:koha if not. Test plan: 1. On a running KTD, run the cypress tests: $ ktd --shell k$ run_cypress => SUCCESS: Tests are run, no errors about credentials 2. Edit your KTD .env file, so KOHA_USER=tcohen, KOHA_PASS=tomasito 3. Shut your kTD down, and start a fresh one 4. Repeat 1 => SUCCESS: The command shows `cypress run --env KOHA_USER=tcohen,KOHA_PASS=tomasito` is run. => FAIL: Some tests fail right away with invalid credentials error 5. Apply this patch 6. Repeat 1 => SUCCESS: Same command as 4 => SUCCESS: Tests don't fail for credentials 7. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.