https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |wainuiwitikapark@catalyst.n |ity.org |et.nz Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27741 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #3 from wainuiwitikapark@catalyst.net.nz --- (In reply to Martin Renvoize from comment #2)

Awesome!!!! So great to see this starting to move forward.

Is this ready for testing? If it is, then updating the status for 'Needs signoff' will trigger us eager beavers to take a look :)

Welcome aboard.

Hey Martin! I'm still working on the second patch of this bug regarding adding <h1>s on each page. Hopefully will be done soon! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #4 from wainuiwitikapark@catalyst.net.nz --- Created attachment 119492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119492&action=edit Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #6 from wainuiwitikapark@catalyst.net.nz --- Created attachment 119496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119496&action=edit Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside <div> and not inside <h1> 4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #8 from wainuiwitikapark@catalyst.net.nz --- Created attachment 119498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119498&action=edit Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #10 from wainuiwitikapark@catalyst.net.nz --- Created attachment 119501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119501&action=edit Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #12 from wainuiwitikapark@catalyst.net.nz --- Created attachment 119544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119544&action=edit Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #14 from wainuiwitikapark@catalyst.net.nz --- Created attachment 119546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119546&action=edit Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |accessibility -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119492|0 |1 is obsolete| | --- Comment #18 from wainuiwitikapark@catalyst.net.nz --- Created attachment 119831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119831&action=edit Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119498|0 |1 is obsolete| | --- Comment #20 from wainuiwitikapark@catalyst.net.nz --- Created attachment 119834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119834&action=edit Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119496|0 |1 is obsolete| | --- Comment #22 from wainuiwitikapark@catalyst.net.nz --- Created attachment 119836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119836&action=edit Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside <div> and not inside <h1> 4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119501|0 |1 is obsolete| | --- Comment #24 from wainuiwitikapark@catalyst.net.nz --- Created attachment 119838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119838&action=edit Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119544|0 |1 is obsolete| | --- Comment #26 from wainuiwitikapark@catalyst.net.nz --- Created attachment 119840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119840&action=edit Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119546|0 |1 is obsolete| | --- Comment #28 from wainuiwitikapark@catalyst.net.nz --- Created attachment 119842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119842&action=edit Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #31 from wainuiwitikapark@catalyst.net.nz --- Created attachment 120158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120158&action=edit Bug 27631: (follow-up) amended aqbudgets.pl headings Added two more <h1>s to the page: Modify/Add and Delete To test: 1) Apply patch 2) Go to aqbudgets.pl 3) Check that all different pages in aqbudgets.pl have a <h1> 4) In particular, ensure that there is an <h1> on the Modify/Add page 5) In particular, ensure that there is an <h1> on the Delete page Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120158|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119831|0 |1 is obsolete| | --- Comment #33 from wainuiwitikapark@catalyst.net.nz --- Created attachment 120160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120160&action=edit Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Bug 27631: (follow-up) amended admin/aqbudgets.pl headings Added two more <h1>s to the page: Modify/Add and Delete To test: 1) Apply patch 2) Go to admin/aqbudgets.pl 3) Check that all different pages in aqbudgets.pl have a <h1> 4) In particular, ensure that there is an <h1> on the Modify/Add page 5) In particular, ensure that there is an <h1> on the Delete page Sponsored-by: Catalyst IT Bug 27631: (follow-up) amended headings admon -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120161|0 |1 is obsolete| | --- Comment #35 from wainuiwitikapark@catalyst.net.nz --- Created attachment 120162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120162&action=edit Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120162|0 |1 is obsolete| | --- Comment #36 from wainuiwitikapark@catalyst.net.nz --- Created attachment 120166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120166&action=edit Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120190|0 |1 is obsolete| | --- Comment #38 from wainuiwitikapark@catalyst.net.nz --- Created attachment 120191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120191&action=edit Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #39 from wainuiwitikapark@catalyst.net.nz --- Created attachment 121356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121356&action=edit Bug 27631: (follow-up) course_reserves/course-details.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of other heading tags, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to course_reserves/course-details and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #41 from wainuiwitikapark@catalyst.net.nz --- Created attachment 121470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121470&action=edit Bug 27631: (follow-up) tools/marc_modification_templates.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to tools/marc_modification_templates and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #43 from wainuiwitikapark@catalyst.net.nz --- Created attachment 121559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121559&action=edit Bug 27631: (follow-up) circ/branchtransfers.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to circ/branchtransfers and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532 [Bug 28532] Accessibility: Staff Client - add legends to forms -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #44 from Owen Leonard <oleonard@myacpl.org> --- On booksellers.tt, you add a "Search for vendor" h1 even though there is already an h1 on the page, "Vendor search: X results found." Is this intentional? I looks like it's redundant. The same is true on circ/bookcount.tt and on catalogue/detail.tt, where the original H1 is output by the XSL template. The labelled MARC detail page shows an error, and the QA tool catches it too: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt FAIL valid_template parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt line 94: unexpected token (END) [% END %] On circ/branchtransfers.tt the heading "Branch transfers" uses incorrect terminology. Despite the name of the file we use the term "Library" everywhere instead of "branch." On this page however I think the heading is redundant, and the existing <legend> could probably be converted to a heading. In many files the position of the toolbar relative to the heading has been changed. I agree that we lack consistency in how this is handled, but from what I can see this patch doesn't resolve that inconsistency. I would prefer that this patchset omit the changes to toolbar position so that it can be addressed separately. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #46 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125548&action=edit Bug 27631: circ folder Changed each of the pages in the circ folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the circ folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #48 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125550&action=edit Bug 27631: authorities, clubs, common, course_reserves folders Changed each of the pages in the authorities, clubs, common, course_reserves folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the authorities, clubs, common, course_reserves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #50 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125552&action=edit Bug 27631: offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders Changed each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #52 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125554&action=edit Bug 27631: tools and virtualshelves folders Changed each of the pages in the tools and virtualshelves folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the tools and virtualshelves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #54 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125556&action=edit Bug 27631: cataloguing folder Changed each of the pages in the cataloguing folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the cataloguing folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #56 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125558&action=edit Bug 27631: Hidden <h1> on intranet-main.tt This patch visually hides a <h1> on intranet-main.tt so that the heading is available to be read out by screenreaders in the summary of headings on the page. Test plan: 1) Ensure the <h1> "Koha home" heading on the staff client main/home page is hidden visually, but in the source code you can see it Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #58 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125560&action=edit Bug 27631: (follow-up) course_reserves/course-details.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to course_reserves/course-details and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #60 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125562&action=edit Bug 27631: (follow-up) reports/guided_reports_start.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this wil be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to reports/guided_reports_start and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #62 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125564&action=edit Bug 27631: (follow-up) Some minor corrections This patch makes some corrections to issues found during testing: Some duplicate headings, a markup error in labeledMARCdetail.tt, a change of the transfers heading from "Branch transfers" to "Item transfers." This patch also undoes the changes to the position of the toolbar on several pages. I think those changes don't belong in this bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125547|0 |1 is obsolete| | Attachment #125548|0 |1 is obsolete| | Attachment #125549|0 |1 is obsolete| | Attachment #125550|0 |1 is obsolete| | Attachment #125551|0 |1 is obsolete| | Attachment #125552|0 |1 is obsolete| | Attachment #125553|0 |1 is obsolete| | Attachment #125554|0 |1 is obsolete| | Attachment #125555|0 |1 is obsolete| | Attachment #125556|0 |1 is obsolete| | Attachment #125557|0 |1 is obsolete| | Attachment #125558|0 |1 is obsolete| | Attachment #125559|0 |1 is obsolete| | Attachment #125560|0 |1 is obsolete| | Attachment #125561|0 |1 is obsolete| | Attachment #125562|0 |1 is obsolete| | Attachment #125563|0 |1 is obsolete| | Attachment #125564|0 |1 is obsolete| | --- Comment #63 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127295&action=edit Bug 27631: Changed <h1> around logo to <div> To test: 1) Look at Staff Client and the logo 2) Apply patch 3) Check Koha logo moves to the middle of the page when zooming in 4) Ensure page source shows logo inside <div> and not <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #65 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127297&action=edit Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #67 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127299&action=edit Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside <div> and not inside <h1> 4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #69 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127301&action=edit Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #71 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127303&action=edit Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #73 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127305&action=edit Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #75 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127307&action=edit Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #77 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127309&action=edit Bug 27631: (follow-up) tools/marc_modification_templates.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to tools/marc_modification_templates and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #79 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127311&action=edit Bug 27631: (follow-up) circ/branchtransfers.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to circ/branchtransfers and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #81 from Owen Leonard <oleonard@myacpl.org> --- Rebased. Only the last patch needs signoff! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #83 from David Nind <david@davidnind.com> --- Created attachment 127433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127433&action=edit Bug 27631 - Koha header - logo + main actions and search display I have only reviewed and signed off Owen's minor corrections patch. I reviewed the patch and accessed pages I could to checked that they displayed correctly. Layout change - I'm assuming that the change where the Koha logo is displayed on its own and then the main search box (check out, check in, renew, search the catalog etc) directly under this is intentional, and will be fixed later. Screenshot attached of what I mean. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #85 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #83)

Layout change - I'm assuming that the change where the Koha logo is displayed on its own and then the main search box (check out, check in, renew, search the catalog etc) directly under this is intentional

Your screenshot shows the layout when the CSS hasn't been rebuilt, but it helped me notice that the alignment is still a little off even after rebuilding. My follow-up should make it better. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #87 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #85)

Your screenshot shows the layout when the CSS hasn't been rebuilt, but it helped me notice that the alignment is still a little off even after rebuilding. My follow-up should make it better.

Thanks Owen - I didn't think about rebuilding the CSS! The only thing I noticed is that as it is now centered, when the screen becomes too narrow the left side of the block with the search box, submit button are off the screen, rather than left aligned as it is currently - but there are always tradeoffs, and would be unusable at this size anyway. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility: Staff Client |Accessibility: Staff |- <h1> on each page is Logo |interface - <h1> on each |but should be page |page is Logo but should be |description/title |page description/title -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #89 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is something that is problematic, the [% INCLUDE 'blocking_errors.inc' %] should not be moved, it must be at the very beginning (right after main). The script will stop early (after the INCLUDE) and we don't want to display anything else before as the template won't receive the correct data in most of the cases. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127295|0 |1 is obsolete| | Attachment #127296|0 |1 is obsolete| | Attachment #127297|0 |1 is obsolete| | Attachment #127298|0 |1 is obsolete| | Attachment #127299|0 |1 is obsolete| | Attachment #127300|0 |1 is obsolete| | Attachment #127301|0 |1 is obsolete| | Attachment #127302|0 |1 is obsolete| | Attachment #127303|0 |1 is obsolete| | Attachment #127304|0 |1 is obsolete| | Attachment #127305|0 |1 is obsolete| | Attachment #127306|0 |1 is obsolete| | Attachment #127307|0 |1 is obsolete| | Attachment #127308|0 |1 is obsolete| | Attachment #127309|0 |1 is obsolete| | Attachment #127310|0 |1 is obsolete| | Attachment #127311|0 |1 is obsolete| | Attachment #127432|0 |1 is obsolete| | Attachment #127456|0 |1 is obsolete| | --- Comment #91 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131069&action=edit Bug 27631: Changed <h1> around logo to <div> To test: 1) Look at Staff Client and the logo 2) Apply patch 3) Check Koha logo moves to the middle of the page when zooming in 4) Ensure page source shows logo inside <div> and not <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #93 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131071&action=edit Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #95 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131073&action=edit Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside <div> and not inside <h1> 4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #97 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131075&action=edit Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #99 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131077&action=edit Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #101 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131079&action=edit Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #103 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131081&action=edit Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #105 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131083&action=edit Bug 27631: (follow-up) tools/marc_modification_templates.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to tools/marc_modification_templates and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #107 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131085&action=edit Bug 27631: (follow-up) circ/branchtransfers.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to circ/branchtransfers and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #109 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131087&action=edit Bug 27631: (follow-up) Modify logo CSS to give better alignment This patch modifies the CSS of the Koha logo and its container so that it more closely matches the previous version and so that alignment is handled better at various browser widths. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Check various pages in the staff interface to confirm that the position of the Koha logo is correct. Adjust your browser width to confirm that the alignment adapts at narrow widths. Test also on pages where the header search form can be expanded, e.g. Patrons -> [+] to expand search options. Or Acquisitions -> Orders search -> [+]. Confirm that logo alignment is correct on these pages too. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #111 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Almost there, some small things I noticed while testing: 1) Doubled up information http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=32 Information appears doubled up: Pamela Bennett (23529000318858) Pamela Bennett (23529000318858) 2) Position of headline http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=32 http://localhost:8081/cgi-bin/koha/members/pay.pl?borrowernumber=32 The heading appears above the toolbar, on all other pages it's below, which I think is better. 3) No heading http://localhost:8081/cgi-bin/koha/admin/edi_ean_accounts.pl http://localhost:8081/cgi-bin/koha/admin/items_search_fields.pl http://localhost:8081/cgi-bin/koha/tools/marc_modification_templates.pl 4) Typo http://localhost:8081/cgi-bin/koha/admin/z3950servers.pl Z19.50/SRU servers administration 5) Reword heading h1? Classification sources Classification sources h1 and h2 here are the same, maybe we should adjust h1 and the link on the admin page to have a wider scope and fit better. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #112 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131192&action=edit Bug 27631: (follow-up) Various corrections This patch addresses issues found during QA: - Double headings (patron details page) - Inconsistent heading position (check out, patron accounting) - Missing headings when there is no data (Library EANs, Item search fields, MARC modification templates). - Typo: Z19.50 => Z39.50 - Reword "Classification sources" heading: "Classification configuration" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131069|0 |1 is obsolete| | --- Comment #113 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132886&action=edit Bug 27631: Changed <h1> around logo to <div> To test: 1) Look at Staff Client and the logo 2) Apply patch 3) Check Koha logo moves to the middle of the page when zooming in 4) Ensure page source shows logo inside <div> and not <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131071|0 |1 is obsolete| | --- Comment #115 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132888&action=edit Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131073|0 |1 is obsolete| | --- Comment #117 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132890&action=edit Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside <div> and not inside <h1> 4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131075|0 |1 is obsolete| | --- Comment #119 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132892&action=edit Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131077|0 |1 is obsolete| | --- Comment #121 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132894&action=edit Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131079|0 |1 is obsolete| | --- Comment #123 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132896&action=edit Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131081|0 |1 is obsolete| | --- Comment #125 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132898&action=edit Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131083|0 |1 is obsolete| | --- Comment #127 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132900&action=edit Bug 27631: (follow-up) tools/marc_modification_templates.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to tools/marc_modification_templates and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131085|0 |1 is obsolete| | --- Comment #129 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132902&action=edit Bug 27631: (follow-up) circ/branchtransfers.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to circ/branchtransfers and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131087|0 |1 is obsolete| | --- Comment #131 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132904&action=edit Bug 27631: (follow-up) Modify logo CSS to give better alignment This patch modifies the CSS of the Koha logo and its container so that it more closely matches the previous version and so that alignment is handled better at various browser widths. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Check various pages in the staff interface to confirm that the position of the Koha logo is correct. Adjust your browser width to confirm that the alignment adapts at narrow widths. Test also on pages where the header search form can be expanded, e.g. Patrons -> [+] to expand search options. Or Acquisitions -> Orders search -> [+]. Confirm that logo alignment is correct on these pages too. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #133 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you for the follow-up, Owen! Sorry it took me so long to get back to this one, I think it's about time we get this one in! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #134 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement, as part |This enhancement, as part release notes|of improving the |of improving the |accessibility of the staff |accessibility of the staff |interface, makes the main |interface, makes the main |topic/title of the page the |topic/title of the page the |<h1> rather than the logo. |`<h1>` rather than the | |logo. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30774 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 [Bug 30774] Typo: i %sEdit %sReserve %s -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.