[Bug 30845] New: OMNIBUS: Move holds checks into CanBookBeReserved/CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 Bug ID: 30845 Summary: OMNIBUS: Move holds checks into CanBookBeReserved/CanItemBeReserved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We have a number of holds checks: not for loan opacitemholds OPACHoldsIfAvailableAtPickup which are only checked in the script, and not our modules The api uses CanBook/CanItem BeReserved for checking validity of holds and is missing these checks We need to move the checks and cover them with unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25408, 20985, 30846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 [Bug 30846] Notforloan status is not checked in CanBookBeReserved/CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33087 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 [Bug 33087] OPACHoldsIfAvailableAtPickup considers On order as available -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 Bug 30845 depends on bug 33087, which changed state. Bug 33087 Summary: OPACHoldsIfAvailableAtPickup considers On order as available https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- *** Bug 33801 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org