https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 Bug ID: 30845 Summary: OMNIBUS: Move holds checks into CanBookBeReserved/CanItemBeReserved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We have a number of holds checks: not for loan opacitemholds OPACHoldsIfAvailableAtPickup which are only checked in the script, and not our modules The api uses CanBook/CanItem BeReserved for checking validity of holds and is missing these checks We need to move the checks and cover them with unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.