[Bug 36837] New: XSLT CSS classes offered for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 Bug ID: 36837 Summary: XSLT CSS classes offered for translations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com I was translating and found 'authority-summary' for translation. Did ```shell $ git grep authority-summary koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc: <div class="authority-summary"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21authResults.xsl: <xsl:text>authority-summary</xsl:text> koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCauthResults.xsl: <xsl:text>authority-summary</xsl:text> koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCauthResults.xsl: <!-- end div class authority-summary--> koha-tmpl/opac-tmpl/bootstrap/en/includes/authorities-search-results.inc: <div class="authority-summary"> ``` The next one was `authref` but it all follows the same pattern of being a <xsl:text> node. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30554 CC| |tomascohen@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30554 [Bug 30554] Use XSLT in authority search cataloguing plugin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166643&action=edit Bug 36837: Simplify XSLT and aid translatability This patch makes the XSLT contain HTML tags instead of building them from scratch with static attribute values. This made it awkward for translators as CSS classes ended up being extracted for translation purposes. Plus, there's no need to spend CPU cycles on static content generation. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166643|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166647&action=edit Bug 36837: Simplify XSLT and aid translatability This patch makes the XSLT contain HTML tags instead of building them from scratch with static attribute values. This made it awkward for translators as CSS classes ended up being extracted for translation purposes. Plus, there's no need to spend CPU cycles on static content generation. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I see no reason these should have been getting built by the xsl processing.. they're not using variables etc. More than happy with the patch, no regressions found. Going straight for a PQA here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166649&action=edit Bug 36837: (follow-up) UNIMARC case I checked the UNIMARC authResults counterpart file. And it only contained a single case of generated elements like the previous patch. To test: 1. On latest main $ ktd --shell k$ cd misc/translator/po k$ git fetch k$ git reset --hard origin/main k$ cd /kohadevbox/koha k$ gulp po:update --lang es-ES k$ cd misc/translator/po k$ git add -u ; git commit -mWIP --no-verify 2. Apply this patches 3. Run: k$ cd /kohadevbox/koha k$ gulp po:update --lang es-ES k$ cd misc/translator/po k$ git diff => SUCCESS: Notice CSS class names are not translated anymore Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 Bug 36837 depends on bug 30554, which changed state. Bug 30554 Summary: Use XSLT in authority search cataloguing plugin https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30554 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36837 Bug 36837 depends on bug 30554, which changed state. Bug 30554 Summary: Use XSLT in authority search cataloguing plugin https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30554 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org