[Bug 16946] New: Remove the use of "onclick" from several serials templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Bug ID: 16946 Summary: Remove the use of "onclick" from several serials templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com There are many uses of "onclick" and other event attributes in the Serials module templates. This bug will track changes to several of them: checkexpiration.tt claims.tt result.tt routing-preview-slip.tt routing-preview.tt routing.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53532&action=edit Bug 16946 - Remove the use of "onclick" from several serials templates This patch modifies several serials module templates to remove the use of event attributes. Events will now be defined in JavaScript. Also changed: - In Serials -> Check expiration, custom form validation has been removed in favor of validation with the plugin. - In Serials -> Claims, the "Clear filter" button has been replaced with a link. Error messages are now styled with the standard "alert" class. - In Serials -> New subscription -> Search for record, the "choose" link is now a Bootstrap button. Pagination links are now styled like other similar links. The "Close" button is now styled as in other popup windows. The "no results found" messages is styled as an informational dialog. - In Serials -> Subscription -> Edit routing list, the "add recipients" and "delete all" controls are now links with Font Awesome icons. To test, apply the patch and: - Go to Serials -> Check expiration. - Try to submit the form without filling in a date. The form validation plugin should warn you that the date field is required. - Submit the form using data which will return results. - Click the "Renew" button for any result. The subscription renewal popup should be triggered for the correct title. - Go to Serials -> Claims. - Select a vendor with missing issues. - Confirm that the date filter works correctly, and that the "Clear filter" link works. - Select one or more result and click the "Send notification" button. The notification should be sent. - Go to Serials -> New subscription. - Click the "Search for record" link to trigger the bibliographic search popup. - Perform a search. Confirm that the "Choose" button selects the correct record and populates the fields in the parent window. - Go to Serials -> Subscription -> Edit routing list. - Confirm that the process of adding recipients to the list works correctly. - Confirm that changing the rank of any recipient works correctly. - Save the routing list and click the "Save and preview routing slip" button on the confirmation page. The slip preview should open. - In the slip preview window, test that the print button works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53532|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 53541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53541&action=edit [SIGNED-OFF] Bug 16946 - Remove the use of "onclick" from several serials templates This patch modifies several serials module templates to remove the use of event attributes. Events will now be defined in JavaScript. Also changed: - In Serials -> Check expiration, custom form validation has been removed in favor of validation with the plugin. - In Serials -> Claims, the "Clear filter" button has been replaced with a link. Error messages are now styled with the standard "alert" class. - In Serials -> New subscription -> Search for record, the "choose" link is now a Bootstrap button. Pagination links are now styled like other similar links. The "Close" button is now styled as in other popup windows. The "no results found" messages is styled as an informational dialog. - In Serials -> Subscription -> Edit routing list, the "add recipients" and "delete all" controls are now links with Font Awesome icons. To test, apply the patch and: - Go to Serials -> Check expiration. - Try to submit the form without filling in a date. The form validation plugin should warn you that the date field is required. - Submit the form using data which will return results. - Click the "Renew" button for any result. The subscription renewal popup should be triggered for the correct title. - Go to Serials -> Claims. - Select a vendor with missing issues. - Confirm that the date filter works correctly, and that the "Clear filter" link works. - Select one or more result and click the "Send notification" button. The notification should be sent. - Go to Serials -> New subscription. - Click the "Search for record" link to trigger the bibliographic search popup. - Perform a search. Confirm that the "Choose" button selects the correct record and populates the fields in the parent window. - Go to Serials -> Subscription -> Edit routing list. - Confirm that the process of adding recipients to the list works correctly. - Confirm that changing the rank of any recipient works correctly. - Save the routing list and click the "Save and preview routing slip" button on the confirmation page. The slip preview should open. - In the slip preview window, test that the print button works correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- - serials/claims.pl "clear filter" does not blank from and to dates. - serials/routing-preview.tt and serials/routing.tt you removed <!--, but kept //--> Otherwise, looks good! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53541|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 54009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54009&action=edit [SIGNED-OFF] Bug 16946 [Revised] Remove the use of "onclick" from several serials templates This patch modifies several serials module templates to remove the use of event attributes. Events will now be defined in JavaScript. Also changed: - In Serials -> Check expiration, custom form validation has been removed in favor of validation with the plugin. - In Serials -> Claims, the "Clear filter" button has been replaced with a link. Error messages are now styled with the standard "alert" class. - In Serials -> New subscription -> Search for record, the "choose" link is now a Bootstrap button. Pagination links are now styled like other similar links. The "Close" button is now styled as in other popup windows. The "no results found" messages is styled as an informational dialog. - In Serials -> Subscription -> Edit routing list, the "add recipients" and "delete all" controls are now links with Font Awesome icons. To test, apply the patch and: - Go to Serials -> Check expiration. - Try to submit the form without filling in a date. The form validation plugin should warn you that the date field is required. - Submit the form using data which will return results. - Click the "Renew" button for any result. The subscription renewal popup should be triggered for the correct title. - Go to Serials -> Claims. - Select a vendor with missing issues. - Confirm that the date filter works correctly, and that the "Clear filter" link works. - Select one or more result and click the "Send notification" button. The notification should be sent. - Go to Serials -> New subscription. - Click the "Search for record" link to trigger the bibliographic search popup. - Perform a search. Confirm that the "Choose" button selects the correct record and populates the fields in the parent window. - Go to Serials -> Subscription -> Edit routing list. - Confirm that the process of adding recipients to the list works correctly. - Confirm that changing the rank of any recipient works correctly. - Save the routing list and click the "Save and preview routing slip" button on the confirmation page. The slip preview should open. - In the slip preview window, test that the print button works correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> QA revision: Removed stray '// -->' and corrected clear filter function -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54009|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54026&action=edit Bug 16946 [Revised] Remove the use of "onclick" from several serials templates This patch modifies several serials module templates to remove the use of event attributes. Events will now be defined in JavaScript. Also changed: - In Serials -> Check expiration, custom form validation has been removed in favor of validation with the plugin. - In Serials -> Claims, the "Clear filter" button has been replaced with a link. Error messages are now styled with the standard "alert" class. - In Serials -> New subscription -> Search for record, the "choose" link is now a Bootstrap button. Pagination links are now styled like other similar links. The "Close" button is now styled as in other popup windows. The "no results found" messages is styled as an informational dialog. - In Serials -> Subscription -> Edit routing list, the "add recipients" and "delete all" controls are now links with Font Awesome icons. To test, apply the patch and: - Go to Serials -> Check expiration. - Try to submit the form without filling in a date. The form validation plugin should warn you that the date field is required. - Submit the form using data which will return results. - Click the "Renew" button for any result. The subscription renewal popup should be triggered for the correct title. - Go to Serials -> Claims. - Select a vendor with missing issues. - Confirm that the date filter works correctly, and that the "Clear filter" link works. - Select one or more result and click the "Send notification" button. The notification should be sent. - Go to Serials -> New subscription. - Click the "Search for record" link to trigger the bibliographic search popup. - Perform a search. Confirm that the "Choose" button selects the correct record and populates the fields in the parent window. - Go to Serials -> Subscription -> Edit routing list. - Confirm that the process of adding recipients to the list works correctly. - Confirm that changing the rank of any recipient works correctly. - Save the routing list and click the "Save and preview routing slip" button on the confirmation page. The slip preview should open. - In the slip preview window, test that the print button works correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> QA revision: Removed stray '// -->' and corrected clear filter function Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Serials |Templates CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org