https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53662&action=edit Bug 16963 - Remove the use of "onclick" from subscription add template This patch removes the use of event attributes from the subscription add template and the template for testing prediction patterns. Events are now defined in the JavaScript. To test, go to Serials -> New subscription. - Test that the "Search for vendor," "Search for record," and "Create record" links work correctly. - Test the "Next" button without entering a vendor or a biblionumber. You should be warned about selecting a vendor and biblionumber. - After selecting a bibliographic record to link to the subscription, click the "Next" button. The second section of the subscription add form should be displayed. - Under frequency, choose "1/day." - Confirm that the "Show advanced pattern" link correctly toggles display of the advanced pattern form. - Under the advanced pattern form, test the "Modify pattern" button. It should enable editing in the form. - Test the "Cancel modifications" and "Save as new pattern" buttons. - Test the "Test prediction pattern" button. - In the "Prediction pattern" box, test that the checkboxes next to each day of the week, when checked, trigger the corresponding issue number to be marked as "not published." - Finally, confirm that your subscription is saved correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53662|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54736&action=edit [SIGNED-OFF] Bug 16963 - Remove the use of "onclick" from subscription add template This patch removes the use of event attributes from the subscription add template and the template for testing prediction patterns. Events are now defined in the JavaScript. To test, go to Serials -> New subscription. - Test that the "Search for vendor," "Search for record," and "Create record" links work correctly. - Test the "Next" button without entering a vendor or a biblionumber. You should be warned about selecting a vendor and biblionumber. - After selecting a bibliographic record to link to the subscription, click the "Next" button. The second section of the subscription add form should be displayed. - Under frequency, choose "1/day." - Confirm that the "Show advanced pattern" link correctly toggles display of the advanced pattern form. - Under the advanced pattern form, test the "Modify pattern" button. It should enable editing in the form. - Test the "Cancel modifications" and "Save as new pattern" buttons. - Test the "Test prediction pattern" button. - In the "Prediction pattern" box, test that the checkboxes next to each day of the week, when checked, trigger the corresponding issue number to be marked as "not published." - Finally, confirm that your subscription is saved correctly. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54763&action=edit Bug 16963 - Remove the use of "onclick" from subscription add template This patch removes the use of event attributes from the subscription add template and the template for testing prediction patterns. Events are now defined in the JavaScript. To test, go to Serials -> New subscription. - Test that the "Search for vendor," "Search for record," and "Create record" links work correctly. - Test the "Next" button without entering a vendor or a biblionumber. You should be warned about selecting a vendor and biblionumber. - After selecting a bibliographic record to link to the subscription, click the "Next" button. The second section of the subscription add form should be displayed. - Under frequency, choose "1/day." - Confirm that the "Show advanced pattern" link correctly toggles display of the advanced pattern form. - Under the advanced pattern form, test the "Modify pattern" button. It should enable editing in the form. - Test the "Cancel modifications" and "Save as new pattern" buttons. - Test the "Test prediction pattern" button. - In the "Prediction pattern" box, test that the checkboxes next to each day of the week, when checked, trigger the corresponding issue number to be marked as "not published." - Finally, confirm that your subscription is saved correctly. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.