http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Sponsored by the Joensuu Regional Library -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22612|0 |1 is obsolete| | --- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 22649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22649&action=edit Bug 11175 - Show the parent records child records (aka. component parts) in the detailed views. TERMINOLOGY: "Child record" or "Component part": A Bibliographic record connected to it's host record via $773w -> 001 or via other Record-control-number-index relation. "Host record": A bibliographic record which contains child records. Host record doesn't have a link to the child record. USEFUL: For music cataloguers whose jobs depend on these. For browsing the contents of a musical record. Provides the basis for a high quality music library service. Because Koha has the building blocks to create these child records out of box, it is odd that they can't be displayed out of box. This patch adds a system preference AddChildRecordsToDetailedViews. This controls if child records data is appended after the bibliographic data for XSLT parsing. Also makes sure that child records are not pulled needlessly for non-detailed views as this would cripple performance. Modifies the default XSLT templates: MARC21slim2intranetDetail.xsl and MARC21slim2OPACDetail.xsl to display the child record data as HTML and link to the detailed views fopr the child records. Modifies .css files as well. An extra container div is added to opac-detail.tt, mimicking presentation in detail.tt, to prevent a possible long child records list from breaking the opac-details -view. -------------------------------------- TEST PLAN -------------------------------------- PREREQUISITES: -AddChildRecordsToDetailedViews system preference needs to be activated. -Catalog a bunch of child records for a host record. --Search a record and go to detailed view. --Use the existing functionality "+ New" -> "New Child Record" to catalog child records. ------------------------ TEST CASE1 - Staff client ------------------------ -Search for the record you just made and display it in the normal detail.pl -view. -Verify that a list of child records are displayed on the right side of the browser window. ------------------------ TEST CASE2 - OPAC ------------------------ -Search for the record you just made and display it in the opac-detail.pl -view. -Verify that a list of child records are displayed on the right side of the browser window. ------------------------ Thank you! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Garming Sam <garming@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |garming@catalyst.net.nz --- Comment #4 from Garming Sam <garming@catalyst.net.nz> --- Created attachment 23049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23049&action=edit Bug 11175 - Show the parent records child records (aka. component parts) in the detailed views. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- Quick note on this - the functionality is only available in the Prog theme - it will need to be added to the new default bootstrap theming. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22649|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, starting with a code review: - Small thing: Please break your commit messages into shorter lines so they are easier to read in a terminal window. - Please provide a follow-up for the Bootstrap theme. As prog and CCSR are going to be deprecated this is mandatory now. - Database update adding the new system preference is missing. - The way this is coded it's a MARC21 specific feature. The rcn index and 001 > $w linking are not MARC agnostic. Please check for the marcflavor in your code and include a note about the limitation to MARC21 in the syspref description. - Some of the comments look like TODOs - maybe something you want to take another look at? - Creating our 'own' XML in a MARCXML record doesn't look right to me. I would much prefer if that could be expressed in normal MARC21 fields and subfields. - With the heading "Child records" you assume that it will be always a component part, but that's not true. 001 > $w linkings are used to express a lot of different relationships between records. I think putting a bit more thought into the various relationships could be good here. Also the QA script points out some issues: FAIL C4/XSLT.pm FAIL pod *** ERROR: Unknown command 'head' in file C4/XSLT.pm *** ERROR: Spurious text after =cut in file C4/XSLT.pm OK forbidden patterns OK valid FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show the parent records |Show the parent record's |child records (aka. |component parts in the |component parts) in the |detailed views. |detailed views. | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #10 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 24789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24789&action=edit Bug 11175 - Show the parent record's component parts in the detailed views. Presentation for prog-theme. This displays the injected component part records in the prog theme. -------------------------------------- TEST PLAN -------------------------------------- PREREQUISITES: -AddChildRecordsToDetailedViews system preference needs to be activated. -opacthemes system preference needs to be 'prog'. -template system preference needs to be 'prog'. -Catalog a bunch of child records for a host record. --Search a record and go to detailed view. --Use the existing functionality "+ New" -> "New Child Record" to catalog child records. ------------------------ TEST CASE1 - Staff client ------------------------ -Reindex Zebra -Search for the record you just made childs for and display it in the normal detail.pl -view. -Verify that a list of child records are displayed on the right side of the browser window. ------------------------ TEST CASE2 - OPAC ------------------------ -Reindex Zebra -Search for the record you just made childs for and display it in the opac-detail.pl -view. -Verify that a list of child records are displayed on the right side of the browser window. ------------------------ Thank you! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- (In reply to Katrin Fischer from comment #7)

Hi,

starting with a code review:

Thank you for the effort Katrin! It is much appreciated!

- Small thing: Please break your commit messages into shorter lines so they are easier to read in a terminal window.

I hope it's better. I also hope with shorter lines you don't mean the dreaded 80 character maximum.

- Please provide a follow-up for the Bootstrap theme. As prog and CCSR are going to be deprecated this is mandatory now.

Follow up provided!

- Database update adding the new system preference is missing.

Provided!

- The way this is coded it's a MARC21 specific feature. The rcn index and 001 > $w linking are not MARC agnostic. Please check for the marcflavor in your code and include a note about the limitation to MARC21 in the syspref description.

Added a note to the system preference. Didn't add any syspref checks to the business layer. Uncertain if rcn is unused in UNIMARC. If rcn-index is unpopulated, then should cause zero extra overhead. If rcn is populated in UNIMARC, then this feature should work?

- Some of the comments look like TODOs - maybe something you want to take another look at?

Apologies for that. I think it was a classical mistake.

- Creating our 'own' XML in a MARCXML record doesn't look right to me. I would much prefer if that could be expressed in normal MARC21 fields and subfields.

I guess I could differentiate from the searched component part records the marc field they use to make the linking. All the data is available since the found records are converted into MARC::Record objects. Then this data could be injected to appropriate MARC::Fields to construct a proper marc record. If this behaviour is wanted maybe it is better to create them when these component part relations are defined? Thus these links would be preserved during MARC-export function. The effort however doesn't justify the perceived benefits in my opinion. If you can demonstrate the benefits (like displaying different kinds of component relations under different heading) a follow-up can be prepared and designed. Also a "own" XML in MARCXML is already there inside the <sysprefs>-tag.

- With the heading "Child records" you assume that it will be always a component part, but that's not true. 001 > $w linkings are used to express a lot of different relationships between records. I think putting a bit more thought into the various relationships could be good here.

You are very correct. I went to the MARC21 manual and looked into the various aspects of linkings. I changed the terminology to "child" -> "component part".

Also the QA script points out some issues:

FAIL C4/XSLT.pm FAIL pod *** ERROR: Unknown command 'head' in file C4/XSLT.pm *** ERROR: Spurious text after =cut in file C4/XSLT.pm I don't know from where these are coming from? OK forbidden patterns OK valid FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). Fixed this issue. perlcritic++

Happy to deliver! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23049|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24788|0 |1 is obsolete| | --- Comment #15 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 26402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26402&action=edit Bug 11175 - Show the parent record's component parts in the detailed views. Business layer. TERMINOLOGY: "Component part": A Bibliographic record connected to it's host record via $773w -> 001 or via other Record-control-number-index relation. "Host record": A bibliographic record which contains child records. Host record doesn't need to have a link to the child record. USEFUL: For music cataloguers whose jobs depend on these. For browsing the contents of a musical record. Provides the basis for a high quality music library service. Because Koha has the building blocks to create these component part records out of box, it is odd that they can't be displayed out of box. This patch adds a system preference AddComponentPartRecordsToDetailedViews. This controls if component part records data is appended after the bibliographic data for XSLT parsing. Also makes sure that component part records are not pulled needlessly for non-detailed views as this would cripple performance. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24791|0 |1 is obsolete| | --- Comment #17 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 26404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26404&action=edit Bug 11175 - Show the parent record's component parts in the detailed views. Presentation for bootstrap-theme. This displays the injected component part records in the bootstrap theme. -------------------------------------- TEST PLAN -------------------------------------- PREREQUISITES: -AddChildRecordsToDetailedViews system preference needs to be activated. -opacthemes system preference needs to be 'bootstrap'. -Catalog a bunch of child records for a host record. --Search a record and go to detailed view. --Use the existing functionality "+ New" -> "New Child Record" to catalog child records. ------------------------ TEST CASE1 - OPAC ------------------------ -Reindex Zebra -Search for the record you just made childs for and display it in the opac-detail.pl -view. -Verify that a list of child records are displayed on the right side of the browser window. ------------------------ Thank you! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #19 from David Cook <dcook@prosentient.com.au> --- I'm quite interested in linking records, so I might have to take a look at this one. I haven't reviewed the code or applied the patch yet, but how might this fare with a high number of child records? In the case of a journal with article component parts, you might have dozens, hundreds, or more child records for each parent. I wonder if this would be handled better by an AJAX call and using the relational database instead of XML records. In any case, I'll take a look later, but just a thought... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #21 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 26766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26766&action=edit Bug 11175 - Rebased to parse XML result from SimpleSearch instead of the ISO2709-version which it used to be. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12625 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd be interested in this as well :) -- You are receiving this mail because: You are watching all bug changes.