[Bug 41566] New: Tidy kohaTable block - catalogue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Bug ID: 41566 Summary: Tidy kohaTable block - catalogue Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41324 Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 [Bug 41324] Tidy kohaTable block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191103&action=edit Bug 41566: Tidy kohaTable - catalogue/issuehistory Patch from commit ada6d06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191104&action=edit Bug 41566: Tidy kohaTable - catalogue/itemsearch.tt Patch from commit 7e49732 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191105&action=edit Bug 41566: Tidy kohaTable - catalogue_detail.inc|catalogue/detail.tt This is a non-trivial one. * SpineLabelShowPrintOnBibDetails is removed from the controller and we fetch it from the Koha.Preference TT plugin (because it is how it should be) * A lot of JS variable instantiations are moved in a dedicated script tag: they all use TT plugins * We are using stores to permissions and sysprefs That's a lot of changes but nothing complicated, just a move from TT vars to JS vars To test this you will need to fully test the holdings tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191106&action=edit Bug 41566: catalogue - auto tidy Patch from commit 5933c95 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41560 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 [Bug 41560] Useless (and confusing) id attribute on a couple of script tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39715 [Bug 39715] Do not quote DataTables options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41624 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 [Bug 41624] Revert Bug 35211 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191106|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192726&action=edit Bug 41566: catalogue - auto tidy Patch from commit 0aeaf40 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191103|0 |1 is obsolete| | --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192787&action=edit Bug 41566: Tidy kohaTable - catalogue/issuehistory Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191104|0 |1 is obsolete| | --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192788&action=edit Bug 41566: Tidy kohaTable - catalogue/itemsearch.tt Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191105|0 |1 is obsolete| | --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192789&action=edit Bug 41566: Tidy kohaTable - catalogue_detail.inc|catalogue/detail.tt This is a non-trivial one. * SpineLabelShowPrintOnBibDetails is removed from the controller and we fetch it from the Koha.Preference TT plugin (because it is how it should be) * A lot of JS variable instantiations are moved in a dedicated script tag: they all use TT plugins * We are using stores to permissions and sysprefs That's a lot of changes but nothing complicated, just a move from TT vars to JS vars To test this you will need to fully test the holdings tables. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192726|0 |1 is obsolete| | --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192790&action=edit Bug 41566: catalogue - auto tidy Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192793&action=edit Bug 41566: (follow-up) Prevent runtime error by assigning int to ClaimReturnedLostValue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192793|0 |1 is obsolete| | --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192794&action=edit Bug 41566: (follow-up) Prevent runtime error by assigning fallback falsy value to ClaimReturnedLostValue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192787|0 |1 is obsolete| | Attachment #192788|0 |1 is obsolete| | Attachment #192789|0 |1 is obsolete| | Attachment #192790|0 |1 is obsolete| | Attachment #192794|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 195011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195011&action=edit Bug 41566: Tidy kohaTable - catalogue/issuehistory Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 195012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195012&action=edit Bug 41566: Tidy kohaTable - catalogue/itemsearch.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 195013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195013&action=edit Bug 41566: Tidy kohaTable - catalogue_detail.inc|catalogue/detail.tt This is a non-trivial one. * SpineLabelShowPrintOnBibDetails is removed from the controller and we fetch it from the Koha.Preference TT plugin (because it is how it should be) * A lot of JS variable instantiations are moved in a dedicated script tag: they all use TT plugins * We are using stores to permissions and sysprefs That's a lot of changes but nothing complicated, just a move from TT vars to JS vars To test this you will need to fully test the holdings tables. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 195014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195014&action=edit Bug 41566: catalogue - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 195015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195015&action=edit Bug 41566: (follow-up) Prevent runtime error by assigning fallback falsy value to ClaimReturnedLostValue Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 195016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195016&action=edit Bug 41566: (follow-up) More tidying required for itemsearch.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- With Paul's permission I have swapped our signoffs so that his can be considered QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |jacob.omara@openfifth.co.uk --- Comment #20 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Enhancement, not backporting. Scream at me if you feel strongly it should be backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197509&action=edit Bug 41566: Restore item groups ft This code was outside of document.ready before the previous changes. This patch fixes the whole item groups feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- In the follow-up I have to change: if (permissions.CAN_user_editcatalogue_manage_item_groups) { to if (Koha.permissions.CAN_user_editcatalogue_manage_item_groups) { then it works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42177 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 [Bug 42177] Cannot manage bundles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #24 from Andrii Nugged <nugged@gmail.com> --- + noItemTypeImages: [% Koha.Preference('noItemTypeImages') ? 1 : 0 | html %], - [% UNLESS noItemTypeImages %] + if (prefs.noItemTypeImages){ let image_location = item_type_image_locations[row.item_type_id]; node += image_location ? '<img class="itemtype-image" ... /> ' : ''; - [% END %] + } should it be inverted? I.e.: if (!Koha.prefs.noItemTypeImages) { ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42708 [Bug 42708] Itemtype images no longer displayed on the holdings table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Andrii Nugged from comment #24)
+ noItemTypeImages: [% Koha.Preference('noItemTypeImages') ? 1 : 0 | html %],
- [% UNLESS noItemTypeImages %] + if (prefs.noItemTypeImages){ let image_location = item_type_image_locations[row.item_type_id]; node += image_location ? '<img class="itemtype-image" ... /> ' : ''; - [% END %] + }
should it be inverted? I.e.:
if (!Koha.prefs.noItemTypeImages) {
?
Oops (again), yes definitely, thanks! See bug 42708. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 Bug 41566 depends on bug 41560, which changed state. Bug 41560 Summary: Useless (and confusing) id attribute on a couple of script tag https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org