[Bug 41324] New: Tidy kohaTable block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Bug ID: 41324 Summary: Tidy kohaTable block Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 39715 Blocks: 41323 Bug 39715 removed quotes around DataTables options. We should enforce it with a test to prevent further occurrences. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39715 [Bug 39715] Do not quote DataTables options https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41323 [Bug 41323] [OMNIBUS] Tidy script tags withing .tt files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189994&action=edit Bug 41324: Add a xt test Patch from commit a307855 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189995&action=edit Bug 41324: Tidy some kohaTable blocks - examples Commit using --no-verify to ease rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189996&action=edit Bug 41324: Tidy modified files Commit the tidiness perl misc/devel/tidy.pl $(git diff --name-only HEAD~1) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |lucas@bywatersolutions.com, | |martin.renvoize@openfifth.c | |o.uk, | |nick@bywatersolutions.com, | |oleonard@myacpl.org, | |paul.derscheid@lmscloud.de, | |tomascohen@gmail.com --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Patches for discussion. One last thing that is not tidy is the script tags from the .tt files. If script tags have TT tags, the prettier plugin cannot tidy them. I was trying to provide a solution to prevent regressions for bug 39715. I think this is great, but it will introduce conflicts. I am happy to continue, but I first need to know if people want that. The idea is to use JS variables instead of TT variables, and have the assignment in a first script block. example: ``` <script> // This cannot be tidy [% IF foo %] # do something [% ELSE %] let foo = 42; [% END %] </script> ``` => ``` <script> // This still cannot be tidy let foo = [% foo ? 1 : 0 %]; </script> <script> // But now this will be tidy automatically! if ( foo ) { # do something } else { let foo = 42; } </script> ``` On this bug report I will mainly focus on kohaTable, but it may actually impact whole template file. See also bug 41323 for the "remaining ones". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- I think this looks great, and is very much in line with what I was trying to do with bugs like bug 23885. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 [Bug 41563] Tidy kohaTable block - acqui -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41564 [Bug 41564] Tidy kohaTable block - admin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41565 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41565 [Bug 41565] Tidy kohaTable block - bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 [Bug 41566] Tidy kohaTable block - catalogue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41567 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41567 [Bug 41567] Tidy kohaTable block - cataloguing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41568 [Bug 41568] Tidy kohaTable block - circ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 [Bug 41569] Tidy kohaTable block - clubs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 [Bug 41570] Tidy kohaTable block - course_reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41571 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 [Bug 41571] Tidy kohaTable block - labels -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41572 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41572 [Bug 41572] Tidy kohaTable block - members -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41573 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 [Bug 41573] Tidy kohaTable block - patron_lists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41574 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 [Bug 41574] Tidy kohaTable block - patroncards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41575 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 [Bug 41575] Tidy kohaTable block - pos -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41576 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41576 [Bug 41576] Tidy kohaTable block - reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41577 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41577 [Bug 41577] Tidy kohaTable block - reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41578 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41578 [Bug 41578] Tidy kohaTable block - serials -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41579 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 [Bug 41579] Tidy kohaTable block - suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41580 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 [Bug 41580] Tidy kohaTable block - tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41581 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41581 [Bug 41581] Tidy kohaTable block - virtualshelves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41582 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41582 [Bug 41582] Tidy kohaTable block - opac -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- To achieve this, one child bug report has been created per module. Here is the test plan for all of them. 1. Variable serialization In most of the scripts we need to use Template::Toolkit variable (Perl) for JavaScript logic. We are simply going to serialize them. eg. my js_var = [% my_tt_var | html %]; That might generate my js_var = ; if the TT variable is not defined. To prevent invalid JS code we are going to surround it with quotes: my js_var = "[% my_tt_var | html %]"; This might be a problem when we compare strings and integer (keep in mind when testing). When we want to generate a boolean we will use: const js_var = [% tt_var ? 1 : 0 | html %]; No need to quote. 2. Use of permissions and sysprefs See 41562. For permissions and sysprefs we are going to use a global variable that will be shared between the different script tags. That will avoid situations where a JS variable is erased later in a separate script tag. 3. "table_settings" variable There may be a problem with the "table_settings" variable. In some scripts we have several variables named "table_settings", that causes problem in DT init. To prevent that we are simply going to rename the variable to make it more specific. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189994|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189995|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189996|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191189&action=edit Bug 41324: Add a xt test Patch from commit 170433c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- With all related bugs applied there is only one failure: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt it's a tricky one, I will clean it later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- All this is more than just about kohaTable: it tidy all script tags in the templates with kohaTable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |gitlab.com/joubu/Koha/-/com | |mits/bug_41324 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- The whole tree is available at https://gitlab.com/joubu/Koha/-/commits/bug_41324 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|gitlab.com/joubu/Koha/-/com |https://gitlab.com/joubu/Ko |mits/bug_41324 |ha/-/commits/bug_41324 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Why do we tidy script tags? 1. Consistency The entire codebase is already tidy, except script tags. 2. Detect error early Running Prettier on JS code helps catch syntax errors and potential issues earlier 3. Clear separation of concerns Isolate TT and JS variables make code more robust and maintainable. This separation also paves the way for migrating JS logic to dedicated .js files 4. Predictable refactoring Cleaning up script tags in bulk prevents unexpected large diffs later. Without this the tidy script might suddenly reformat a script tag when the last TT tag is removed, confusing the author of the change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41653 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 [Bug 41653] Stores for permissions and sysprefs should be under the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191189|0 |1 is obsolete| | --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192723&action=edit Bug 41324: Add a xt test Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- This works wonderfully. Got some expected failures right now, but the core of this refactor is solid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192728&action=edit Bug 41563: (follow-up) Tidy parcel.tt Patch from commit d3cee2d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192729&action=edit Bug 41563: Remove JS error from newordersuggestion Not caused by this patchset but it's a good place to fix it (and not add a conflict) Uncaught TypeError: can't access property "DataTable", suggestionst is undefined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192728|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192729|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41797 [Bug 41797] Tidy kohaTable block - reports/guided_reports_start -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- xt/tt_kohaTable_tidy.t is happy with the current tree. Remote branch updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38365 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 [Bug 38365] Add Content-Security-Policy HTTP header to HTML responses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195166&action=edit Bug 41324: Adjust test for bug 38365 The script tags now contain a TT tag <script nonce="[% Koha.CSPNonce | $raw %]"> It's not a problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- This is the regression test for the whole tree, it must be pushed right after the other dependent bug reports. Passing QA to not miss it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |https://wiki.koha-community release notes| |.org/wiki/Coding_Guidelines | |#JS19:_Avoid_Template::Tool | |kit_tags_in_script_tags --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- I've added a coding guideline: https://wiki.koha-community.org/wiki/Coding_Guidelines#JS19:_Avoid_Template:... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://gitlab.com/joubu/Ko | |ha/-/commits/bug_41324 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 [Bug 42094] Tidy all script tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |jacob.omara@openfifth.co.uk --- Comment #21 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Enhancement, not backporting. Scream at me if you feel strongly it should be backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 Bug 41324 depends on bug 41563, which changed state. Bug 41563 Summary: Tidy kohaTable block - acqui https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org