[Bug 36897] New: Make it possible to use select[multiple] and select[size] in a sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 Bug ID: 36897 Summary: Make it possible to use select[multiple] and select[size] in a sidebar Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com https://git.koha-community.org/Koha-community/Koha/src/commit/1ea4a11c2a88f7... sets the height of aside fieldset select to a calculated "one fat line" which is fine for <select>, but for <select multiple> and <select size="10"> it turns what should be a multiline box into one line with a nearly invisible scrollbar. The fix is simple, a rule (like the one that exists in bootstrap.scss, which isn't specific enough to overrule the aside fieldset select rule) right after that for select[multiple], select[size] { height: auto; } but I don't quite know how to formulate a test plan for something unused other than by the advanced cataloging editor, which is working around the problem in bug 36589. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 166916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166916&action=edit Bug 36897: Make it possible to use select[multiple] and select[size] in a sidebar Currently, if you put either <select multiple> or <select size="10"> in an <aside><fieldset> sidebar, you get a height of "one fat line" rather than the bigger box you would expect. Test plan: 1. Without the patch, load Reports - Use saved 2. Open Firefox developer tools to the Inspector tab 3. With the "Pick an element from the page" tool, click on the word "Filter" in the Reports page's sidebar 4. Just above that line in the HTML display is a <fieldset class="brief"> - right click that and choose Edit As HTML 5. After the fieldset element, paste <select multiple><option>one</option><option>two</option></select><select size="10"></select> 6. Click outside the editor to save your changes 7. Note that both new selects are only one line high 8. Apply patch, run yarn build, Shift+reload to clear your cache 9. Repeat steps 3 through 6 10. Note that both selects are more than one line high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- I use devtools to edit CSS all the time, but apparently I either never noticed it had an HTML editor, or forgot about it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166916|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166937&action=edit Bug 36897: Make it possible to use select[multiple] and select[size] in a sidebar Currently, if you put either <select multiple> or <select size="10"> in an <aside><fieldset> sidebar, you get a height of "one fat line" rather than the bigger box you would expect. Test plan: 1. Without the patch, load Reports - Use saved 2. Open Firefox developer tools to the Inspector tab 3. With the "Pick an element from the page" tool, click on the word "Filter" in the Reports page's sidebar 4. Just above that line in the HTML display is a <fieldset class="brief"> - right click that and choose Edit As HTML 5. After the fieldset element, paste <select multiple><option>one</option><option>two</option></select><select size="10"></select> 6. Click outside the editor to save your changes 7. Note that both new selects are only one line high 8. Apply patch, run yarn build, Shift+reload to clear your cache 9. Repeat steps 3 through 6 10. Note that both selects are more than one line high Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> ---
but I don't quite know how to formulate a test plan for something unused other than by the advanced cataloging editor, which is working around the problem in bug 36589.
If this is unused why do we need related CSS in Koha? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Because our existing CSS is wrong, and we don't want the next person who puts a multiple or sized <select> in a sidebar to have to figure out how it is wrong, and how to work around it being wrong. What the selector above the one added by this patch really meant was "select:not(multiple size)" (untested, I don't use :not() often), but since :not() is tricksy and expensive, it makes more sense to fix the wrongness by just adding a second selector to undo it when it shouldn't apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 --- Comment #6 from Phil Ringnalda <phil@chetcolibrary.org> --- Given that bug 36589 has made it to oldstable, and doesn't much look like it's going any further, I could add in reverting the patch for it, if that helps make this more attractive. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166937|0 |1 is obsolete| | --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 172375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172375&action=edit Bug 36897: Make it possible to use select[multiple] and select[size] in a sidebar Currently, if you put either <select multiple> or <select size="10"> in an <aside><fieldset> sidebar, you get a height of "one fat line" rather than the bigger box you would expect. Test plan: 1. Without the patch, load Reports - Use saved 2. Open Firefox developer tools to the Inspector tab 3. With the "Pick an element from the page" tool, click on the word "Filter" in the Reports page's sidebar 4. Just above that line in the HTML display is a <fieldset class="brief"> - right click that and choose Edit As HTML 5. After the fieldset element, paste <select multiple><option>one</option><option>two</option></select><select size="10"></select> 6. Click outside the editor to save your changes 7. Note that both new selects are only one line high 8. Apply patch, run yarn build, Shift+reload to clear your cache 9. Repeat steps 3 through 6 10. Note that both selects are more than one line high 11. Set the preference EnableAdvancedCatalogingEditor to Enable 12. Cataloging - Advanced editor 13. In the left sidebar, verify that the Clipboard is still 10 lines high, not one fat line like it was before bug 36589 Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172375|0 |1 is obsolete| | --- Comment #8 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 172376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172376&action=edit Bug 36897: Make it possible to use select[multiple] and select[size] in a sidebar Currently, if you put either <select multiple> or <select size="10"> in an <aside><fieldset> sidebar, you get a height of "one fat line" rather than the bigger box you would expect. Test plan: 1. Without the patch, load Reports - Use saved 2. Open Firefox developer tools to the Inspector tab 3. With the "Pick an element from the page" tool, click on the word "Filter" in the Reports page's sidebar 4. Just above that line in the HTML display is a <fieldset class="brief"> - right click that and choose Edit As HTML 5. After the fieldset element, paste <select multiple><option>one</option><option>two</option></select><select size="10"></select> 6. Click outside the editor to save your changes 7. Note that both new selects are only one line high 8. Apply patch, run yarn build, Shift+reload to clear your cache 9. Repeat steps 3 through 6 10. Note that both selects are more than one line high 11. Set the preference EnableAdvancedCatalogingEditor to Enable 12. Cataloging - Advanced editor 13. In the left sidebar, verify that the Clipboard is still 10 lines high, not one fat line like it was before bug 36589 Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 --- Comment #9 from Phil Ringnalda <phil@chetcolibrary.org> --- But although I don't use :not() often, we do, and every library we use does. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172376|0 |1 is obsolete| | --- Comment #10 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 179376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179376&action=edit Bug 36897: Make it possible to use select[multiple] and select[size] in a sidebar Currently, if you put either <select multiple> or <select size="10"> in an <aside><fieldset> sidebar, you get a height of "one fat line" rather than the bigger box you would expect. Test plan: 1. Without the patch, load Reports - Use saved 2. Open Firefox developer tools to the Inspector tab 3. With the "Pick an element from the page" tool, click on the word "Filter" in the Reports page's sidebar 4. Just above that line in the HTML display is a <fieldset class="brief"> - right click that and choose Edit As HTML 5. After the fieldset element, paste <select multiple><option>one</option><option>two</option></select><select size="10"></select> 6. Click outside the editor to save your changes 7. Note that both new selects are only one line high 8. Apply patch, run yarn build, Shift+reload to clear your cache 9. Repeat steps 3 through 6 10. Note that both selects are more than one line high 11. Set the preference EnableAdvancedCatalogingEditor to Enable 12. Cataloging - Advanced editor 13. In the left sidebar, verify that the Clipboard is still 10 lines high, not one fat line like it was before bug 36589 Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Automatic patch test results: â ï¸ The patch applies with fuzzy option (ignoring whitespace). This may indicate minor conflicts that need to be resolved. Details: Patch applies with fuzzy option (ignoring whitespace) This is an automated message from the patch testing system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179376|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 194250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194250&action=edit Bug 36897: Make it possible to use select[multiple] and select[size] in a sidebar Currently, if you put either <select multiple> or <select size="10"> in an <aside><fieldset> sidebar, you get a height of "one fat line" rather than the bigger box you would expect. Test plan: 1. Without the patch, load Reports - Use saved 2. Open Firefox developer tools to the Inspector tab 3. With the "Pick an element from the page" tool, click on the word "Filter" in the Reports page's sidebar 4. Just above that line in the HTML display is a <fieldset class="brief"> - right click that and choose Edit As HTML 5. After the fieldset element, paste <select multiple><option>one</option><option>two</option></select><select size="10"></select> 6. Click outside the editor to save your changes 7. Note that both new selects are only one line high 8. Apply patch, run yarn build, Shift+reload to clear your cache 9. Repeat steps 3 through 6 10. Note that both selects are more than one line high 11. Set the preference EnableAdvancedCatalogingEditor to Enable 12. Cataloging - Advanced editor 13. In the left sidebar, verify that the Clipboard is still 10 lines high, not one fat line like it was before bug 36589 Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com Comma delimited| |Chetco Community Public list of Sponsors| |Library Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194250|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 --- Comment #13 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 200593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200593&action=edit Bug 36897: Make it possible to use select[multiple] and select[size] in a sidebar Currently, if you put either <select multiple> or <select size="10"> in an <aside><fieldset> sidebar, you get a height of "one fat line" rather than the bigger box you would expect. Test plan: 1. Without the patch, load Reports - Use saved 2. Open Firefox developer tools to the Inspector tab 3. With the "Pick an element from the page" tool, click on the word "Filter" in the Reports page's sidebar 4. Just above that line in the HTML display is a <fieldset class="brief"> - right click that and choose Edit As HTML 5. After the fieldset element, paste <select multiple><option>one</option><option>two</option></select><select size="10"></select> 6. Click outside the editor to save your changes 7. Note that both new selects are only one line high 8. Apply patch, run yarn build, Shift+reload to clear your cache 9. Repeat steps 3 through 6 10. Note that both selects are more than one line high 11. Set the preference EnableAdvancedCatalogingEditor to Enable 12. Cataloging - Advanced editor 13. In the left sidebar, verify that the Clipboard is still 10 lines high, not one fat line like it was before bug 36589 Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 --- Comment #14 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36897 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 26.05.x backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org