[Bug 37812] New: Adjust Vue modals for Bootstrap 5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Bug ID: 37812 Summary: Adjust Vue modals for Bootstrap 5 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Modals in the Vue components (ERM, Preservation at least) are not displayed nicely.
From bug 37733 comment 0
""" 2. "Add to waiting list" modal is not centered http://localhost:8081/cgi-bin/koha/preservation/waiting-list https://snipboard.io/mIBYkj.jpg 3. Confirmation box "Are you sure you want to remove this item" is not centered correctly https://snipboard.io/ZgJFGC.jpg """ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170956&action=edit Bug 37812: Try to fix modal in the Preservation module We certainly need more as ERM module also use modals. And the Dialog component seems to have more elements affected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com, | |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I also started converting some from dialog to actual modal in Bug 37605 - Why do the vue apps use 'dialog' in place of modals? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170956|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171252&action=edit Bug 37812: Adjust modals from the Preservation module - bootstrap5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171253&action=edit Bug 37812: Adjust Dialog.vue component -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- This is how we should fix it IMO. However there are still quite a lot of work to do. https://snipboard.io/TJ9zek.jpg => OK https://snipboard.io/MQHoCt.jpg => Dropdown list's options are hidden behind the modal's footer https://snipboard.io/5ru41B.jpg => Could be better styled Do we want to go with toasts? (it's not introduced in Koha yet so I don't know if it's a good idea). There are also some "close"/"x" buttons that does not close/hide the modal. However the code is similar with other places where it is working... ? For discussion, please help! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- And I forgot this one: https://snipboard.io/rY90KF.jpg -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- This must be part of 24.11. At least the preservation module is unusable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #5)
Do we want to go with toasts? (it's not introduced in Koha yet so I don't know if it's a good idea).
Moved the discussion to its own bug, see bug 37939. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37939 [Bug 37939] Replace alert messages with toasts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- How can I trigger this modal?
https://snipboard.io/MQHoCt.jpg => Dropdown list's options are hidden behind the modal's footer
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171604&action=edit Bug 37812: Prevent "underflow" when using comboboxes in bootstrap modals -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171605&action=edit Bug 37812: Improve consistency of modal styling in Dialog.vue - Use modal-header for content, modal-footer for acknowledgement in alert type modal. - Conditionally render modal-body if message or inputs available. - Use modal footer for interactions and hide top border if body wasn't rendered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171625&action=edit Bug 37812: Prevent non-functional close buttons by using vue event handlers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Paul Derscheid from comment #12)
Created attachment 171625 [details] [review] Bug 37812: Prevent non-functional close buttons by using vue event handlers
Can you explain why some are working and others not? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- My suspicion that this has never worked is growing. I just rebuilt webpack using the old webpack config and without the last patch applied it doesn't work as expected either. I think what's happening is the following. Where the modals are in use they always hinge on a variable being defined (checked via v-if), if that variable is altered after an API call, the modal closes automatically. I need to look at more cases, so take this w/ a grain a salt. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171641&action=edit Bug 37812: Prevent initialisation failure by using modal methods, not plain show, hide -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #16 from Paul Derscheid <paul.derscheid@lmscloud.de> --- You were right joubu, it's not what I said in comment #14. It's so easy to miss and I kept looking in the wrong place. The simple reason that this failed in TrainsShow.vue was that the modal needs to be properly initialised by either data-bs-toggle="modal" or $(<id>).modal('show'), not plain $(<id>).show(). I finally saw the issue after I noticed that the backdrop was missing which screamed init failure. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Great, thanks a lot, Paul. Everything is working nicely now! The only thing I noticed it that the "warning" Dialogs do not close when clicking outside of the dialog. Not blocker ofc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #18 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Strange, I'll take a look at that in a bit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171651&action=edit Bug 37812: Fix a modal in the ERM module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- I think we are good for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37951 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171252|0 |1 is obsolete| | --- Comment #21 from David Nind <david@davidnind.com> --- Created attachment 171690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171690&action=edit Bug 37812: Adjust modals from the Preservation module - bootstrap5 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171253|0 |1 is obsolete| | --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 171691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171691&action=edit Bug 37812: Adjust Dialog.vue component Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171604|0 |1 is obsolete| | --- Comment #23 from David Nind <david@davidnind.com> --- Created attachment 171692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171692&action=edit Bug 37812: Prevent "underflow" when using comboboxes in bootstrap modals Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171605|0 |1 is obsolete| | --- Comment #24 from David Nind <david@davidnind.com> --- Created attachment 171693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171693&action=edit Bug 37812: Improve consistency of modal styling in Dialog.vue - Use modal-header for content, modal-footer for acknowledgement in alert type modal. - Conditionally render modal-body if message or inputs available. - Use modal footer for interactions and hide top border if body wasn't rendered. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171625|0 |1 is obsolete| | --- Comment #25 from David Nind <david@davidnind.com> --- Created attachment 171694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171694&action=edit Bug 37812: Prevent non-functional close buttons by using vue event handlers Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171641|0 |1 is obsolete| | --- Comment #26 from David Nind <david@davidnind.com> --- Created attachment 171695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171695&action=edit Bug 37812: Prevent initialisation failure by using modal methods, not plain show, hide Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171651|0 |1 is obsolete| | --- Comment #27 from David Nind <david@davidnind.com> --- Created attachment 171696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171696&action=edit Bug 37812: Fix a modal in the ERM module Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #28 from David Nind <david@davidnind.com> --- Created attachment 171697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171697&action=edit Screenshots od dialog boxes for the preservation and ERM modules - before and after Testing notes using KTD: 1. Enable the ERM and preservation modules . ERMModule = Enable . PreservationModule = Enable 2. Set up the preservation module for testing: 2.1 Go to Preservation > Settings. 2.2 For general settings: - Status for item added to waiting list: Not for loan 2.3 For Processings: - Add three processing steps called Step 1, Step 2, and Step 3: . Add new processing . Processing name: name of the step (Step 1, Step 2, and Step 3) . Submit 2.4 Add some items to the waiting list: - Waiting list > Add to waiting list - Use these barcodes: 39999000011418, 39999000000559, 39999000006155 2.5 Create a new train: - Trains > New train - Name: Train 1 - Description: Description - Default processing: Step 1 2.6 Add an item to a train - from the waiting list: - Waiting list > Add to waiting list - Immediatly after adding to the waiting list, select Add last 1 items to a train (unfer the "1 new items added." message) - Select a train and click Save 3. Set up the ERM module for testing: 3.1 Add a new agreement (Agreements > New agreement > add some information for the required fields) 3.2 Add a new license (Licenses > New license > add some information for the required fields) 3.3 Add a new package (eHoldings > Local > Packages > New package > add some information for the required fields) 3.4 Add a new title (eHoldings > Local > Titles > New title > add some information for the required fields) 3.5 Add a new data provider (eUsage > Data providers > New data provider > add some information for the required fields) 3.6 Create a report (eUsage > Reports > select the create report tab > add some information for the required fields > enter a report name and save the report) 4. Check these examples and note the display issues for the preservation module (see the before and after screenshots attachment to see the differences): 4.1 Delete a train (Trains > Delete (from the actions column)) 4.2 Add a new item to a train – not in the waiting list (Trains > Add items (from the actions column) > enter an invalid barcode such as 12345) 4.3 Remove an item from a train (Trains > select a train from the list of trains > Items > press the delete icon for an item) 4.4 Add items to the waiting list (Waiting list > Add to waiting list) 4.5 Remove an item from the waiting list (Waiting list > Remove (from the actions column)) 4.6 Remove a processing step (Settings > Processings > select Remove this processing for a step) 5. Check these examples and note the display issues for the ERM module (see the before and after screenshots attachment to see the differences): 5.1 Delete an agreement 5.2 Delete a license 5.3 Delete a package 5.4 Delete a title 5.5 Delete a data provider 5.6 Run a saved report 6. Apply the patches. 7. Rebuild the modules: yarn build 8. Restart everything: restart_all 9. Check the items in steps 4 and5, these should now display as they should and work as expected (see the before and after screenshots attachment). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171697|Screenshots od dialog boxes |Screenshots of dialog boxes description|for the preservation and |for the preservation and |ERM modules - before and |ERM modules - before and |after |after -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |the dialog boxes (Vue | |modals) for the ERM and | |preservation modules. (This | |is related to the OPAC and | |staff interface Bootstrap 5 | |upgrade in Koha 24.11.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171690|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171702&action=edit Bug 37812: Adjust modals from the Preservation module - bootstrap5 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171691|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171703&action=edit Bug 37812: Adjust Dialog.vue component Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171692|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171704&action=edit Bug 37812: Prevent "underflow" when using comboboxes in bootstrap modals Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171693|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171705&action=edit Bug 37812: Improve consistency of modal styling in Dialog.vue - Use modal-header for content, modal-footer for acknowledgement in alert type modal. - Conditionally render modal-body if message or inputs available. - Use modal footer for interactions and hide top border if body wasn't rendered. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171694|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171706&action=edit Bug 37812: Prevent non-functional close buttons by using vue event handlers Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171695|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171707&action=edit Bug 37812: Prevent initialisation failure by using modal methods, not plain show, hide Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171696|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171708&action=edit Bug 37812: Fix a modal in the ERM module Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great teamwork here, thanks to all involved. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #37 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Paul Derscheid from comment #18)
Strange, I'll take a look at that in a bit.
Maybe we should wait for you to have a look before pushing this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #38 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Just FYI, I know what the problem is with comment #18. Here it's the same thing as before. The modal is not properly initialised via the modal methods. I'm currently working on this, but I get a lot of cypress test failures, that I'm trying to fix first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #40 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Ah, that shouldn't have been pushed yet, will cause some cypress tests to fail because they were not adjusted after one of my patches. That's what I meant by comment #38. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #41 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171758&action=edit Bug 37812: (QA follow-up) Prevent lots of cypress test failures by reinserting 'confirmation' class on modal header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #42 from Paul Derscheid <paul.derscheid@lmscloud.de> --- That fixes 7/11. 4 to go. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #43 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171780&action=edit Bug 37812: (QA follow-up) Prevent cypress test failure by adjusting selector in DataProviders_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #44 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171781&action=edit Bug 37812: (QA follow-up) Prevent cypress test failures by correcting modal selector, removing ambiguity of contains calls, replace by get with respective ids -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #45 from Paul Derscheid <paul.derscheid@lmscloud.de> --- That's all cypress tests fixed. But there's still one thing to do, to initialise the modal in Dialog.vue with the bootstrap methods. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #46 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171786&action=edit Bug 37812: (QA follow-up) Add watchers for warning and confirmation prop and initialise modals with bootstrap methods on changes in Dialog.vue - Use more targeted selectors in cypress tests Trains.ts, WaitingList.ts. - Await result of accept_callback, then close modal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #47 from Paul Derscheid <paul.derscheid@lmscloud.de> --- That was the last one! Ready to push (after a sanity check, of course). All cypress tests still pass locally for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Follow-ups pushed, thanks Paul. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #49 from Jonathan Druart <jonathan.druart@gmail.com> --- Owen, Martin, I am wondering if the change "Submit" => "Save" for modals is correct. For instance we have "Add items to waiting list" and a "Save" button. Wasn't "Submit" more correct? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 --- Comment #50 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #49)
Owen, Martin, I am wondering if the change "Submit" => "Save" for modals is correct. For instance we have "Add items to waiting list" and a "Save" button. Wasn't "Submit" more correct?
So... the edit train form has "Submit" (I would have expected "Save"). Went to the "normal Koha" and found that adding a library has "Submit" and editing a bib record has "Save". I guess at this point we just don't care, right? :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37812 Bug 37812 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org