[Bug 40320] New: Missing Cypress tests for patron address display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Bug ID: 40320 Summary: Missing Cypress tests for patron address display Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org The changes on bug 40319 should be covered by tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40319, 40181 Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40181 [Bug 40181] Cypress tests - Ensure that insertData does not leave data in the DB https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40319 [Bug 40319] Fix spacing in address display include -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183843&action=edit Bug 40320: (bug 40319 follow-up) Add Cypress tests Test plan: Make sure the display of city, state and zipcode is the same as before the patch Confirm that the new Cypress tests pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183843|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183940&action=edit Bug 40320: (bug 40319 follow-up) Add Cypress tests Test plan: Make sure the display of city, state and zipcode is the same as before the patch Confirm that the new Cypress tests pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183940|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183944&action=edit Bug 40320: (bug 40319 follow-up) Add Cypress tests Test plan: Make sure the display of city, state and zipcode is the same as before the patch Confirm that the new Cypress tests pass Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- [FAIL] koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style.inc FAIL filters missing_filter at line 34 ( [%~ IF ( patron.city ) ~%][% ", " %][% END ~%]) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183944|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184369&action=edit Bug 40320: (bug 40319 follow-up) Add Cypress tests Test plan: Make sure the display of city, state and zipcode is the same as before the patch Confirm that the new Cypress tests pass Signed-off-by: Owen Leonard <oleonard@myacpl.org> Amended-by: Jonathan Druart Added $raw filter to [% ", " %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184369|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 186958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186958&action=edit Bug 40320: (bug 40319 follow-up) Add Cypress tests Test plan: Make sure the display of city, state and zipcode is the same as before the patch Confirm that the new Cypress tests pass Signed-off-by: Owen Leonard <oleonard@myacpl.org> Amended-by: Jonathan Druart Added $raw filter to [% ", " %] Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- No blocker just a comment: + [%~ IF ( patron.city ) ~%][% ", " | $raw %][% END ~%] This looks overcomplicated to me somehow. Note that the second tilde in the IF should do nothing. And what is the bonus of pushing a comma thru raw anyway? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #7)
No blocker just a comment: + [%~ IF ( patron.city ) ~%][% ", " | $raw %][% END ~%] This looks overcomplicated to me somehow. Note that the second tilde in the IF should do nothing. And what is the bonus of pushing a comma thru raw anyway?
IIRC We want to keep the space after the comma. If you have [% IF %], [% END %] then prettier will remove the space. Use TT [% ", " %] makes sure the space will stay. The filter is mandatory or find-missing-filters.t will fail (and better raw than html, we know there is nothing to escape). You can play with the code and the tests if you think there is a better solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8)
(In reply to Marcel de Rooy from comment #7)
No blocker just a comment: + [%~ IF ( patron.city ) ~%][% ", " | $raw %][% END ~%] This looks overcomplicated to me somehow. Note that the second tilde in the IF should do nothing. And what is the bonus of pushing a comma thru raw anyway?
IIRC We want to keep the space after the comma.
If you have [% IF %], [% END %] then prettier will remove the space. Use TT [% ", " %] makes sure the space will stay. The filter is mandatory or find-missing-filters.t will fail (and better raw than html, we know there is nothing to escape).
You can play with the code and the tests if you think there is a better solution.
prettier was not yet on my radar. No play, just push -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187013&action=edit Bug 40320: Use insertSamplePatron On commit 959b7e8f05059522151fb24992ed7250ac436dc1 Bug 40345: Add insertSamplePatron We remove the ability to insert a patron using insertObject, we need to use insertSamplePatron instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Bug 40320 depends on bug 40181, which changed state. Bug 40181 Summary: Cypress tests - Ensure that insertData does not leave data in the DB https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40181 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #13 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Will not be backported: depending on Bug 40319, not backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #14 from David Nind <david@davidnind.com> --- Test suite related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org