[Bug 38853] New: 'Cancel selected' on holds table does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Bug ID: 38853 Summary: 'Cancel selected' on holds table does not work Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 37783 To reproduce: 1) Place a hold on a record 2) On the "existing holds" table, check a hold. 3) Click 'Cancel selected". Nothing happens. Ever. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37783 [Bug 37783] Fix form that looks like it would POST without an op in reserve/request.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- No question, it should be buggy, and I see why (koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt#L1922 means to call the function .empty() but instead throws away the value of checking the property empty). But something is missing from those steps to reproduce: when I do that, place one any-copy hold on a record with no holds and then check the one hold and cancel selected, I get a background job scheduled which does cancel the hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Well, that was fun. Somehow my repo became convinced that origin/main was 23.11.x, so git checkout -b bug_38853 origin/main kept showing me that everything was working just fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 176306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176306&action=edit Bug 38853: Make 'Cancel selected' on holds table work Because 'Cancel selected' on the table of existing holds uses $("#cancel_modal_form #inputs").empty; rather than empty();, it fails to clear out whatever things are in there before it puts in the things it wants. That leaves things in a confused state, and makes it fail to actually cancel holds. Test plan: 1. Without the patch, add a hold to any bib record 2. Select the checkbox for the hold you placed, then click 'Cancel selected' and confirm that you want to cancel 3. Note that there's no message box about a background job having been enqueued, and no matter how long you wait, the hold doesn't go away 4. Apply patch, repeat step 2, note that there's now a message box, and when the background job finishes, that the hold has been deleted. Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176306|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 176327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176327&action=edit Bug 38853: Make 'Cancel selected' on holds table work Because 'Cancel selected' on the table of existing holds uses $("#cancel_modal_form #inputs").empty; rather than empty();, it fails to clear out whatever things are in there before it puts in the things it wants. That leaves things in a confused state, and makes it fail to actually cancel holds. Test plan: 1. Without the patch, add a hold to any bib record 2. Select the checkbox for the hold you placed, then click 'Cancel selected' and confirm that you want to cancel 3. Note that there's no message box about a background job having been enqueued, and no matter how long you wait, the hold doesn't go away 4. Apply patch, repeat step 2, note that there's now a message box, and when the background job finishes, that the hold has been deleted. Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |pedro.amorim@ptfs-europe.co |y.org |m CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176327|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176330&action=edit Bug 38853: Make 'Cancel selected' on holds table work Because 'Cancel selected' on the table of existing holds uses $("#cancel_modal_form #inputs").empty; rather than empty();, it fails to clear out whatever things are in there before it puts in the things it wants. That leaves things in a confused state, and makes it fail to actually cancel holds. Test plan: 1. Without the patch, add a hold to any bib record 2. Select the checkbox for the hold you placed, then click 'Cancel selected' and confirm that you want to cancel 3. Note that there's no message box about a background job having been enqueued, and no matter how long you wait, the hold doesn't go away 4. Apply patch, repeat step 2, note that there's now a message box, and when the background job finishes, that the hold has been deleted. Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Thanks for the fix and quick reaction Phil! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|37783 |34478 --- Comment #8 from Phil Ringnalda <phil@chetcolibrary.org> --- Better dependency, since it's still empty; and failing to empty() on 24.05, even though that doesn't have the patch to expose the failure in this particular way. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37783 [Bug 37783] Fix form that looks like it would POST without an op in reserve/request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the "Cancel release notes| |selected" button for a | |records' holds table in the | |staff interface - it now | |cancels the selected holds. | |Previously, after you | |confirmed the hold | |cancellation nothing | |happened (the background | |jobs didn't run and the | |holds were not cancelled). | |(This is related to the | |CSRF changes added in Koha | |24.05 to improve form | |security.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|kebliss@dmpl.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Eric Swenson <eric@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric@bywatersolutions.com --- Comment #9 from Eric Swenson <eric@bywatersolutions.com> --- Would it be possible to have this backported to 24.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression, | |rel_24_11_candidate CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Bug 38853 depends on bug 34478, which changed state. Bug 34478 Summary: Full CSRF protection https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org