https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38853 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176306|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 176327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176327&action=edit Bug 38853: Make 'Cancel selected' on holds table work Because 'Cancel selected' on the table of existing holds uses $("#cancel_modal_form #inputs").empty; rather than empty();, it fails to clear out whatever things are in there before it puts in the things it wants. That leaves things in a confused state, and makes it fail to actually cancel holds. Test plan: 1. Without the patch, add a hold to any bib record 2. Select the checkbox for the hold you placed, then click 'Cancel selected' and confirm that you want to cancel 3. Note that there's no message box about a background job having been enqueued, and no matter how long you wait, the hold doesn't go away 4. Apply patch, repeat step 2, note that there's now a message box, and when the background job finishes, that the hold has been deleted. Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.