[Bug 39809] New: Category name and code in red and italic in patron category form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Bug ID: 39809 Summary: Category name and code in red and italic in patron category form Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org In main, when I go to the patron category form, the required fields' inputs are in red and italic. To recreate: A.1. Go to Administration > Patron categories A.2. Click New category --> Notice the labels for Category code, Description and Category type are in italic (they used to be just red and bold, but not italic) A.3. Type in a code and a description --> Notice that the input is now in red and italic (it used to be black and regular/not italic) B.1. Go to Administration > Patron categories B.2. Click on an existing category --> Notice the description inside the input field is in red and italic (it used to be black and regular/not italic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 181832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181832&action=edit Screen capture of the top of the description input of an existing category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 181833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181833&action=edit Screen capture of the code and description input of a new category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Category name and code in |.required class was made |red and italic in patron |too non-specific in |category form |Bootstrap upgrade --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I mistakenly made the ".required" class too non-specific in the Bootstrap upgrade. <input> tags should not pick up the styles applied to <label>, <span>, and <div>. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181840&action=edit Bug 39809: .required class was made too non-specific in Bootstrap upgrade This patch corrects some CSS which was broken during the upgrade to Bootstrap 5. The .required class should not add any style differences to form fields. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Patron categories. - Edit an existing category. - Confirm that the contents of input fields are not styled red and italic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181840|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 181857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181857&action=edit Bug 39809: .required class was made too non-specific in Bootstrap upgrade This patch corrects some CSS which was broken during the upgrade to Bootstrap 5. The .required class should not add any style differences to form fields. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Patron categories. - Edit an existing category. - Confirm that the contents of input fields are not styled red and italic. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181857|0 |1 is obsolete| | --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 181868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181868&action=edit Bug 39809: .required class was made too non-specific in Bootstrap upgrade This patch corrects some CSS which was broken during the upgrade to Bootstrap 5. The .required class should not add any style differences to form fields. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Patron categories. - Edit an existing category. - Confirm that the contents of input fields are not styled red and italic. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thank you Owen, and David for testing. I added my sign-off too, even if it doesn't add much, but just as a thanks! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181966&action=edit Bug 39809: (follow-up) Remove left margin from label.required The left margin is only necessary for span.required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181966|0 |1 is obsolete| | --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 182044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182044&action=edit Bug 39809: (follow-up) Remove left margin from label.required The left margin is only necessary for span.required Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181868|0 |1 is obsolete| | --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184651&action=edit Bug 39809: .required class was made too non-specific in Bootstrap upgrade This patch corrects some CSS which was broken during the upgrade to Bootstrap 5. The .required class should not add any style differences to form fields. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Patron categories. - Edit an existing category. - Confirm that the contents of input fields are not styled red and italic. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182044|0 |1 is obsolete| | --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184652&action=edit Bug 39809: (follow-up) Remove left margin from label.required The left margin is only necessary for span.required Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch corrects the release notes| |styling of required fields | |so that the text entered in | |the input is no longer | |shown in red. Previously, | |the .required class was | |incorrectly applied to the | |input itself rather than | |just the label and required | |indicator. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |39483 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks like this change comes from Bug 39483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39483 [Bug 39483] Update staff interface forms to use grid layout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- 39483 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39809 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |david@davidnind.com Resolution|--- |FIXED --- Comment #16 from David Nind <david@davidnind.com> --- Bug fix, but may affect screenshots. Decided to close, and hope that automated screenshots (eventually) pick up any screenshots that need updating. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org