[Bug 38294] New: Checkbox/label for search filters incorrectly aligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 Bug ID: 38294 Summary: Checkbox/label for search filters incorrectly aligned Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org https://snipboard.io/vBcSKs.jpg -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17170, 35402 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Coming from bug 35402? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 Bug 38294 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Component|Searching |Templates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179555&action=edit Bug 38294: Fix layout of checkbox/label when editing search filters This patch makes a minor markup change in order to improve the alignment of controls for editing a search filter in the staff interface. To test, apply the patch and make sure the SavedSearchFilters system preference is enabled. - In the staff client catalog, perform a search. - At the top of the search results, click "Save search as filter". - Fill out the form and save the search filter. - Go to Administration -> Search filters. - Click the "Edit search" button for your filter. - You should be returned to the advanced search page and there should be an "Editing filter" form at the top. The "Show in OPAC" and "Show in staff interface" labels and checkboxes should be aligned neatly with the buttons in the toolbar. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39398 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39398 [Bug 39398] Improve style and layout of staff interface advanced search form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179555|0 |1 is obsolete| | --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 179627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179627&action=edit Bug 38294: Fix layout of checkbox/label when editing search filters This patch makes a minor markup change in order to improve the alignment of controls for editing a search filter in the staff interface. To test, apply the patch and make sure the SavedSearchFilters system preference is enabled. - In the staff client catalog, perform a search. - At the top of the search results, click "Save search as filter". - Fill out the form and save the search filter. - Go to Administration -> Search filters. - Click the "Edit search" button for your filter. - You should be returned to the advanced search page and there should be an "Editing filter" form at the top. The "Show in OPAC" and "Show in staff interface" labels and checkboxes should be aligned neatly with the buttons in the toolbar. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Status|Needs Signoff |Signed Off --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Because I can't read, I kept clicking the "Edit filter" button, which pops up a modal with the labels and checkboxes on different lines, rather than "Edit search." I'd happily sign off a patch that fixed "Edit filter." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179627|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 180438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180438&action=edit Bug 38294: Fix layout of checkbox/label when editing search filters This patch makes a minor markup change in order to improve the alignment of controls for editing a search filter in the staff interface. To test, apply the patch and make sure the SavedSearchFilters system preference is enabled. - In the staff client catalog, perform a search. - At the top of the search results, click "Save search as filter". - Fill out the form and save the search filter. - Go to Administration -> Search filters. - Click the "Edit search" button for your filter. - You should be returned to the advanced search page and there should be an "Editing filter" form at the top. The "Show in OPAC" and "Show in staff interface" labels and checkboxes should be aligned neatly with the buttons in the toolbar. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.05.00 |25.05.00,24.11.08 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org