[Bug 21934] New: Allow user to specify name for 'Shibboleth'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 Bug ID: 21934 Summary: Allow user to specify name for 'Shibboleth' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Many sites using SAML (Shibboleth) don't refer to their login as a 'Shibboleth login' We shoudl make it easy for the user to specify what they call the service -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 82825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82825&action=edit Bug 21934 - Allow user to specify name for 'Shibboleth' To test: 1 - Add a shibboleth config to your koha-conf.xml file (it does not need to be valid) <useshibboleth>1</useshibboleth> <shibboleth> <matchpoint>userid</matchpoint> <mapping> <userid is="uid"></userid> </mapping> </shibboleth> 2 - Note on staff and user auth pages the message says "Shibboleth account" 3 - Apply patch, update database 4 - Note login text has not changed 5 - Define a name in 'shibbolethName' 6 - Note it is reflected on all auth pages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches like these are problematic, because they make the text mono-lingual and harder to translate as we will be missing context. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83059&action=edit Bug 21934: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #2)
Patches like these are problematic, because they make the text mono-lingual and harder to translate as we will be missing context.
Won't the string showup in the PO as a string with a %s? So that the translation can be written in a sensible way, and the user should be aware of changing the text to fit the context? The other side is that we use a lot of jquery to change this and it is easy to miss - I suppose we could simply add a span whenever the word 'Shibboleth' is used if that is preferable? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Yeah, but translating '%s login failed' is harder then translating "Shibboleth login failed". It also means that you can't deal with those terms using .po files anymore, some might maintain their own .po files to deal with things like that. It forces people to use jQuery in order to have them multi-lingual. It makes it easy for everyone using only one language in their OPAC, but everyone who offers more than one, will still have to use jQuery. Just explaining where I am coming from. In the case of Shibboleth which is already an odd term... I won't block this. Just thinking this should not turn into a standard way of dealing with terms people want to change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... also: missing filters! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82825|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83116&action=edit Bug 21934 - Allow user to specify name for 'Shibboleth' To test: 1 - Add a shibboleth config to your koha-conf.xml file (it does not need to be valid) <useshibboleth>1</useshibboleth> <shibboleth> <matchpoint>userid</matchpoint> <mapping> <userid is="uid"></userid> </mapping> </shibboleth> 2 - Note on staff and user auth pages the message says "Shibboleth account" 3 - Apply patch, update database 4 - Note login text has not changed 5 - Define a name in 'shibbolethName' 6 - Note it is reflected on all auth pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- I agree with Katrin, this makes koha less translatable, it will directly impact a few of our customers and also lots of other Koha users. Can we come up with a better way of doing this (and also think of how we can move any of the stuff we currently have in sys prefs into a more translatable format) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Chris Cormack from comment #8)
I agree with Katrin, this makes koha less translatable, it will directly impact a few of our customers and also lots of other Koha users.
Can we come up with a better way of doing this (and also think of how we can move any of the stuff we currently have in sys prefs into a more translatable format)
I have been thinking about a better solution here too. My first thought is HTML customization, but if you look at Nick's patch you see that his changes are small ones that occur in several different places on the page. So I'm not sure if this will work with HTML customization. Would be very interested to hear other ideas that are not JavaScript. :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org