[Bug 40167] New: Curbside pickups - Show link if not configured
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 Bug ID: 40167 Summary: Curbside pickups - Show link if not configured Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Right now, it displays a warning message when you navigate to Circulation > Curbside pickups, but don't have them configured for the current branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40206 [Bug 40206] Cubrside pickups - Layout wrong when 'CircSidebar' enabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |Curbside pickups function| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 183397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183397&action=edit Bug 40167: Curbside pickups - Show link if not configured If curbside pickups are not configured for the current branch, a correct message is displayed. It would be helpful to provide a link to the configuration page right there, if the patron has permissions to set it. This patch just adds that. To test: 1. Enable Curbside pickups 2. Make sure you are in a branch that doesn't have any rules for curbside pickups 3. Go to Circulation > Curbside pickups => SUCCESS: A message about curbside pickups not being configured is displayed 4. Apply this patch 5. Repeat 3 (reload?) => SUCCESS: The message is displayed, but you can now follow a link to configure the rules. 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183397|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183400&action=edit Bug 40167: Curbside pickups - Show link if not configured If curbside pickups are not configured for the current branch, a correct message is displayed. It would be helpful to provide a link to the configuration page right there, if the patron has permissions to set it. This patch just adds that. To test: 1. Enable Curbside pickups 2. Make sure you are in a branch that doesn't have any rules for curbside pickups 3. Go to Circulation > Curbside pickups => SUCCESS: A message about curbside pickups not being configured is displayed 4. Apply this patch 5. Repeat 3 (reload?) => SUCCESS: The message is displayed, but you can now follow a link to configure the rules. 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183401&action=edit Bug 40167: (follow-up) Tweak message text I've reworded the message a little bit in order to make it easier to translate and to make sure the link is descriptive. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Signed Off |BLOCKED --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Dependency is FQA, setting to BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183400|0 |1 is obsolete| | Attachment #183401|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 201760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201760&action=edit Bug 40167: Curbside pickups - Show link if not configured If curbside pickups are not configured for the current branch, a correct message is displayed. It would be helpful to provide a link to the configuration page right there, if the patron has permissions to set it. This patch just adds that. To test: 1. Enable Curbside pickups 2. Make sure you are in a branch that doesn't have any rules for curbside pickups 3. Go to Circulation > Curbside pickups => SUCCESS: A message about curbside pickups not being configured is displayed 4. Apply this patch 5. Repeat 3 (reload?) => SUCCESS: The message is displayed, but you can now follow a link to configure the rules. 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 201761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201761&action=edit Bug 40167: (follow-up) Tweak message text I've reworded the message a little bit in order to make it easier to translate and to make sure the link is descriptive. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 Bug 40167 depends on bug 40206, which changed state. Bug 40206 Summary: Curbside pickups - Layout wrong when 'CircSidebar' enabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40206 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40167 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit | |y.org | Status|Signed Off |Patch doesn't apply --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches currently don't apply for me, can you please rebase? Error: Apply failed: Git command (git am -3 /tmp/HtPPlfcIWy/0001-201760.patch) failed: error: Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org