https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #954 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- Created attachment 205599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205599&action=edit Bug 10190: (QA follow-up): fixes phase five 1. apply html filter to letters so notice names are escaped (must be done in attribute so the JSON format of the letters can be parsed). 2. fix a correctness issue where the frontend was pinning the logged in library instead of the logged in user's home library, which would have led to 403s (correct) when saving rules. Since the library dropdown is deliberately disabled unless a user has the manage_circ_rules_from_any_libraries permission, the user would then have needed to use 'Set library' to match their home library to fix this. Prevent the issue by setting the library to the user's home library. Also rename the variable to user_library_id. 3. list_rules correctly references /api/v1/circulation_rules/kinds 4. make untranslatable strings translatable 5. swap svg for font-awesome icon. 6. avoid css duplication: - remove dead / unused scoped css (leftover from an early component extraction) - import vue.css and only leave the minimal override required. 7. improve set_rules test coverage: add tests for manage_circ_rules / manage_circ_triggers separation Test plan: 1) Administration > Circulation triggers: notice the 'Letter' dropdowns list circulation notices as "name (code)" and offer 'No letter'. (no regression) 2) Give a staff user 'catalogue' + 'manage_circ_triggers' only, with home library A. Log in as them, 'Set library' to B, and open Administration > Circulation triggers. Notice the view is pinned to A, and that adding and editing a trigger saves without a 403. (behaviour is now correct) 3) GET /api/v1/circulation_rules?rules=nosuchrule - notice the error points at /api/v1/circulation_rules/kinds. (behaviour is now correct) 4) Run 'gulp po:update --lang fr-FR'. Notice 'Add new trigger {triggerNumber}', 'No letter' and 'any' now appear in misc/translator/po/fr-FR-messages-js.po (behaviour is now correct) 5) Edit a trigger. Notice the delay's reset button is an 'x' inside the input, left of the chevrons, and clears the delay; the letter's reset button does the same for the notice. (no regression) 6) Notice no visual regression across the list, add, edit, reset and delete screens - select widths, chevrons and modals unchanged. Also run t/db_dependent/api/v1/circulation_rules.t Assisted-by: Claude Opus 5 (Anthropic) Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.